Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: build cdk image once for all e2e test jobs #206

Merged
merged 3 commits into from
Nov 28, 2024

Conversation

leovct
Copy link
Member

@leovct leovct commented Nov 28, 2024

Description

Rather than building the cdk image in each test job, create it in an initial job and reuse that built image for all subsequent test jobs.

It also bumps to the latest kurtosis-cdk version.

E2E tests pass on my fork: https://github.com/leovct/cdk/actions/runs/12069227043

@leovct leovct marked this pull request as ready for review November 28, 2024 11:36
@leovct leovct marked this pull request as draft November 28, 2024 13:36
Copy link
Collaborator

@Stefan-Ethernal Stefan-Ethernal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM

@Stefan-Ethernal Stefan-Ethernal marked this pull request as ready for review November 28, 2024 13:41
@Stefan-Ethernal Stefan-Ethernal marked this pull request as draft November 28, 2024 13:43
@leovct leovct marked this pull request as ready for review November 28, 2024 15:34
@Stefan-Ethernal Stefan-Ethernal merged commit f153be1 into 0xPolygon:develop Nov 28, 2024
4 of 5 checks passed
@leovct leovct deleted the ci/simplify-e2e-tests branch November 28, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants