fix: reorg detector and syncer issues on develop
#272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goran-ethernal
force-pushed
the
fix/reorg-detector-syncer-issues-cherry-pick
branch
5 times, most recently
from
434d530 to
80c6240
Compare
goran-ethernal
force-pushed
the
fix/reorg-detector-syncer-issues-cherry-pick
branch
from
80c6240 to
3de7f02
Compare
goran-ethernal
requested review from
arnaubennassar,
joanestebanr and
ToniRamirezM
goran-ethernal
changed the title
reorg detector and syncer issues cherry-pick to developreorg detector and syncer issues on develop
joanestebanr
requested changes
Jan 22, 2025
|
joanestebanr
approved these changes
Jan 23, 2025
ToniRamirezM
approved these changes
Jan 23, 2025
goran-ethernal
deleted the
fix/reorg-detector-syncer-issues-cherry-pick
branch
This was referenced Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issues found on the
l1infotreesyncerandreorg detector, when we might not be tracking a correct block hash in thereorg detector.It also fixes an issue when download channel is closing, it passes an empty block object (since it is passing objects by value and not by reference), with number 0, and empty hash, which processor passes to the
reorg detectorwhich is not correct.Important Note:
e2etests usesumulated clientas thel1 clientnode, which only knows ofSafeBlocks. That is why this PR expanded the constructor function of theEVMDownloaderto receivefinalizedBlockTypeparameter. When we run thecdknode or any syncer that syncs data fromL1, thefinalizedBlockTypeisFinalizedBlockas seen in therun.go.e2etests useSafeBlock.Also,
L2does not have a notion ofFinalizedBlock, sobridgeL2Syncerwill use theLatestBlockfor this parameter.Fixes # (issue)