Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialise app simulation tests #10

Merged
merged 8 commits into from
Mar 15, 2024
Merged

Conversation

Raneet10
Copy link
Member

Description

This PR adds simulation tests for heimdall app, currently borrowing Simapp's tests and benchmarks but can be later customized for our modules.

Changes

  • Bugfix (non-breaking change that solves an issue)
  • Hotfix (change that solves an urgent issue, and requires immediate attention)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (change that is not backwards-compatible and/or changes current functionality)
  • Changes only for a subset of nodes

Checklist

  • I have added at least 2 reviewer or the whole pos-v1 team
  • I have added sufficient documentation in code
  • I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply

Testing

  • I have added unit tests
  • I have added tests to CI
  • I have tested this code manually on local environment
  • I have tested this code manually on remote devnet using express-cli
  • I have tested this code manually on mumbai
  • I have created new e2e tests into express-cli

Copy link

@lasarojc lasarojc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test is failing its setup. Since the problem is not in the test itself, merging it will keep the error flag raised.

@Raneet10 Raneet10 mentioned this pull request Mar 13, 2024
14 tasks
@marcello33
Copy link
Contributor

Please solve conflicts

@Raneet10 Raneet10 merged commit 9e3df79 into raneet10/pos-1944 Mar 15, 2024
3 of 4 checks passed
@Raneet10 Raneet10 deleted the raneet10/pos-1950 branch March 15, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants