Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

type2: Do not hash code non-deterministically #381

Closed
Nashtare opened this issue Jul 11, 2024 · 1 comment
Closed

type2: Do not hash code non-deterministically #381

Nashtare opened this issue Jul 11, 2024 · 1 comment
Assignees
@Nashtare
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Milestone
Type 2 - CDK Erig...

Comments

@Nashtare
Copy link
Collaborator

The type2 code currently generates account's codehash non-deterministically.
We need to bring the padding strategy in the KERNEL directly, and leverage it in create.asm and process_txn.asm, and remove the method from PROVER_INPUT.

See related TODOs there.
@Nashtare Nashtare added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Jul 11, 2024
@Nashtare Nashtare added this to the Type 2 - Q3 2024 milestone Jul 11, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Jul 11, 2024
@Nashtare Nashtare self-assigned this Jul 11, 2024
@Nashtare Nashtare mentioned this issue Jul 11, 2024
Merged
@Nashtare
Copy link
Collaborator Author

Done in #386

@github-project-automation github-project-automation bot moved this from Backlog to Done in Zero EVM Jul 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Nashtare Nashtare

Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
Type 2 - CDK Erigon (Q4 2024)
Development

No branches or pull requests
1 participant
@Nashtare