Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address over-aggressive sub-trie pruning #91

Closed
pgebheim opened this issue Mar 6, 2024 · 0 comments · Fixed by #97
Closed

Address over-aggressive sub-trie pruning #91

pgebheim opened this issue Mar 6, 2024 · 0 comments · Fixed by #97
Assignees
Labels
bug Something isn't working crate: trace_decoder Anything related to the trace_decoder crate.

Comments

@pgebheim
Copy link
Contributor

pgebheim commented Mar 6, 2024

The issue was traversing hash nodes was overly aggressive pruning and checking that the extension & leaf nibbles matched the remaining part of the key when creating sub-tries. Even if the remaining key does not match, we still need to include the node.

There is still something else however where some nodes are being hashed out that shouldn’t be. Will update when I know more.

@pgebheim pgebheim added bug Something isn't working crate: trace_decoder Anything related to the trace_decoder crate. labels Mar 6, 2024
@pgebheim pgebheim added this to the Type 1 milestone Mar 6, 2024
@github-project-automation github-project-automation bot moved this to Backlog in Zero EVM Mar 6, 2024
@pgebheim pgebheim moved this from Backlog to In Progress in Zero EVM Mar 6, 2024
@pgebheim pgebheim linked a pull request Mar 11, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from In Progress to Done in Zero EVM Mar 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
2 participants