Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MCOPY from rebasing #103

Merged
merged 1 commit into from
Mar 11, 2024
Merged

Fix MCOPY from rebasing #103

merged 1 commit into from
Mar 11, 2024

Conversation

Nashtare
Copy link
Collaborator

Some changes when rebasing from main weren't properly applied to MCOPY, leading all calls to the opcode to fail.

@Nashtare Nashtare added the bug Something isn't working label Mar 11, 2024
@Nashtare Nashtare self-assigned this Mar 11, 2024
@Nashtare Nashtare added this to the Cancun - Q1 2024 milestone Mar 11, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Mar 11, 2024
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Nashtare Nashtare merged commit 366e0a2 into feat/cancun Mar 11, 2024
6 checks passed
@Nashtare Nashtare deleted the fix-mcopy branch March 11, 2024 13:51
BGluth pushed a commit that referenced this pull request Jun 17, 2024
* feat: add txHash to ZeroTrace

Retrieve block witness with a separate rpc call

* fix: update zk_evm dependency to develop branch

* fix: comments

* fix: use zk_evm v0.4.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants