-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
continuations: Remove the need for dummy segments #245
Merged
Merged
Changes from 37 commits
Commits
Show all changes
38 commits
Select commit
Hold shift + click to select a range
02a2849
Implement single-segment aggregations
hratoanina 65d8771
Change log test
hratoanina 6141e52
Don't generate dummy segment data
hratoanina b7c0fe0
Fix dummy proof setting
hratoanina 5b22d34
Make dummy proof out of dummy circuit
hratoanina db9a8f2
Try to generate dummy proof
hratoanina 26d02b6
Add import
hratoanina 187e96e
Add pis to dummy proof
hratoanina f8806fd
Update method name
hratoanina 2a2d4a4
Fix PV connection
Nashtare 4c00a54
Fix wire set twice
LindaGuiga 2891246
Update ranges
Nashtare 7c9f63a
Merge remote-tracking branch 'origin/feat/continuations' into no_dumm…
Nashtare 0804c38
Add getter and handle single segment
Nashtare ee16349
Dummy segments, new version
hratoanina 73fdf94
Fix AggChildWithDummy
LindaGuiga 2941d72
Update to latest version of zkevm_no_dummy_segment
LindaGuiga 483de98
Add is_dummy to ProverOutputData, remove the special logic for dummy …
LindaGuiga bc3933b
Update proof_gen
LindaGuiga 540949e
Merge branch 'feat/continuations' into no_dummy_segment_no_pis
LindaGuiga 58d1e6a
Cleanup and add missing connections in create_segment_aggregation_cir…
LindaGuiga 37fdf73
Merge branch 'feat/continuations' into no_dummy_segment_no_pis
LindaGuiga 8205e53
Merge branch 'feat/continuations' into no_dummy_segment_no_pis
LindaGuiga 08dd0ab
Create generate_next_segment and make_dummy_segment
LindaGuiga 5578e8b
Add debug log
LindaGuiga 717d29c
Have teh SegmentDataIterator in zk_evm and change prove_all_segments …
LindaGuiga 3261e62
Remove dummy segment in SegmentDataIterator
LindaGuiga a289b7a
Clippy and cleanup
LindaGuiga 6eee424
Merge branch 'feat/continuations' into no_dummy_segment_no_pis
LindaGuiga 60f67a8
Apply comments
LindaGuiga 0153a62
Remove segments from AggregatableTxnProofs
LindaGuiga 0f5c185
Rename SegmentAggregatableProof variant
hratoanina cfd1fcf
Fix generate_segment_agg_proof
LindaGuiga e3d7220
Merge branch 'feat/continuations' into no_dummy_segment_no_pis
LindaGuiga 354db88
Merge branch 'continuations-next-segment' into no_dummy_segment_no_pis
hratoanina 87fa930
Apply comments
LindaGuiga 1380841
Use reference for GenerationInputs in SegmentDataIterator
LindaGuiga b9c1ce7
Reintroduce changes to TxnAggregatableProof for zero-bin compatibility
LindaGuiga File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We'll be doing a release this week normally, so can probably hold off until then and revert to using version tags
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the end we didn't end up using the API changes on plonky2 right? With the new approach for dummy segment removal. Do we still need a version bump there? (It's not included in #276 as per discussion in the sync meeting).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I had missed this comment before: we still need methods such as conditional_assert_eq which are not on Plonky2 v.0.2.2.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah but we won't be bumping plonky2 yet (because of the STARK batching thing), so we can keep the
main
reference / commit rev for the time being.