Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cancun): handle KZG precompile errors properly #251

Merged
merged 1 commit into from
May 28, 2024

Conversation

Nashtare
Copy link
Collaborator

Fix KZG precompile failures. They were previously aborting proof generation with PI errors. Now they properly throw a fault exception.

Tested with txn 10 of witness-0006.json

@Nashtare Nashtare added the bug Something isn't working label May 27, 2024
@Nashtare Nashtare added this to the Cancun - Q2 2024 milestone May 27, 2024
@Nashtare Nashtare requested review from hratoanina and LindaGuiga May 27, 2024 15:02
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label May 27, 2024
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

@Nashtare Nashtare merged commit 82d4901 into feat/cancun May 28, 2024
6 checks passed
@Nashtare Nashtare deleted the cancun/fix_kzg_failure branch May 28, 2024 11:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants