fix: scale withdrawals amount to gwei #371
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Withdrawals amounts that are written in blocks are in
gwei
unit (cf EIP-4895). We were currently processing them aswei
, causing invalid balances on the targets and yielding invalid final state root. This hasn't been caught beforehand because:withdrawals_root
in the statement, hence no discrepancy noticedWe'd need to add some sanity checks to compare with the block header, but the response we keep post RPC requests does not currently contain the header's state root. Will add a tracking issue for it.