-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use typed tries in trace_decoder #393
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good with this. I have one question though. Have you tried benchmarking this vs the old version?
No, but zk_evm/trace_decoder/src/lib.rs Lines 16 to 17 in a5b92b2
If I had to guess, worst case we've got constant overhead, but I think this mostly just changes where |
Yeah it's not a requirement to be more performant or anything, hence why I approved. I was just being nosey |
#275
Change summary:
typed_mpt::{StateTrie, StorageTrie, ..}
.type1
frontend emits the above.type1
frontend is cleaner.