Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use typed tries in trace_decoder #393

Merged
merged 7 commits into from
Jul 18, 2024
Merged

Conversation

0xaatif
Copy link
Contributor

@0xaatif 0xaatif commented Jul 15, 2024

#275

Change summary:

  • Add typed_mpt::{StateTrie, StorageTrie, ..}.
  • type1 frontend emits the above.
  • type1 frontend is cleaner.

@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels Jul 15, 2024
@0xaatif 0xaatif added this to the Type 2 - Q3 2024 milestone Jul 15, 2024
@0xaatif 0xaatif marked this pull request as draft July 16, 2024 17:25
@0xaatif
Copy link
Contributor Author

0xaatif commented Jul 16, 2024

Drafting to wait for #400

@0xaatif 0xaatif marked this pull request as ready for review July 17, 2024 13:07
@0xaatif 0xaatif enabled auto-merge (squash) July 17, 2024 13:09
Copy link
Contributor

@muursh muursh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good with this. I have one question though. Have you tried benchmarking this vs the old version?

@0xaatif
Copy link
Contributor Author

0xaatif commented Jul 18, 2024

I have one question though. Have you tried benchmarking this vs the old version?

No, but

//! # Non-Goals
//! - Performance - this won't be the bottleneck in any proving system.

If I had to guess, worst case we've got constant overhead, but I think this mostly just changes where rlp::decode/rlp::encode calls (to behind the type)

@muursh
Copy link
Contributor

muursh commented Jul 18, 2024

I have one question though. Have you tried benchmarking this vs the old version?

No, but

//! # Non-Goals
//! - Performance - this won't be the bottleneck in any proving system.

If I had to guess, worst case we've got constant overhead, but I think this mostly just changes where rlp::decode/rlp::encode calls (to behind the type)

Yeah it's not a requirement to be more performant or anything, hence why I approved. I was just being nosey

@0xaatif 0xaatif merged commit f531584 into develop Jul 18, 2024
14 checks passed
@0xaatif 0xaatif deleted the 0xaatif/typed-mpt branch July 18, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants