Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

suggestion: store max_cpu_len in Interpreter #80

Merged
merged 6 commits into from
Mar 6, 2024
Merged

suggestion: store max_cpu_len in Interpreter #80

merged 6 commits into from
Mar 6, 2024

Conversation

dvdplm
Copy link
Contributor

@dvdplm dvdplm commented Mar 4, 2024 •
edited
Loading

As a followup to an earlier comment, I tried removing the argument to run() and instead store the max_cpu_len inside the Interpreter. Seems to work alright?

@dvdplm dvdplm requested a review from LindaGuiga March 4, 2024 12:56
@dvdplm dvdplm mentioned this pull request Mar 4, 2024
Merged
LindaGuiga
LindaGuiga approved these changes Mar 4, 2024
View reviewed changes
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good indeed, thank you!

@dvdplm dvdplm marked this pull request as ready for review March 4, 2024 17:03
@dvdplm dvdplm requested review from wborgeaud and muursh as code owners March 4, 2024 17:03
@Nashtare Nashtare added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Mar 6, 2024
@LindaGuiga LindaGuiga merged commit dbd313a into continuation_to_zkevm Mar 6, 2024
5 checks passed
@LindaGuiga LindaGuiga deleted the dp-stateful-interpreter-max_cpu_len branch March 6, 2024 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@4l0n50 4l0n50 4l0n50 left review comments

@Nashtare Nashtare Nashtare left review comments

@LindaGuiga LindaGuiga LindaGuiga approved these changes

@wborgeaud wborgeaud Awaiting requested review from wborgeaud

@muursh muursh Awaiting requested review from muursh

Assignees
No one assigned
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dvdplm @muursh @4l0n50 @Nashtare @LindaGuiga