Unify MemBefore and MemAfer #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
muursh
reviewed
Mar 5, 2024
| //! It contains (addr, value) pairs. Note that non-padding addresses must be | ||
| //! unique. | ||
| use crate::memory::VALUE_LIMBS; | ||
|
|
||
| /// 1 if this is an actual final value, or 0 if it's a padding row. | ||
| /// 1 if and actual value or 0 if it's a padding row. |
Nashtare
added
the
crate: evm_arithmetization
LindaGuiga
approved these changes
Mar 6, 2024
| pub(crate) fn generate_trace( | ||
| &self, | ||
| mem_before_values: &MemBeforeValues, | ||
| final_values: Vec<Vec<F>>, |
There was a problem hiding this comment.
It looks like it can either be mem_before_values or final_values.
Suggested change
| final_values: Vec<Vec<F>>, | |
| propagated_values: Vec<Vec<F>>, |
| ); | ||
| let mem_after_trace = timed!( | ||
| timing, | ||
| "generate mem_after trace", | ||
| all_stark | ||
| .mem_after_stark | ||
| .generate_trace(&final_values, timing) | ||
| .generate_trace(final_values.clone(), timing) |
There was a problem hiding this comment.
Why do we now need to clone?
There was a problem hiding this comment.
Actually, I just noticed there was a clone anyway, so nervemind my comment, sorry!
LindaGuiga
merged commit a592594
into
0xPolygonZero:continuation_to_zkevm
5 checks passed
BGluth
pushed a commit
that referenced
this pull request
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MemBeforeStarkandMemAfterStarkare almost the same thing. The only difference is how they are connected toMemoryStark, using different CTL filters. This PR creates a singleMemoryContinuationStarkwhich is instantiated twice inAllStark.