Fix trie output when debugging final root mismatch #86
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@BGluth I ended up adding some labels for the final trie checks, as we always do this locally when debugging anyway |
Nashtare
added
the
crate: evm_arithmetization
BGluth
approved these changes
Mar 6, 2024
Comment on lines
+94
to
+99
| PUSH 1 // initial trie data length | ||
| global check_state_trie: | ||
| %mpt_hash_state_trie %mload_global_metadata(@GLOBAL_METADATA_STATE_TRIE_DIGEST_AFTER) %assert_eq | ||
| global check_txn_trie: | ||
| %mpt_hash_txn_trie %mload_global_metadata(@GLOBAL_METADATA_TXN_TRIE_DIGEST_AFTER) %assert_eq | ||
| global check_receipt_trie: |
There was a problem hiding this comment.
Yeah I guess we have been adding these in locally for so long that maybe it makes more sense just to get this into main. 🙃
| } | ||
|
|
||
| // Retrieve previous PC (before jumping to KernelPanic), to see if we reached | ||
| // `hash_final_tries`. We will output debugging information on the final |
There was a problem hiding this comment.
nit: I think you changed hash_final_tries --> perform_final_checks (which is a much better name).
There was a problem hiding this comment.
Oops, yes I did, thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon Kernel failure when comparing resulting tries post txn execution, we recompute the tries that plonky2 internally calculated (if
log::Level::Debugor deeper is enabled) for debugging.However it currently fails when the receipts contain more than 1 log because of a missing offset increment. This wasn't caught when failures were encountered among the integration tests here because none of them have actual logs.
This can be tested against the
log_opcodetests by adding aPANICsay before the final%jump(halt), and calling:RUST_LOG=debug cargo test --release --test log_opcode test_log_opcodes -- --ignoredwhich will result in an "
Computed receipts trie: Err(IntegerTooLarge)" issue.The PR also: