Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistency with the standard for burn and operatorBurn #57

Open
daejunpark opened this issue Aug 10, 2018 · 1 comment
Open

Inconsistency with the standard for burn and operatorBurn #57

daejunpark opened this issue Aug 10, 2018 · 1 comment

Comments

@daejunpark
Copy link

daejunpark commented Aug 10, 2018 •
edited
Loading

There is a discrepancy between the standard and the reference implementation regarding the burn and operatorBurn functions:

The current standard (https://github.com/ethereum/EIPs/blob/b41669ede219b9599a6a1c637e578b8a444ad6b1/EIPS/eip-777.md) says:

The data field of the tokensToSend hook MUST be empty.

But, the current reference implementation doesn't check (or enforce) the emptiness (of _holderData):

https://github.com/jacquesd/ERC777/blob/896d077eb4b1beb0fc2258f9d4dff4b60478a479/contracts/ERC777BaseToken.sol#L202
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@daejunpark @tomtomjhj