refacto?(api): add 'forAdmin' in method in target-profile-api

Author: Alexandre-Monney

Diff for: api/src/prescription/target-profile/application/api/target-profile-api.js

@@ -21,12 +21,12 @@ export const getByOrganizationId = async (organizationId) => {
 
 /**
  * @function
- * @name getById
+ * @name getByIdForAdmin
  *
  * @param {number} id
  * @returns {Promise<TargetProfile>}
  */
-export const getById = async (id) => {
+export const getByIdForAdmin = async (id) => {
   const targetProfileForAdmin = await usecases.getTargetProfileForAdmin({ targetProfileId: id });
 
   return new TargetProfile(targetProfileForAdmin);

Diff for: api/tests/prescription/target-profile/acceptance/application/api/target-profile-api_test.js

@@ -14,13 +14,13 @@ describe('Acceptance | Application | target-profile-api', function () {
     });
   });
 
-  describe('#getById', function () {
+  describe('#getByIdForAdmin', function () {
     it('should not fail', async function () {
       const targetProfileId = databaseBuilder.factory.buildTargetProfile().id;
 
       await databaseBuilder.commit();
 
-      const result = await targetProfileApi.getById(targetProfileId);
+      const result = await targetProfileApi.getByIdForAdmin(targetProfileId);
       expect(result).to.be.ok;
     });
   });

Diff for: api/tests/prescription/target-profile/unit/application/api/target-profile-api_test.js

@@ -7,7 +7,7 @@ import { catchErr, expect, sinon } from '../../../../../test-helper.js';
 import { domainBuilder } from '../../../../../tooling/domain-builder/domain-builder.js';
 
 describe('Unit | API | TargetProfile', function () {
-  describe('#getById', function () {
+  describe('#getByIdForAdmin', function () {
     it('should return target profile', async function () {
       const targetProfileId = 1;
       const targetProfileForAdmin = domainBuilder.buildTargetProfileForAdmin({ id: targetProfileId });
@@ -16,7 +16,7 @@ describe('Unit | API | TargetProfile', function () {
       const getTargetProfileForAdminStub = sinon.stub(usecases, 'getTargetProfileForAdmin');
       getTargetProfileForAdminStub.withArgs({ targetProfileId }).resolves(targetProfileForAdmin);
 
-      const targetProfile = await targetProfileApi.getById(targetProfileId);
+      const targetProfile = await targetProfileApi.getByIdForAdmin(targetProfileId);
 
       expect(targetProfile).to.deep.equal(expectedTargetProfile);
     });
@@ -27,7 +27,7 @@ describe('Unit | API | TargetProfile', function () {
       const getTargetProfileForAdminStub = sinon.stub(usecases, 'getTargetProfileForAdmin');
       getTargetProfileForAdminStub.withArgs({ targetProfileId }).rejects();
 
-      const error = await catchErr(targetProfileApi.getById)(targetProfileId);
+      const error = await catchErr(targetProfileApi.getByIdForAdmin)(targetProfileId);
 
       expect(error).to.be.ok;
     });