[TECH] Suppression des paramètres non utilisés de l'algo flash (PIX-15475).

 #10678

Author: pix-service-auto-merge

admin/app/components/administration/certification/flash-algorithm-configuration/form.gjs

@@ -18,10 +18,6 @@ import { t } from 'ember-intl';
         }}</:label>
     </PixInput>
 
-    <PixInput {{on "input" @updateNumberValues}} @id="warmUpLength" @value={{@form.warmUpLength}} type="number" min="0">
-      <:label>{{t "pages.administration.certification.flash-algorithm-configuration.form.warmUpLength"}}</:label>
-    </PixInput>
-
     <PixInput
       {{on "input" @updateNumberValues}}
       @id="challengesBetweenSameCompetence"
@@ -44,28 +40,6 @@ import { t } from 'ember-intl';
       <:label>{{t "pages.administration.certification.flash-algorithm-configuration.form.variationPercent"}}</:label>
     </PixInput>
 
-    <PixInput
-      {{on "input" @updateNumberValues}}
-      @id="variationPercentUntil"
-      @value={{@form.variationPercentUntil}}
-      type="number"
-      min="0"
-    >
-      <:label>{{t
-          "pages.administration.certification.flash-algorithm-configuration.form.variationPercentUntil"
-        }}</:label>
-    </PixInput>
-
-    <PixInput
-      {{on "input" @updateNumberValues}}
-      @id="doubleMeasuresUntil"
-      @value={{@form.doubleMeasuresUntil}}
-      type="number"
-      min="0"
-    >
-      <:label>{{t "pages.administration.certification.flash-algorithm-configuration.form.doubleMeasuresUntil"}}</:label>
-    </PixInput>
-
     <PixCheckbox
       {{on "input" @updateCheckboxValues}}
       @id="limitToOneQuestionPerTube"

admin/app/components/administration/certification/flash-algorithm-configuration/index.gjs

@@ -12,11 +12,8 @@ export default class FlashAlgorithmConfiguration extends Component {
   @service pixToast;
   @tracked form = {
     maximumAssessmentLength: this.args.model.maximumAssessmentLength,
-    warmUpLength: this.args.model.warmUpLength,
     challengesBetweenSameCompetence: this.args.model.challengesBetweenSameCompetence,
     variationPercent: this.args.model.variationPercent,
-    variationPercentUntil: this.args.model.variationPercentUntil,
-    doubleMeasuresUntil: this.args.model.doubleMeasuresUntil,
     limitToOneQuestionPerTube: this.args.model.limitToOneQuestionPerTube,
     enablePassageByAllCompetences: this.args.model.enablePassageByAllCompetences,
   };

admin/app/models/flash-algorithm-configuration.js

@@ -1,14 +1,9 @@
 import Model, { attr } from '@ember-data/model';
 
 export default class FlashAlgorithmConfiguration extends Model {
-  @attr('number') warmUpLength;
   @attr('number') maximumAssessmentLength;
   @attr('number') challengesBetweenSameCompetence;
   @attr('number') variationPercent;
-  @attr('number') variationPercentUntil;
-  @attr('number') doubleMeasuresUntil;
   @attr('boolean') limitToOneQuestionPerTube;
   @attr('boolean') enablePassageByAllCompetences;
-  @attr('array') forcedCompetences;
-  @attr('array') minimumEstimatedSuccessRateRanges;
 }

admin/tests/integration/components/administration/certification/flash-algorithm-configuration_test.gjs

@@ -11,11 +11,8 @@ module('Integration | Component |  administration/certification/flash-algorithm-
     // given
     const flashAlgorithmConfiguration = {
       maximumAssessmentLength: 1,
-      warmUpLength: 2,
       challengesBetweenSameCompetence: 3,
       variationPercent: 4,
-      variationPercentUntil: 5,
-      doubleMeasuresUntil: 6,
       limitToOneQuestionPerTube: true,
       enablePassageByAllCompetences: false,
     };
@@ -29,21 +26,12 @@ module('Integration | Component |  administration/certification/flash-algorithm-
     const maximumAssessmentLength = await screen.getByRole('spinbutton', {
       name: t('pages.administration.certification.flash-algorithm-configuration.form.maximumAssessmentLength'),
     }).value;
-    const warmUpLength = await screen.getByRole('spinbutton', {
-      name: t('pages.administration.certification.flash-algorithm-configuration.form.warmUpLength'),
-    }).value;
     const challengesBetweenSameCompetence = await screen.getByRole('spinbutton', {
       name: t('pages.administration.certification.flash-algorithm-configuration.form.challengesBetweenSameCompetence'),
     }).value;
     const variationPercent = await screen.getByRole('spinbutton', {
       name: t('pages.administration.certification.flash-algorithm-configuration.form.variationPercent'),
     }).value;
-    const variationPercentUntil = await screen.getByRole('spinbutton', {
-      name: t('pages.administration.certification.flash-algorithm-configuration.form.variationPercentUntil'),
-    }).value;
-    const doubleMeasuresUntil = await screen.getByRole('spinbutton', {
-      name: t('pages.administration.certification.flash-algorithm-configuration.form.doubleMeasuresUntil'),
-    }).value;
     const limitToOneQuestionPerTube = await screen.getByRole('checkbox', {
       name: t('pages.administration.certification.flash-algorithm-configuration.form.limitToOneQuestionPerTube'),
     }).checked;
@@ -52,11 +40,8 @@ module('Integration | Component |  administration/certification/flash-algorithm-
     }).checked;
 
     assert.strictEqual(maximumAssessmentLength, '1');
-    assert.strictEqual(warmUpLength, '2');
     assert.strictEqual(challengesBetweenSameCompetence, '3');
     assert.strictEqual(variationPercent, '4');
-    assert.strictEqual(variationPercentUntil, '5');
-    assert.strictEqual(doubleMeasuresUntil, '6');
     assert.true(limitToOneQuestionPerTube);
     assert.false(enablePassageByAllCompetences);
   });

admin/tests/unit/adapters/flash-algorithm-configuration-test.js

@@ -25,7 +25,7 @@ module('Unit | Adapters | flash-algorithm-configuration', function (hooks) {
   module('#createRecord', () => {
     test('should call the post url with the correct payload', async function (assert) {
       // given
-      const flashAlgorithmConfiguration = { warmUpLength: 2 };
+      const flashAlgorithmConfiguration = { enablePassageByAllCompetences: true };
       const payload = { data: flashAlgorithmConfiguration };
       const adapter = this.owner.lookup('adapter:flash-algorithm-configuration');
       sinon.stub(adapter, 'ajax');

admin/tests/unit/components/administration/certification/flash-algorithm-configuration-test.js

@@ -28,11 +28,8 @@ module('Unit | Component | authenticated/certifications/flash-algorithm-configur
 
       const flashAlgorithmConfiguration = {
         maximumAssessmentLength: 0,
-        warmUpLength: 1,
         challengesBetweenSameCompetence: 2,
         variationPercent: 3,
-        variationPercentUntil: 4,
-        doubleMeasuresUntil: 5,
         limitToOneQuestionPerTube: true,
         enablePassageByAllCompetences: true,
       };
@@ -72,11 +69,8 @@ module('Unit | Component | authenticated/certifications/flash-algorithm-configur
 
         const flashAlgorithmConfiguration = {
           maximumAssessmentLength: 0,
-          warmUpLength: 1,
           challengesBetweenSameCompetence: 2,
           variationPercent: 3,
-          variationPercentUntil: 4,
-          doubleMeasuresUntil: 5,
           limitToOneQuestionPerTube: true,
           enablePassageByAllCompetences: true,
         };

admin/translations/en.json

@@ -402,13 +402,10 @@
           "title": "Configuration de l’algorithme de déroulé du test",
           "form": {
             "challengesBetweenSameCompetence": "Nombre de questions entre 2 questions de la même compétence",
-            "doubleMeasuresUntil": "Nombre de questions pour la double mesure",
             "enablePassageByAllCompetences": "Forcer le passage par les 16 compétences",
             "limitToOneQuestionPerTube": "Limiter à une question par sujet",
             "maximumAssessmentLength": "Nombre de questions",
-            "variationPercent": "Capage de la capacité (en % )",
-            "variationPercentUntil": "Nombre de questions pour le capage de la capacité",
-            "warmUpLength": "Nombre de questions d'entraînement"
+            "variationPercent": "Capage de la capacité (en % )"
           }
         },
         "sco-whitelist": {

admin/translations/fr.json

@@ -412,13 +412,10 @@
           "title": "Configuration de l’algorithme de déroulé du test",
           "form": {
             "challengesBetweenSameCompetence": "Nombre de questions entre 2 questions de la même compétence",
-            "doubleMeasuresUntil": "Nombre de questions pour la double mesure",
             "enablePassageByAllCompetences": "Forcer le passage par les 16 compétences",
             "limitToOneQuestionPerTube": "Limiter à une question par sujet",
             "maximumAssessmentLength": "Nombre de questions",
-            "variationPercent": "Capage de la capacité (en % )",
-            "variationPercentUntil": "Nombre de questions pour le capage de la capacité",
-            "warmUpLength": "Nombre de questions d'entraînement"
+            "variationPercent": "Capage de la capacité (en % )"
           }
         },
         "sco-whitelist": {

api/db/database-builder/factory/build-flash-algorithm-configuration.js

@@ -2,29 +2,19 @@ import { config } from '../../../src/shared/config.js';
 import { databaseBuffer } from '../database-buffer.js';
 
 const buildFlashAlgorithmConfiguration = function ({
-  warmUpLength = null,
-  forcedCompetences = [],
   maximumAssessmentLength = config.v3Certification.numberOfChallengesPerCourse,
   challengesBetweenSameCompetence = null,
-  minimumEstimatedSuccessRateRanges = [],
   limitToOneQuestionPerTube = null,
   enablePassageByAllCompetences = false,
-  doubleMeasuresUntil = null,
   variationPercent = null,
-  variationPercentUntil = null,
   createdAt = new Date(),
 } = {}) {
   const values = {
-    warmUpLength,
     maximumAssessmentLength,
     challengesBetweenSameCompetence,
-    forcedCompetences: JSON.stringify(forcedCompetences),
-    minimumEstimatedSuccessRateRanges: JSON.stringify(minimumEstimatedSuccessRateRanges),
     limitToOneQuestionPerTube,
     enablePassageByAllCompetences,
-    doubleMeasuresUntil,
     variationPercent,
-    variationPercentUntil,
     createdAt,
   };
 

api/db/migrations/20241128152506_remove-unused-columns-in-flash-algorithm-configurations-table.js

@@ -0,0 +1,29 @@
+const TABLE_NAME = 'flash-algorithm-configurations';
+const WARM_UP_LENGTH_COLUMN_NAME = 'warmUpLength';
+const FORCED_COMPETENCES_COLUMN_NAME = 'forcedCompetences';
+const MINIMUM_ESTIMATED_SUCCESS_RATE_RANGES_COLUMN_NAME = 'minimumEstimatedSuccessRateRanges';
+const DOUBLE_MEASURES_UNTIL_COLUMN_NAME = 'doubleMeasuresUntil';
+const VARIATION_PERCENT_UNTIL_COLUMN_NAME = 'variationPercentUntil';
+
+const up = function (knex) {
+  return knex.schema.table(TABLE_NAME, (table) => {
+    table.dropColumn(WARM_UP_LENGTH_COLUMN_NAME);
+    table.dropColumn(FORCED_COMPETENCES_COLUMN_NAME);
+    table.dropColumn(MINIMUM_ESTIMATED_SUCCESS_RATE_RANGES_COLUMN_NAME);
+    table.dropColumn(DOUBLE_MEASURES_UNTIL_COLUMN_NAME);
+    table.dropColumn(VARIATION_PERCENT_UNTIL_COLUMN_NAME);
+    table.comment(`Configuration parameters used to alter the behaviour of the flash algorithm.`);
+  });
+};
+
+const down = function (knex) {
+  return knex.schema.table(TABLE_NAME, (table) => {
+    table.integer(WARM_UP_LENGTH_COLUMN_NAME);
+    table.jsonb(FORCED_COMPETENCES_COLUMN_NAME);
+    table.jsonb(MINIMUM_ESTIMATED_SUCCESS_RATE_RANGES_COLUMN_NAME);
+    table.integer(DOUBLE_MEASURES_UNTIL_COLUMN_NAME);
+    table.integer(VARIATION_PERCENT_UNTIL_COLUMN_NAME);
+  });
+};
+
+export { down, up };

api/db/seeds/data/team-certification/data-builder.js

@@ -118,16 +118,11 @@ async function _createScoCertificationCenter({ databaseBuilder }) {
 
 function _createV3CertificationConfiguration({ databaseBuilder }) {
   databaseBuilder.factory.buildFlashAlgorithmConfiguration({
-    warmUpLength: null,
-    forcedCompetences: [],
     maximumAssessmentLength: 32,
     challengesBetweenSameCompetence: null,
-    minimumEstimatedSuccessRateRanges: [],
     limitToOneQuestionPerTube: true,
     enablePassageByAllCompetences: true,
-    doubleMeasuresUntil: null,
     variationPercent: 0.5,
-    variationPercentUntil: null,
     createdAt: new Date('1977-10-19'),
   });
 }

api/lib/domain/usecases/get-next-challenge-for-campaign-assessment.js

@@ -65,10 +65,7 @@ const _hasAnsweredToAllChallenges = ({ possibleChallenges }) => {
 
 const _createDefaultAlgorithmConfiguration = () => {
   return new FlashAssessmentAlgorithmConfiguration({
-    warmUpLength: 0,
-    forcedCompetences: [],
     limitToOneQuestionPerTube: false,
-    minimumEstimatedSuccessRateRanges: [],
     enablePassageByAllCompetences: false,
   });
 };

api/scripts/certification/next-gen/generate-flash-algorithm-configuration.js

@@ -35,15 +35,11 @@ const register = async (server) => {
         ],
         validate: {
           payload: Joi.object({
-            warmUpLength: Joi.number().integer().min(0).allow(null).optional(),
-            forcedCompetences: Joi.array().items(Joi.string()).optional(),
             maximumAssessmentLength: Joi.number().integer().min(0).allow(null).optional(),
             challengesBetweenSameCompetence: Joi.number().integer().min(0).allow(null).optional(),
             limitToOneQuestionPerTube: Joi.boolean().optional(),
             enablePassageByAllCompetences: Joi.boolean().optional(),
-            doubleMeasuresUntil: Joi.number().min(0).allow(null).optional(),
             variationPercent: Joi.number().min(0).max(1).allow(null).optional(),
-            variationPercentUntil: Joi.number().min(0).allow(null).optional(),
           }),
         },
         handler: flashAssessmentConfigurationController.createFlashAssessmentConfiguration,