fix(api): encode email query parameter to prevent blank on + character

Author: Libouk

api/src/identity-access-management/domain/emails/create-warning-connection.email.js

@@ -27,7 +27,7 @@ export function createWarningConnectionEmail({ locale, email, firstName, validat
 
   const { i18n, defaultVariables } = factory;
   const pixAppUrl = urlBuilder.getPixAppBaseUrl(locale);
-  const resetUrl = `${pixAppUrl}/mot-de-passe-oublie?lang=${lang}&email=${email}`;
+  const resetUrl = `${pixAppUrl}/mot-de-passe-oublie?lang=${lang}&email=` + encodeURIComponent(`${email}`);
 
   return factory.buildEmail({
     template: mailer.warningConnectionTemplateId,

api/tests/identity-access-management/unit/domain/emails/create-warning-connection.email.test.js

@@ -59,7 +59,7 @@ describe('Unit | Identity Access Management | Domain | Email | create-warning-co
         'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Fpix.org%2Fen%2Fsupport';
 
       const expectedResetUrl =
-        'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.org%2Fmot-de-passe-oublie%3Flang%3Den%26email%3Dtoto%40example.net';
+        'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.org%2Fmot-de-passe-oublie%3Flang%3Den%26email%3Dtoto%2540example.net';
       expect(resetUrl).to.equal(expectedResetUrl);
       expect(helpDeskUrl).to.equal(expectedSupportUrl);
     });
@@ -83,7 +83,7 @@ describe('Unit | Identity Access Management | Domain | Email | create-warning-co
       const expectedSupportUrl =
         'https://test.app.pix.fr/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Fpix.fr%2Fsupport';
       const expectedResetUrl =
-        'https://test.app.pix.fr/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.fr%2Fmot-de-passe-oublie%3Flang%3Dfr%26email%3Dtoto%40example.net';
+        'https://test.app.pix.fr/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.fr%2Fmot-de-passe-oublie%3Flang%3Dfr%26email%3Dtoto%2540example.net';
       expect(resetUrl).to.equal(expectedResetUrl);
       expect(helpDeskUrl).to.equal(expectedSupportUrl);
     });
@@ -107,7 +107,7 @@ describe('Unit | Identity Access Management | Domain | Email | create-warning-co
       const expectedSupportUrl =
         'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Fpix.org%2Ffr%2Fsupport';
       const expectedResetUrl =
-        'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.org%2Fmot-de-passe-oublie%3Flang%3Dfr%26email%3Dtoto%40example.net';
+        'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.org%2Fmot-de-passe-oublie%3Flang%3Dfr%26email%3Dtoto%2540example.net';
       expect(resetUrl).to.equal(expectedResetUrl);
       expect(helpDeskUrl).to.equal(expectedSupportUrl);
     });
@@ -129,12 +129,38 @@ describe('Unit | Identity Access Management | Domain | Email | create-warning-co
       // then
       const { resetUrl, helpDeskUrl } = email.variables;
       const expectedResetUrl =
-        'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.org%2Fmot-de-passe-oublie%3Flang%3Dnl%26email%3Dtoto%40example.net';
+        'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.org%2Fmot-de-passe-oublie%3Flang%3Dnl%26email%3Dtoto%2540example.net';
 
       const expectedSupportUrl =
         'https://test.app.pix.org/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Fpix.org%2Fnl-be%2Fsupport';
       expect(resetUrl).to.equal(expectedResetUrl);
       expect(helpDeskUrl).to.equal(expectedSupportUrl);
     });
   });
+
+  describe('when the email query parameter contains a +', function () {
+    it('provides the correct urls', function () {
+      // given
+      const emailParams = {
+        email: 'toto+tata@example.net',
+        locale: 'fr-fr',
+        firstName: 'John',
+        validationToken: 'token',
+      };
+
+      // when
+      const email = createWarningConnectionEmail(emailParams);
+
+      //https://test.app.pix.fr/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.fr%2Fmot-de-passe-oublie%3Flang%3Dfr%26email%3Dtoto%2Btata%40example.net
+
+      // then
+      const { helpDeskUrl, resetUrl } = email.variables;
+      const expectedSupportUrl =
+        'https://test.app.pix.fr/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Fpix.fr%2Fsupport';
+      const expectedResetUrl =
+        'https://test.app.pix.fr/api/users/validate-email?token=token&redirect_url=https%3A%2F%2Ftest.app.pix.fr%2Fmot-de-passe-oublie%3Flang%3Dfr%26email%3Dtoto%252Btata%2540example.net';
+      expect(resetUrl).to.equal(expectedResetUrl);
+      expect(helpDeskUrl).to.equal(expectedSupportUrl);
+    });
+  });
 });