feat(api): added feature in tests where an organization is created

Author: alicegoarnisson

api/tests/acceptance/application/organizations/organization-controller_test.js

@@ -24,6 +24,8 @@ describe('Acceptance | Application | organization-controller', function () {
   beforeEach(async function () {
     server = await createServer();
     await insertUserWithRoleSuperAdmin();
+    databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT);
+    await databaseBuilder.commit();
   });
 
   describe('POST /api/admin/organizations', function () {

api/tests/integration/domain/usecases/create-organization_test.js

@@ -4,12 +4,14 @@ import { OrganizationForAdmin } from '../../../../src/organizational-entities/do
 import * as dataProtectionOfficerRepository from '../../../../src/organizational-entities/infrastructure/repositories/data-protection-officer.repository.js';
 import { organizationForAdminRepository } from '../../../../src/organizational-entities/infrastructure/repositories/organization-for-admin.repository.js';
 import * as schoolRepository from '../../../../src/school/infrastructure/repositories/school-repository.js';
+import { ORGANIZATION_FEATURE } from '../../../../src/shared/domain/constants.js';
 import { databaseBuilder, expect } from '../../../test-helper.js';
 
 describe('Integration | UseCases | create-organization', function () {
   it('returns newly created organization', async function () {
     // given
     const superAdminUserId = databaseBuilder.factory.buildUser().id;
+    databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT);
     await databaseBuilder.commit();
 
     const organization = new OrganizationForAdmin({
@@ -37,5 +39,6 @@ describe('Integration | UseCases | create-organization', function () {
     expect(createdOrganization.dataProtectionOfficer.firstName).to.equal('');
     expect(createdOrganization.dataProtectionOfficer.lastName).to.equal('');
     expect(createdOrganization.dataProtectionOfficer.email).to.equal('');
+    expect(createdOrganization.features[ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT.key].active).to.be.true;
   });
 });

api/tests/integration/domain/usecases/create-organizations-with-tags-and-target-profiles_test.js

@@ -24,10 +24,18 @@ import { catchErr, databaseBuilder, expect, knex } from '../../../test-helper.js
 const { omit } = lodash;
 
 describe('Integration | UseCases | create-organizations-with-tags-and-target-profiles', function () {
-  let missionFeature, oralizationFeature, importStudentsFeature, ondeImportFormat, userId;
+  let missionFeature,
+    oralizationFeature,
+    importStudentsFeature,
+    multipleSendingAssessmentFeature,
+    ondeImportFormat,
+    userId;
 
   beforeEach(async function () {
     databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.COMPUTE_ORGANIZATION_LEARNER_CERTIFICABILITY);
+    multipleSendingAssessmentFeature = databaseBuilder.factory.buildFeature(
+      ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT,
+    );
     missionFeature = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MISSIONS_MANAGEMENT);
     oralizationFeature = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.ORALIZATION_MANAGED_BY_PRESCRIBER);
     importStudentsFeature = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.LEARNER_IMPORT);
@@ -702,7 +710,7 @@ describe('Integration | UseCases | create-organizations-with-tags-and-target-pro
   });
 
   describe('when organization type is SCO-1D', function () {
-    it('should add mission management, oralization and ONDE import features to organization', async function () {
+    it('should add mission management, oralization, ONDE import features and multiple sending assessment to organization', async function () {
       // given
       databaseBuilder.factory.buildTag({ name: 'TAG1' });
       await databaseBuilder.commit();
@@ -740,7 +748,7 @@ describe('Integration | UseCases | create-organizations-with-tags-and-target-pro
 
       // then
       const savedOrganizationFeatures = await knex('organization-features');
-      expect(savedOrganizationFeatures).to.have.lengthOf(3);
+      expect(savedOrganizationFeatures).to.have.lengthOf(4);
       const organizationId = createdOrganizations[0].id;
       expect(
         savedOrganizationFeatures.map((organizationFeature) => omit(organizationFeature, 'id')),
@@ -760,6 +768,11 @@ describe('Integration | UseCases | create-organizations-with-tags-and-target-pro
           params: { organizationLearnerImportFormatId: ondeImportFormat.id },
           organizationId,
         },
+        {
+          featureId: multipleSendingAssessmentFeature.id,
+          params: null,
+          organizationId,
+        },
       ]);
     });
 

api/tests/organizational-entities/acceptance/application/organization/organization.admin.route.test.js

@@ -19,6 +19,7 @@ describe('Acceptance | Organizational Entities | Application | Route | Admin | O
 
   beforeEach(async function () {
     admin = await insertUserWithRoleSuperAdmin();
+    databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT);
     await databaseBuilder.commit();
 
     server = await createServer();
@@ -65,7 +66,6 @@ describe('Acceptance | Organizational Entities | Application | Route | Admin | O
         });
         const tag = databaseBuilder.factory.buildTag({ id: 7, name: 'AEFE' });
         databaseBuilder.factory.buildOrganizationTag({ tagId: tag.id, organizationId: organization.id });
-        databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT);
         await databaseBuilder.commit();
 
         // when
@@ -218,6 +218,7 @@ describe('Acceptance | Organizational Entities | Application | Route | Admin | O
       };
 
       const organization = databaseBuilder.factory.buildOrganization({ ...organizationAttributes });
+
       await databaseBuilder.commit();
 
       const payload = {
@@ -326,6 +327,7 @@ describe('Acceptance | Organizational Entities | Application | Route | Admin | O
       let secondChildOrganization;
 
       beforeEach(async function () {
+        databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.PLACES_MANAGEMENT).id;
         parentOrganizationId = databaseBuilder.factory.buildOrganization({
           name: 'Parent Organization',
           type: 'SCO',

api/tests/organizational-entities/integration/infrastructure/repositories/organization-for-admin.repository.test.js

@@ -8,11 +8,12 @@ import { OrganizationInvitation } from '../../../../../src/team/domain/models/Or
 import { catchErr, databaseBuilder, domainBuilder, expect, knex, sinon } from '../../../../test-helper.js';
 
 describe('Integration | Organizational Entities | Infrastructure | Repository | organization-for-admin', function () {
-  let clock;
+  let clock, isMultipleSendingFeature;
   const now = new Date('2022-02-02');
 
   beforeEach(function () {
     clock = sinon.useFakeTimers({ now, toFake: ['Date'] });
+    isMultipleSendingFeature = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT);
   });
 
   afterEach(function () {
@@ -296,6 +297,11 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         featureId,
         params: { organizationLearnerImportFormatId },
       });
+      databaseBuilder.factory.buildOrganizationFeature({
+        organizationId: organization.id,
+        featureId: isMultipleSendingFeature.id,
+        params: null,
+      });
 
       await databaseBuilder.commit();
 
@@ -335,6 +341,7 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         features: {
           [ORGANIZATION_FEATURE.COMPUTE_ORGANIZATION_LEARNER_CERTIFICABILITY.key]: { active: false },
           [ORGANIZATION_FEATURE.LEARNER_IMPORT.key]: { active: true, params: { name: 'BIDON' } },
+          [ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT.key]: { active: true, params: null },
         },
         parentOrganizationId: parentOrganization.id,
         parentOrganizationName: 'Mother Of Dark Side',
@@ -387,7 +394,11 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         databaseBuilder.factory.buildOrganizationLearnerImportFormat({
           name: 'BIDON',
         }).id;
-
+        databaseBuilder.factory.buildOrganizationFeature({
+          organizationId: organization.id,
+          featureId: isMultipleSendingFeature.id,
+          params: null,
+        });
         await databaseBuilder.commit();
 
         // when
@@ -425,6 +436,7 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
           identityProviderForCampaigns: 'genericOidcProviderCode',
           features: {
             [ORGANIZATION_FEATURE.LEARNER_IMPORT.key]: { active: false, params: null },
+            [ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT.key]: { active: true, params: null },
           },
           parentOrganizationId: null,
           parentOrganizationName: null,
@@ -485,7 +497,6 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
           archivedBy: archivist.id,
           archivedAt,
         });
-        databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT);
 
         await databaseBuilder.commit();
 
@@ -556,7 +567,7 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
     });
 
     context('when the organization type is SCO-1D', function () {
-      it('adds mission_management, oralization and learner_import features to the organization', async function () {
+      it('adds mission_management, oralization, learner_import and multiple sending assessment features to the organization', async function () {
         const superAdminUserId = databaseBuilder.factory.buildUser().id;
         const missionManagementFeatureId = databaseBuilder.factory.buildFeature(
           ORGANIZATION_FEATURE.MISSIONS_MANAGEMENT,
@@ -583,7 +594,7 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
           organizationId: savedOrganization.id,
         });
 
-        expect(savedOrganizationFeatures).to.have.lengthOf(3);
+        expect(savedOrganizationFeatures).to.have.lengthOf(4);
         const savedOrganizationFeatureIds = savedOrganizationFeatures.map(
           (organizationFeature) => organizationFeature.featureId,
         );
@@ -628,7 +639,7 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         createdBy: userId,
       });
 
-      const featureId = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT).id;
+      const featureId = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.PLACES_MANAGEMENT).id;
       await databaseBuilder.commit();
 
       // when
@@ -637,14 +648,14 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         documentationUrl: 'https://pix.fr/',
         features: {
           [ORGANIZATION_FEATURE.LEARNER_IMPORT.key]: { active: false },
-          [ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT.key]: { active: true },
+          [ORGANIZATION_FEATURE.PLACES_MANAGEMENT.key]: { active: true },
         },
       });
       await organizationForAdminRepository.update(organizationToUpdate);
 
       // then
       const enabledFeatures = await knex('organization-features').where({ organizationId: organization.id });
-      expect(enabledFeatures).to.have.lengthOf(1);
+      expect(enabledFeatures).to.have.lengthOf(2);
       expect(enabledFeatures[0].featureId).to.equal(featureId);
     });
 
@@ -656,7 +667,7 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         createdBy: userId,
       });
 
-      const featureId = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT).id;
+      const featureId = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.PLACES_MANAGEMENT).id;
       databaseBuilder.factory.buildOrganizationFeature({ organizationId: organization.id, featureId });
       await databaseBuilder.commit();
 
@@ -665,15 +676,16 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         id: organization.id,
         documentationUrl: 'https://pix.fr/',
         features: {
-          [ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT.key]: { active: true },
+          [ORGANIZATION_FEATURE.PLACES_MANAGEMENT.key]: { active: true },
+          [ORGANIZATION_FEATURE.PLACES_MANAGEMENT.key]: { active: true },
         },
       });
 
       await organizationForAdminRepository.update(organizationToUpdate);
 
       // then
       const enabledFeatures = await knex('organization-features').where({ organizationId: organization.id });
-      expect(enabledFeatures).to.have.lengthOf(1);
+      expect(enabledFeatures).to.have.lengthOf(2);
       expect(enabledFeatures[0].featureId).to.equal(featureId);
     });
 
@@ -690,9 +702,14 @@ describe('Integration | Organizational Entities | Infrastructure | Repository |
         createdBy: userId,
       });
 
-      const featureId = databaseBuilder.factory.buildFeature(ORGANIZATION_FEATURE.MULTIPLE_SENDING_ASSESSMENT).id;
-      databaseBuilder.factory.buildOrganizationFeature({ organizationId: organization.id, featureId });
-      databaseBuilder.factory.buildOrganizationFeature({ organizationId: otherOrganization.id, featureId });
+      databaseBuilder.factory.buildOrganizationFeature({
+        organizationId: organization.id,
+        featureId: isMultipleSendingFeature.id,
+      });
+      databaseBuilder.factory.buildOrganizationFeature({
+        organizationId: otherOrganization.id,
+        featureId: isMultipleSendingFeature.id,
+      });
 
       await databaseBuilder.commit();