feat(api): rewrite scripts generate ke snapshot using campaignParticipationId

Co-authored-by: Théotime Berthod <theotime.berthod@pix.fr>

Author: xav-car

api/scripts/prod/generate-knowledge-element-snapshots-for-campaigns.js

@@ -46,21 +46,17 @@ function _validateAndNormalizeArgs({ concurrency, maxSnapshotCount }) {
 
 async function getEligibleCampaignParticipations(maxSnapshotCount) {
   return knex('campaign-participations')
-    .select('campaign-participations.userId', 'campaign-participations.sharedAt', 'campaign-participations.id')
-    .leftJoin('knowledge-element-snapshots', function () {
-      this.on('knowledge-element-snapshots.userId', 'campaign-participations.userId').andOn(
-        'knowledge-element-snapshots.snappedAt',
-        'campaign-participations.sharedAt',
-      );
-    })
+    .select('campaign-participations.id', 'campaign-participations.userId', 'campaign-participations.sharedAt')
+    .leftJoin(
+      'knowledge-element-snapshots',
+      'knowledge-element-snapshots.campaignParticipationId',
+      'campaign-participations.id',
+    )
     .whereNotNull('campaign-participations.sharedAt')
     .where((qb) => {
-      qb.whereNull('knowledge-element-snapshots.snappedAt').orWhereRaw('?? != ??', [
-        'campaign-participations.sharedAt',
-        'knowledge-element-snapshots.snappedAt',
-      ]);
+      qb.whereNull('knowledge-element-snapshots.campaignParticipationId');
     })
-    .orderBy('campaign-participations.userId')
+    .orderBy('campaign-participations.id')
     .limit(maxSnapshotCount);
 }
 
@@ -79,8 +75,6 @@ async function generateKnowledgeElementSnapshots(
       });
       try {
         await dependencies.knowledgeElementSnapshotRepository.save({
-          userId,
-          snappedAt: sharedAt,
           snapshot: new KnowledgeElementCollection(knowledgeElements).toSnapshot(),
           campaignParticipationId: id,
         });

api/tests/integration/scripts/prod/generate-knowledge-element-snapshots-for-campaigns_test.js

@@ -31,7 +31,9 @@ describe('Integration | Scripts | generate-knowledge-element-snapshots-for-campa
         sharedAt: new Date('2020-01-01'),
         userId,
       });
-      databaseBuilder.factory.buildKnowledgeElementSnapshot({ snappedAt: campaignParticipation.sharedAt, userId });
+      databaseBuilder.factory.buildKnowledgeElementSnapshot({
+        campaignParticipationId: campaignParticipation.id,
+      });
       await databaseBuilder.commit();
 
       // when
@@ -71,10 +73,23 @@ describe('Integration | Scripts | generate-knowledge-element-snapshots-for-campa
         sharedAt: new Date('2020-01-01'),
         userId,
       });
-      databaseBuilder.factory.buildCampaignParticipation({ sharedAt: new Date('2020-02-01'), userId });
-      databaseBuilder.factory.buildCampaignParticipation({ sharedAt: new Date('2020-03-01'), userId });
-      databaseBuilder.factory.buildKnowledgeElementSnapshot({ snappedAt: new Date('2020-02-01'), userId });
-      databaseBuilder.factory.buildKnowledgeElementSnapshot({ snappedAt: new Date('2020-03-01'), userId });
+
+      const firstCampaignParticiationId = databaseBuilder.factory.buildCampaignParticipation({
+        sharedAt: new Date('2020-02-01'),
+        userId,
+      }).id;
+      const secondCampaignParticiationId = databaseBuilder.factory.buildCampaignParticipation({
+        sharedAt: new Date('2020-03-01'),
+        userId,
+      }).id;
+      databaseBuilder.factory.buildKnowledgeElementSnapshot({
+        snappedAt: new Date('2020-02-01'),
+        campaignParticipationId: firstCampaignParticiationId,
+      });
+      databaseBuilder.factory.buildKnowledgeElementSnapshot({
+        snappedAt: new Date('2020-03-01'),
+        campaignParticipationId: secondCampaignParticiationId,
+      });
       await databaseBuilder.commit();
 
       // when
@@ -152,8 +167,6 @@ describe('Integration | Scripts | generate-knowledge-element-snapshots-for-campa
 
       // then
       expect(knowledgeElementSnapshotRepositoryStub.save).to.have.been.calledWithExactly({
-        userId: campaignParticipationData[0].userId,
-        snappedAt: campaignParticipationData[0].sharedAt,
         snapshot: new KnowledgeElementCollection(expectedKnowledgeElements).toSnapshot(),
         campaignParticipationId: campaignParticipationData[0].id,
       });