♻️ chore(api) rename controller functions to certificate

Author: yaf

api/src/certification/results/application/certificate-controller.js

@@ -39,7 +39,7 @@ const findUserCertificates = async function (request) {
   return privateCertificateSerializer.serialize(privateCertificates, { translate });
 };
 
-const getPDFAttestation = async function (
+const getPDFCertificate = async function (
   request,
   h,
   dependencies = { certificationAttestationPdf, v3CertificationAttestationPdf },
@@ -83,7 +83,7 @@ const getPDFAttestation = async function (
     .header('Content-Type', 'application/pdf');
 };
 
-const getCertificationPDFAttestationsForSession = async function (
+const getSessionCertificates = async function (
   request,
   h,
   dependencies = { certificationAttestationPdf, v3CertificationAttestationPdf },
@@ -126,7 +126,7 @@ const getCertificationPDFAttestationsForSession = async function (
     .header('Content-Type', 'application/pdf');
 };
 
-const downloadCertificationAttestationsForDivision = async function (
+const downloadDivisionCertificates = async function (
   request,
   h,
   dependencies = { certificationAttestationPdf, v3CertificationAttestationPdf },
@@ -178,9 +178,9 @@ const certificateController = {
   getCertificate,
   findUserCertificates,
   getCertificateByVerificationCode,
-  getPDFAttestation,
-  getCertificationPDFAttestationsForSession,
-  downloadCertificationAttestationsForDivision,
+  getPDFCertificate,
+  getSessionCertificates,
+  downloadDivisionCertificates,
 };
 
 export { certificateController };

api/src/certification/results/application/certificate-route.js

@@ -22,7 +22,7 @@ const register = async function (server) {
             lang: Joi.string().valid(FRENCH_SPOKEN, ENGLISH_SPOKEN),
           }),
         },
-        handler: certificateController.getPDFAttestation,
+        handler: certificateController.getPDFCertificate,
         notes: [
           '- **Route accessible par un user authentifié**\n' +
             '- Récupération des informations d’un certificat au format PDF' +
@@ -79,15 +79,15 @@ const register = async function (server) {
             assign: 'hasAuthorizationToAccessAdminScope',
           },
         ],
-        handler: certificateController.getCertificationPDFAttestationsForSession,
+        handler: certificateController.getSessionCertificates,
         plugins: {
           'hapi-swagger': {
             produces: ['application/pdf'],
           },
         },
         notes: [
           '- **Route accessible par un user Admin**\n' +
-            "- Récupération des attestations de certification d'une session au format PDF" +
+            "- Récupération les certificats d'une session au format PDF" +
             ' via un id de session et un user id',
         ],
         tags: ['api', 'certifications', 'PDF'],

api/tests/certification/results/unit/application/certificate-controller_test.js

@@ -203,7 +203,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
     });
   });
 
-  describe('#getPDFAttestation', function () {
+  describe('#getPDFCertificate', function () {
     describe('when the attestation is for v3', function () {
       it('should return attestation in PDF binary format', async function () {
         // given
@@ -232,7 +232,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
         };
 
         // when
-        const response = await certificateController.getPDFAttestation(request, hFake, {
+        const response = await certificateController.getPDFCertificate(request, hFake, {
           v3CertificationAttestationPdf: generatePdfStub,
         });
 
@@ -281,7 +281,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
           .resolves({ buffer: attestationPDF, fileName: filename });
 
         // when
-        const response = await certificateController.getPDFAttestation(request, hFake, {
+        const response = await certificateController.getPDFCertificate(request, hFake, {
           certificationAttestationPdf: certificationAttestationPdfStub,
         });
 
@@ -292,7 +292,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
     });
   });
 
-  describe('#getCertificationPDFAttestationsForSession', function () {
+  describe('#getSessionCertificates', function () {
     describe('when attestations are for a v3 session', function () {
       it('should return attestation in PDF binary format', async function () {
         // given
@@ -322,7 +322,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
         };
 
         // when
-        const response = await certificateController.getCertificationPDFAttestationsForSession(request, hFake, {
+        const response = await certificateController.getSessionCertificates(request, hFake, {
           v3CertificationAttestationPdf: generatePdfStub,
         });
 
@@ -393,7 +393,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
           .resolves({ buffer: attestationPDF });
 
         // when
-        const response = await certificateController.getCertificationPDFAttestationsForSession(request, hFake, {
+        const response = await certificateController.getSessionCertificates(request, hFake, {
           certificationAttestationPdf,
         });
 
@@ -406,7 +406,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
     });
   });
 
-  describe('#downloadCertificationAttestationsForDivision', function () {
+  describe('#downloadDivisionCertificates', function () {
     const now = new Date('2019-01-01T05:06:07Z');
     let clock;
 
@@ -450,7 +450,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
         };
 
         // when
-        const response = await certificateController.downloadCertificationAttestationsForDivision(request, hFake, {
+        const response = await certificateController.downloadDivisionCertificates(request, hFake, {
           v3CertificationAttestationPdf: generatePdfStub,
         });
 
@@ -508,11 +508,7 @@ describe('Certification | Results | Unit | Application | certificate-controller'
           .resolves({ buffer: attestationsPDF });
 
         // when
-        const response = await certificateController.downloadCertificationAttestationsForDivision(
-          request,
-          hFake,
-          dependencies,
-        );
+        const response = await certificateController.downloadDivisionCertificates(request, hFake, dependencies);
 
         // then
         expect(response.source).to.deep.equal(attestationsPDF);

api/tests/certification/results/unit/application/certificate-route_test.js

@@ -9,14 +9,14 @@ describe('Certification | Results | Unit | Application | Certification Route', f
   beforeEach(async function () {
     sinon.stub(certificateController, 'findUserCertificates').returns('ok');
     sinon.stub(certificateController, 'getCertificate').callsFake((request, h) => h.response('ok').code(200));
-    sinon.stub(securityPreHandlers, 'hasAtLeastOneAccessOf').returns(() => true);
 
     httpTestServer = new HttpTestServer();
     await httpTestServer.register(moduleUnderTest);
   });
 
   describe('GET /api/certifications/{certificationCourseId}', function () {
     it('should exist', async function () {
+      sinon.stub(securityPreHandlers, 'hasAtLeastOneAccessOf').returns(() => true);
       // when
       const response = await httpTestServer.request('GET', '/api/certifications/1');
 
@@ -27,6 +27,7 @@ describe('Certification | Results | Unit | Application | Certification Route', f
 
   describe('GET /api/certifications', function () {
     it('should exist', async function () {
+      sinon.stub(securityPreHandlers, 'hasAtLeastOneAccessOf').returns(() => true);
       // when
       const response = await httpTestServer.request('GET', '/api/certifications');