refactor(api): remove unused options param from getPossibleNextChallenges

Author: alexandrecoin

api/src/certification/flash-certification/domain/models/FlashAssessmentAlgorithm.js

@@ -57,10 +57,6 @@ class FlashAssessmentAlgorithm {
     return this.flashAlgorithmImplementation.getPossibleNextChallenges({
       availableChallenges: challengesAfterRulesApplication,
       capacity,
-      options: {
-        challengesBetweenSameCompetence: this._configuration.challengesBetweenSameCompetence,
-        minimalSuccessRate: 0,
-      },
     });
   }
 

api/src/certification/flash-certification/domain/services/algorithm-methods/flash.js

@@ -24,11 +24,7 @@ export {
   getReward,
 };
 
-function getPossibleNextChallenges({
-  availableChallenges,
-  capacity = DEFAULT_CAPACITY,
-  options: { minimalSuccessRate = 0 } = {},
-} = {}) {
+function getPossibleNextChallenges({ availableChallenges, capacity = DEFAULT_CAPACITY } = {}) {
   const challengesWithReward = availableChallenges.map((challenge) => {
     return {
       challenge,
@@ -40,7 +36,7 @@ function getPossibleNextChallenges({
     };
   });
 
-  return _findBestPossibleChallenges(challengesWithReward, minimalSuccessRate, capacity);
+  return _findBestPossibleChallenges(challengesWithReward, capacity);
 }
 
 function getCapacityAndErrorRate({ allAnswers, challenges, capacity = DEFAULT_CAPACITY, variationPercent }) {
@@ -177,11 +173,12 @@ function _limitCapacityVariation(previousCapacity, nextCapacity, variationPercen
     : Math.max(nextCapacity, previousCapacity - gap);
 }
 
-function _findBestPossibleChallenges(challengesWithReward, minimumSuccessRate, capacity) {
+function _findBestPossibleChallenges(challengesWithReward, capacity) {
   const hasMinimumSuccessRate = ({ challenge }) => {
+    const MINIMUM_SUCCESS_RATE = 0;
     const successProbability = _getProbability(capacity, challenge.discriminant, challenge.difficulty);
 
-    return successProbability >= minimumSuccessRate;
+    return successProbability >= MINIMUM_SUCCESS_RATE;
   };
 
   const orderedChallengesWithReward = orderBy(

api/tests/certification/evaluation/unit/domain/usecases/get-next-challenge_test.js

@@ -110,7 +110,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge', function () {
           .withArgs({
             availableChallenges: [nextChallengeToAnswer],
             capacity: 0,
-            options: sinon.match.any,
           })
           .returns([nextChallengeToAnswer]);
 
@@ -200,7 +199,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge', function () {
             .withArgs({
               availableChallenges: [nextChallengeToAnswer, accessibleChallenge],
               capacity: 0,
-              options: sinon.match.any,
             })
             .returns([nextChallengeToAnswer]);
 
@@ -358,7 +356,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge', function () {
           .withArgs({
             availableChallenges: [nextChallengeToAnswer],
             capacity: 0,
-            options: sinon.match.any,
           })
           .returns([nextChallengeToAnswer]);
 
@@ -440,7 +437,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge', function () {
           .withArgs({
             availableChallenges: [nextChallenge],
             capacity: 0,
-            options: sinon.match.any,
           })
           .returns([nextChallenge]);
 
@@ -541,7 +537,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge', function () {
           .withArgs({
             availableChallenges: [challengeWithOtherSkill],
             capacity: 0,
-            options: sinon.match.any,
           })
           .returns([challengeWithOtherSkill]);
 
@@ -709,7 +704,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge', function () {
               .withArgs({
                 availableChallenges: [nextChallengeToAnswer],
                 capacity: 0,
-                options: sinon.match.any,
               })
               .returns([nextChallengeToAnswer]);
 

api/tests/certification/shared/unit/domain/models/FlashAssessmentAlgorithm_test.js

@@ -11,11 +11,6 @@ const baseFlashAssessmentAlgorithmConfig = {
 describe('Unit | Domain | Models | FlashAssessmentAlgorithm | FlashAssessmentAlgorithm', function () {
   let flashAlgorithmImplementation;
 
-  const baseGetNextChallengeOptions = {
-    challengesBetweenSameCompetence: 2,
-    minimalSuccessRate: 0,
-  };
-
   beforeEach(function () {
     flashAlgorithmImplementation = {
       getPossibleNextChallenges: sinon.stub(),
@@ -156,7 +151,6 @@ describe('Unit | Domain | Models | FlashAssessmentAlgorithm | FlashAssessmentAlg
             .withArgs({
               availableChallenges: expectedChallenges,
               capacity: computedCapacity,
-              options: baseGetNextChallengeOptions,
             })
             .returns(expectedChallenges);
 
@@ -233,7 +227,6 @@ describe('Unit | Domain | Models | FlashAssessmentAlgorithm | FlashAssessmentAlg
             .withArgs({
               availableChallenges: expectedChallenges,
               capacity: computedCapacity,
-              options: baseGetNextChallengeOptions,
             })
             .returns(expectedChallenges);
 

api/tests/unit/domain/usecases/get-next-challenge-for-campaign-assessment_test.js

@@ -162,7 +162,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge-for-campaign-assessment
             .withArgs({
               availableChallenges: [secondChallenge],
               capacity: 0,
-              options: sinon.match.object,
             })
             .returns([secondChallenge]);
 
@@ -273,7 +272,6 @@ describe('Unit | Domain | Use Cases | get-next-challenge-for-campaign-assessment
             .withArgs({
               challenges,
               capacity: 0,
-              options: sinon.match.object,
             })
             .returns({
               hasAssessmentEnded: false,