feat(api): Clean userId and snappedAt on factory build-knowledge-element-snapshots

Co-Authored-By: alicegoarnisson <187311468+alicegoarnisson@users.noreply.github.com>
Co-Authored-By: Xavier Carron <33637571+xav-car@users.noreply.github.com>

Author: 3 people

api/db/database-builder/factory/build-knowledge-element-snapshot.js

@@ -1,19 +1,12 @@
-import _ from 'lodash';
-
 import { KnowledgeElementCollection } from '../../../src/prescription/shared/domain/models/KnowledgeElementCollection.js';
 import { databaseBuffer } from '../database-buffer.js';
 import { buildKnowledgeElement } from './build-knowledge-element.js';
-import { buildUser } from './build-user.js';
 
 const buildKnowledgeElementSnapshot = function ({
   id = databaseBuffer.getNextId(),
-  userId,
-  snappedAt = new Date('2020-01-01'),
   snapshot,
   campaignParticipationId,
 } = {}) {
-  const dateMinusOneDay = new Date(snappedAt.getTime() - 1000 * 60 * 60 * 24 * 7);
-  userId = _.isUndefined(userId) ? buildUser().id : userId;
   if (!snapshot) {
     const knowledgeElements = [];
     knowledgeElements.push(buildKnowledgeElement({ userId, createdAt: dateMinusOneDay }));
@@ -23,8 +16,6 @@ const buildKnowledgeElementSnapshot = function ({
 
   const values = {
     id,
-    userId,
-    snappedAt,
     snapshot,
     campaignParticipationId,
   };

api/db/seeds/data/common/tooling/campaign-tooling.js

@@ -238,8 +238,6 @@ async function createAssessmentCampaign({
 
       if (isShared) {
         databaseBuilder.factory.buildKnowledgeElementSnapshot({
-          userId,
-          snappedAt: sharedAt,
           snapshot: new KnowledgeElementCollection(keDataForSnapshot).toSnapshot(),
           campaignParticipationId,
         });
@@ -402,8 +400,6 @@ async function createProfilesCollectionCampaign({
         );
       }
       databaseBuilder.factory.buildKnowledgeElementSnapshot({
-        userId,
-        snappedAt: sharedAt,
         snapshot: new KnowledgeElementCollection(keDataForSnapshot).toSnapshot(),
         campaignParticipationId,
       });

api/tests/prescription/campaign/acceptance/application/campaign-results-route_test.js

@@ -576,10 +576,8 @@ describe('Acceptance | API | campaign-results-route', function () {
       });
 
       databaseBuilder.factory.buildKnowledgeElementSnapshot({
-        userId,
         campaignParticipationId: campaignParticipation.id,
         snapshot: new KnowledgeElementCollection([ke]).toSnapshot(),
-        snappedAt: campaignParticipation.sharedAt,
       });
 
       await databaseBuilder.commit();

api/tests/shared/integration/domain/services/placement-profile-service_test.js

@@ -524,8 +524,6 @@ describe('Shared | Integration | Domain | Services | Placement Profile Service',
         });
 
         databaseBuilder.factory.buildKnowledgeElementSnapshot({
-          userId: userId,
-          snappedAt: sharedAt,
           campaignParticipationId: campaignParticipation.id,
           snapshot: new KnowledgeElementCollection([ke]).toSnapshot(),
         });
@@ -575,8 +573,6 @@ describe('Shared | Integration | Domain | Services | Placement Profile Service',
         });
 
         databaseBuilder.factory.buildKnowledgeElementSnapshot({
-          userId: userId,
-          snappedAt: sharedAt,
           campaignParticipationId: campaignParticipation.id,
           snapshot: new KnowledgeElementCollection([ke1, ke2]).toSnapshot(),
         });
@@ -604,8 +600,6 @@ describe('Shared | Integration | Domain | Services | Placement Profile Service',
 
           databaseBuilder.factory.buildKnowledgeElementSnapshot({
             campaignParticipationId: campaignParticipation.id,
-            userId: userId,
-            snappedAt: campaignParticipation.sharedAt,
             snapshot: new KnowledgeElementCollection([ke]).toSnapshot(),
           });
 
@@ -639,8 +633,6 @@ describe('Shared | Integration | Domain | Services | Placement Profile Service',
 
           databaseBuilder.factory.buildKnowledgeElementSnapshot({
             campaignParticipationId: campaignParticipation.id,
-            userId: userId,
-            snappedAt: campaignParticipation.sharedAt,
             snapshot: new KnowledgeElementCollection([ke]).toSnapshot(),
           });
 

api/tests/shared/integration/infrastructure/repositories/knowledge-element-repository_test.js

@@ -196,8 +196,6 @@ describe('Integration | Repository | knowledgeElementRepository', function () {
             });
             const knowledgeElementsBefore = new KnowledgeElementCollection([knowledgeElement1, knowledgeElement2]);
             databaseBuilder.factory.buildKnowledgeElementSnapshot({
-              userId,
-              snappedAt: new Date('2019-01-01'),
               campaignParticipationId,
               snapshot: knowledgeElementsBefore.toSnapshot(),
             });