feat(api): filter v3 attestations in downloadCertificationAttestationsForDivision

Author: Jeyffrey

api/src/certification/results/application/certificate-controller.js

@@ -140,7 +140,9 @@ const downloadDivisionCertificates = async function (
     division,
   });
 
-  if (certificates.every((certificate) => certificate instanceof V3CertificationAttestation)) {
+  if (certificates.some((certificate) => certificate instanceof V3CertificationAttestation)) {
+    const v3Certificates = certificates.filter((certificate) => certificate instanceof V3CertificationAttestation);
+
     const normalizedDivision = normalizeAndRemoveAccents(division);
 
     const translatedFileName = i18n.__('certification-confirmation.file-name', {
@@ -150,7 +152,7 @@ const downloadDivisionCertificates = async function (
     return h
       .response(
         dependencies.v3CertificationAttestationPdf.generate({
-          certificates,
+          certificates: v3Certificates,
           i18n,
         }),
       )

api/tests/certification/results/unit/application/certificate-controller_test.js

@@ -418,8 +418,8 @@ describe('Certification | Results | Unit | Application | certificate-controller'
       clock.restore();
     });
 
-    describe('when attestations are for v3', function () {
-      it('should return division attestations in PDF binary format', async function () {
+    describe('when there are at least one v3 attestation', function () {
+      it('should return only v3 division attestations in PDF binary format', async function () {
         // given
         const userId = 1;
         const i18n = getI18n();