♻️ chore(api) rename V3CertificationAttestation object

Author: yaf

Diff for: api/src/certification/results/application/certification-controller.js

@@ -2,7 +2,7 @@ import dayjs from 'dayjs';
 
 import * as requestResponseUtils from '../../../../src/shared/infrastructure/utils/request-response-utils.js';
 import { normalizeAndRemoveAccents } from '../../../shared/infrastructure/utils/string-utils.js';
-import { V3CertificationAttestation } from '../domain/models/V3CertificationAttestation.js';
+import { V3Certification } from '../domain/models/V3Certification.js';
 import { usecases } from '../domain/usecases/index.js';
 import * as privateCertificateSerializer from '../infrastructure/serializers/private-certificate-serializer.js';
 import * as shareableCertificateSerializer from '../infrastructure/serializers/shareable-certificate-serializer.js';
@@ -54,7 +54,7 @@ const getPDFAttestation = async function (
     certificationCourseId,
   });
 
-  if (certification instanceof V3CertificationAttestation) {
+  if (certification instanceof V3Certification) {
     const fileName = i18n.__('certification-confirmation.file-name', {
       deliveredAt: dayjs(certification.deliveredAt).format('YYYYMMDD'),
     });
@@ -96,7 +96,7 @@ const getCertificationPDFAttestationsForSession = async function (
     sessionId,
   });
 
-  if (certifications.every((certification) => certification instanceof V3CertificationAttestation)) {
+  if (certifications.every((certification) => certification instanceof V3Certification)) {
     const translatedFileName = i18n.__('certification-confirmation.file-name', {
       deliveredAt: dayjs(certifications[0].deliveredAt).format('YYYYMMDD'),
     });
@@ -140,7 +140,7 @@ const downloadCertificationAttestationsForDivision = async function (
     division,
   });
 
-  if (certifications.every((certification) => certification instanceof V3CertificationAttestation)) {
+  if (certifications.every((certification) => certification instanceof V3Certification)) {
     const normalizedDivision = normalizeAndRemoveAccents(division);
 
     const translatedFileName = i18n.__('certification-confirmation.file-name', {

Diff for: api/src/certification/results/domain/models/V3CertificationAttestation.js renamed to api/src/certification/results/domain/models/V3Certification.js

@@ -12,7 +12,7 @@ import {
 import { featureToggles } from '../../../../shared/infrastructure/feature-toggles/index.js';
 import { SessionVersion } from '../../../shared/domain/models/SessionVersion.js';
 import { CertificationAttestation } from '../../domain/models/CertificationAttestation.js';
-import { V3CertificationAttestation } from '../../domain/models/V3CertificationAttestation.js';
+import { V3Certification } from '../../domain/models/V3Certification.js';
 import { CertifiedBadge } from '../../domain/read-models/CertifiedBadge.js';
 import * as competenceTreeRepository from './competence-tree-repository.js';
 
@@ -271,7 +271,7 @@ async function _toDomainForCertificationAttestation({ certificationCourseDTO, co
     SessionVersion.isV3(certificationCourseDTO.version) &&
     (await featureToggles.get('isV3CertificationAttestationEnabled'))
   ) {
-    return new V3CertificationAttestation({
+    return new V3Certification({
       ...certificationCourseDTO,
     });
   }

Diff for: api/src/certification/results/infrastructure/repositories/certificate-repository.js

@@ -1,5 +1,5 @@
 /**
- * @typedef {import ('../../../../domain/models/V3CertificationAttestation.js').V3CertificationAttestation} V3CertificationAttestation
+ * @typedef {import ('../../../../domain/models/V3Certification.js').V3Certification} V3Certification
  */
 import path from 'node:path';
 import * as url from 'node:url';

Diff for: api/src/certification/results/infrastructure/utils/pdf/templates/v3-attestation.js

@@ -1,5 +1,5 @@
 /**
- * @typedef {import ('../../../domain/models/V3CertificationAttestation.js').V3CertificationAttestation} V3CertificationAttestation
+ * @typedef {import ('../../../domain/models/V3Certification.js').V3Certification} V3Certification
  */
 import PDFDocument from 'pdfkit';
 

Diff for: api/src/certification/results/infrastructure/utils/pdf/v3-certification-attestation-pdf.js

@@ -1,6 +1,6 @@
-import { V3CertificationAttestation } from '../../../../src/certification/results/domain/models/V3CertificationAttestation.js';
+import { V3Certification } from '../../../../src/certification/results/domain/models/V3Certification.js';
 
-const buildV3CertificationAttestation = async function ({
+const buildV3Certification = async function ({
   id = 1,
   firstName = 'Jean',
   lastName = 'Bon',
@@ -12,7 +12,7 @@ const buildV3CertificationAttestation = async function ({
   maxReachableLevelOnCertificationDate = 5,
   verificationCode = 'P-SOMECODE',
 } = {}) {
-  return new V3CertificationAttestation({
+  return new V3Certification({
     id,
     firstName,
     lastName,
@@ -26,4 +26,4 @@ const buildV3CertificationAttestation = async function ({
   });
 };
 
-export { buildV3CertificationAttestation };
+export { buildV3Certification };

Diff for: api/tests/tooling/domain-builder/factory/build-v3-certification-attestation.js renamed to api/tests/tooling/domain-builder/factory/build-v3-certification.js

@@ -1,6 +1,6 @@
-import { V3CertificationAttestation } from '../../../../../../src/certification/results/domain/models/V3CertificationAttestation.js';
+import { V3Certification } from '../../../../../../src/certification/results/domain/models/V3Certification.js';
 
-const buildV3CertificationAttestation = function ({
+const buildV3Certification = function ({
   id = 1,
   firstName = 'Jean',
   lastName = 'Bon',
@@ -12,7 +12,7 @@ const buildV3CertificationAttestation = function ({
   maxReachableLevelOnCertificationDate = 7,
   verificationCode = 'P-SOMECODE',
 } = {}) {
-  return new V3CertificationAttestation({
+  return new V3Certification({
     id,
     firstName,
     lastName,
@@ -26,4 +26,4 @@ const buildV3CertificationAttestation = function ({
   });
 };
 
-export { buildV3CertificationAttestation };
+export { buildV3Certification };

Diff for: api/tests/tooling/domain-builder/factory/certification/results/build-v3-certification-attestation.js renamed to api/tests/tooling/domain-builder/factory/certification/results/build-v3-certification.js

@@ -1,4 +1,4 @@
-import { buildV3CertificationAttestation } from '../factory/certification/results/build-v3-certification-attestation.js';
+import { buildV3Certification } from '../factory/certification/results/build-v3-certification.js';
 import { buildEmptyInformationBanner, buildInformationBanner } from './banner/build-banner-information.js';
 import { buildAccountRecoveryDemand } from './build-account-recovery-demand.js';
 import { buildActivity } from './build-activity.js';
@@ -271,7 +271,7 @@ const certification = {
   },
   results: {
     buildGlobalCertificationLevel,
-    buildV3CertificationAttestation,
+    buildV3Certification,
     parcoursup: {
       buildCertificationResult: parcoursupCertificationResult,
       buildCompetence: parcoursupCompetence,