feat(api): add v3 attestations generation for division

Author: Jeyffrey

api/src/certification/results/application/certification-attestation-controller.js

@@ -1,5 +1,6 @@
 import dayjs from 'dayjs';
 
+import { normalizeAndRemoveAccents } from '../../../shared/infrastructure/utils/string-utils.js';
 import { V3CertificationAttestation } from '../domain/models/V3CertificationAttestation.js';
 import { usecases } from '../domain/usecases/index.js';
 import * as certificationAttestationPdf from '../infrastructure/utils/pdf/certification-attestation-pdf.js';
@@ -95,7 +96,7 @@ const getCertificationPDFAttestationsForSession = async function (
 const downloadCertificationAttestationsForDivision = async function (
   request,
   h,
-  dependencies = { certificationAttestationPdf },
+  dependencies = { certificationAttestationPdf, v3CertificationAttestationPdf },
 ) {
   const organizationId = request.params.organizationId;
   const { i18n } = request;
@@ -107,7 +108,22 @@ const downloadCertificationAttestationsForDivision = async function (
   });
 
   if (attestations.every((attestation) => attestation instanceof V3CertificationAttestation)) {
-    return h.response().code(200);
+    const normalizedDivision = normalizeAndRemoveAccents(division);
+
+    const translatedFileName = i18n.__('certification-confirmation.file-name', {
+      deliveredAt: dayjs(attestations[0].deliveredAt).format('YYYYMMDD'),
+    });
+
+    return h
+      .response(
+        dependencies.v3CertificationAttestationPdf.generate({
+          certificates: attestations,
+          i18n,
+        }),
+      )
+      .code(200)
+      .header('Content-Disposition', `attachment; filename=${normalizedDivision}-${translatedFileName}`)
+      .header('Content-Type', 'application/pdf');
   }
 
   const { buffer } = await dependencies.certificationAttestationPdf.getCertificationAttestationsPdfBuffer({

api/src/shared/infrastructure/utils/string-utils.js

@@ -71,12 +71,24 @@ function toArrayOfFixedLengthStringsConservingWords(str, maxLength) {
   return result.map((str) => str.trim());
 }
 
+function normalizeAndRemoveAccents(str) {
+  return str
+    .normalize('NFD')
+    .replace(/[\u0300-\u036f]/g, '') // Remove accents
+    .toLowerCase()
+    .trim()
+    .replace(/[^a-z0-9 -]/g, '') // Remove special characters
+    .replace(/\s+/g, '-') // Replace spaces by dashes
+    .replace(/-+/g, '-'); // Prevent double dashes
+}
+
 export {
   cleanStringAndParseFloat,
   getArrayOfStrings,
   getArrayOfUpperStrings,
   isNumeric,
   normalize,
+  normalizeAndRemoveAccents,
   normalizeAndSortChars,
   splitIntoWordsAndRemoveBackspaces,
   toArrayOfFixedLengthStringsConservingWords,

api/tests/certification/evaluation/acceptance/application/certification-attestation-route_test.js

@@ -359,6 +359,7 @@ describe('Certification | Results | Acceptance | Application | Routes | certific
 
         const session = databaseBuilder.factory.buildSession({
           version: SESSIONS_VERSIONS.V3,
+          publishedAt: new Date(),
         });
 
         const candidate = databaseBuilder.factory.buildCertificationCandidate({
@@ -403,6 +404,11 @@ describe('Certification | Results | Acceptance | Application | Routes | certific
 
         // then
         expect(response.statusCode).to.equal(200);
+        expect(response.headers['content-type']).to.equal('application/pdf');
+        expect(response.headers['content-disposition']).to.equal(
+          `attachment; filename=${organizationLearner.division}-attestation-pix-${dayjs(session.publishedAt).format('YYYYMMDD')}.pdf`,
+        );
+        expect(response.file).not.to.be.null;
       });
     });
   });

api/tests/certification/results/unit/application/certification-attestation-controller_test.js

@@ -232,56 +232,112 @@ describe('Certification | Results | Unit | Application | Controller | certificat
       clock.restore();
     });
 
-    it('should return binary attestations', async function () {
-      // given
-      const certifications = [
-        domainBuilder.buildPrivateCertificateWithCompetenceTree(),
-        domainBuilder.buildPrivateCertificateWithCompetenceTree(),
-      ];
-      const organizationId = domainBuilder.buildOrganization().id;
-      const division = '3b';
-      const attestationsPDF = 'binary string';
-      const userId = 1;
-      const lang = FRENCH;
-      const i18n = getI18n();
-
-      const request = {
-        i18n,
-        auth: { credentials: { userId } },
-        params: { organizationId },
-        query: { division, isFrenchDomainExtension: true, lang },
-      };
-
-      sinon
-        .stub(usecases, 'findCertificationAttestationsForDivision')
-        .withArgs({
-          division,
-          organizationId,
-        })
-        .resolves(certifications);
-
-      const certificationAttestationPdfStub = {
-        getCertificationAttestationsPdfBuffer: sinon.stub(),
-      };
-
-      const dependencies = {
-        certificationAttestationPdf: certificationAttestationPdfStub,
-      };
-
-      certificationAttestationPdfStub.getCertificationAttestationsPdfBuffer
-        .withArgs({ certificates: certifications, isFrenchDomainExtension: true, i18n })
-        .resolves({ buffer: attestationsPDF });
-
-      // when
-      const response = await certificationAttestationController.downloadCertificationAttestationsForDivision(
-        request,
-        hFake,
-        dependencies,
-      );
-
-      // then
-      expect(response.source).to.deep.equal(attestationsPDF);
-      expect(response.headers['Content-Disposition']).to.contains('attachment; filename=20190101_attestations_3b.pdf');
+    describe('when attestations are for v3', function () {
+      it('should return division attestations in PDF binary format', async function () {
+        // given
+        const userId = 1;
+        const i18n = getI18n();
+
+        const v3CertificationAttestation = domainBuilder.certification.results.buildV3CertificationAttestation();
+        const generatedPdf = Symbol('Stream');
+
+        const organizationId = domainBuilder.buildOrganization().id;
+        const division = '3ème b';
+
+        const request = {
+          i18n,
+          auth: { credentials: { userId } },
+          params: { organizationId },
+          query: { division, isFrenchDomainExtension: true, lang: FRENCH },
+        };
+
+        sinon
+          .stub(usecases, 'findCertificationAttestationsForDivision')
+          .withArgs({
+            division,
+            organizationId,
+          })
+          .resolves([v3CertificationAttestation, v3CertificationAttestation]);
+
+        const generatePdfStub = {
+          generate: sinon.stub().returns(generatedPdf),
+        };
+
+        // when
+        const response = await certificationAttestationController.downloadCertificationAttestationsForDivision(
+          request,
+          hFake,
+          {
+            v3CertificationAttestationPdf: generatePdfStub,
+          },
+        );
+
+        // then
+        expect(generatePdfStub.generate).calledOnceWithExactly({
+          certificates: [v3CertificationAttestation, v3CertificationAttestation],
+          i18n,
+        });
+        expect(response.source).to.deep.equal(generatedPdf);
+        expect(response.headers['Content-Disposition']).to.contains(
+          `attachment; filename=3eme-b-attestation-pix-${dayjs(v3CertificationAttestation.deliveredAt).format('YYYYMMDD')}.pdf`,
+        );
+      });
+    });
+
+    describe('when attestations are for v2', function () {
+      it('should return binary attestations', async function () {
+        // given
+        const certifications = [
+          domainBuilder.buildPrivateCertificateWithCompetenceTree(),
+          domainBuilder.buildPrivateCertificateWithCompetenceTree(),
+        ];
+        const organizationId = domainBuilder.buildOrganization().id;
+        const division = '3b';
+        const attestationsPDF = 'binary string';
+        const userId = 1;
+        const lang = FRENCH;
+        const i18n = getI18n();
+
+        const request = {
+          i18n,
+          auth: { credentials: { userId } },
+          params: { organizationId },
+          query: { division, isFrenchDomainExtension: true, lang },
+        };
+
+        sinon
+          .stub(usecases, 'findCertificationAttestationsForDivision')
+          .withArgs({
+            division,
+            organizationId,
+          })
+          .resolves(certifications);
+
+        const certificationAttestationPdfStub = {
+          getCertificationAttestationsPdfBuffer: sinon.stub(),
+        };
+
+        const dependencies = {
+          certificationAttestationPdf: certificationAttestationPdfStub,
+        };
+
+        certificationAttestationPdfStub.getCertificationAttestationsPdfBuffer
+          .withArgs({ certificates: certifications, isFrenchDomainExtension: true, i18n })
+          .resolves({ buffer: attestationsPDF });
+
+        // when
+        const response = await certificationAttestationController.downloadCertificationAttestationsForDivision(
+          request,
+          hFake,
+          dependencies,
+        );
+
+        // then
+        expect(response.source).to.deep.equal(attestationsPDF);
+        expect(response.headers['Content-Disposition']).to.contains(
+          'attachment; filename=20190101_attestations_3b.pdf',
+        );
+      });
     });
   });
 });

api/tests/shared/unit/infrastructure/utils/string-utils_test.js

@@ -4,6 +4,7 @@ import {
   getArrayOfUpperStrings,
   isNumeric,
   normalize,
+  normalizeAndRemoveAccents,
   normalizeAndSortChars,
   splitIntoWordsAndRemoveBackspaces,
   toArrayOfFixedLengthStringsConservingWords,
@@ -195,4 +196,17 @@ describe('Unit | Shared | infrastructure | Utils | string-utils', function () {
       ]);
     });
   });
+
+  describe('#normalizeAndRemoveAccents', function () {
+    it('should return a string without spaces and special characters', function () {
+      // given
+      const stringToSanitize = "chef-d'œuvre de string -- @ http://www.complexité.fr";
+
+      // when
+      const result = normalizeAndRemoveAccents(stringToSanitize);
+
+      // then
+      expect(result).to.equal('chef-duvre-de-string-httpwwwcomplexitefr');
+    });
+  });
 });