feat?(api): create internal targetProfileApi

Author: Alexandre-Monney

api/src/prescription/campaign/domain/usecases/get-target-profile.js

@@ -1,5 +1,5 @@
 const getTargetProfile = async function ({ campaignId, targetProfileRepository }) {
-  return targetProfileRepository.getByCampaignId(campaignId);
+  return targetProfileRepository.getByCampaignId({ campaignId });
 };
 
 export { getTargetProfile };

api/src/prescription/campaign/domain/usecases/index.js

@@ -35,7 +35,6 @@ import * as divisionRepository from '../../infrastructure/repositories/division-
 import * as groupRepository from '../../infrastructure/repositories/group-repository.js';
 import { repositories as campaignRepositories } from '../../infrastructure/repositories/index.js';
 import * as knowledgeElementSnapshotRepository from '../../infrastructure/repositories/knowledge-element-snapshot-repository.js';
-import * as targetProfileRepository from '../../infrastructure/repositories/target-profile-repository.js';
 import * as campaignMediaComplianceService from '../services/campaign-media-compliance-service.js';
 import * as campaignUpdateValidator from '../validators/campaign-update-validator.js';
 
@@ -109,7 +108,7 @@ const dependencies = {
   organizationRepository,
   placementProfileService,
   stageCollectionRepository,
-  targetProfileRepository, // TODO
+  targetProfileRepository: campaignRepositories.targetProfileRepository, // TODO
   tutorialRepository,
   userRepository,
   campaignMediaComplianceService,

api/src/prescription/campaign/domain/usecases/start-writing-campaign-assessment-results-to-stream.js

@@ -60,7 +60,7 @@ const startWritingCampaignAssessmentResultsToStream = async function ({
     throw new CampaignTypeError();
   }
 
-  const targetProfile = await targetProfileRepository.getByCampaignId(campaign.id);
+  const targetProfile = await targetProfileRepository.getByCampaignId({ campaignId: campaign.id });
   const learningContent = await learningContentRepository.findByCampaignId(campaign.id, i18n.getLocale());
   const stageCollection = await stageCollectionRepository.findStageCollection({ campaignId });
 

api/src/prescription/campaign/infrastructure/repositories/index.js

@@ -1,17 +1,21 @@
 import * as organizationFeatureAPI from '../../../../organizational-entities/application/api/organization-features-api.js';
 import { injectDependencies } from '../../../../shared/infrastructure/utils/dependency-injection.js';
 import * as organizationApi from '../../../../team/application/api/organization.js';
+import * as targetProfileApi from '../../../target-profile/application/api/target-profile-api.js';
 import * as campaignToJoinRepository from './campaign-to-join-repository.js';
 import * as organizationMembershipRepository from './organization-membership-repository.js';
+import * as targetProfileRepository from './target-profile-repository.js';
 
 const repositoriesWithoutInjectedDependencies = {
   campaignToJoinRepository,
   organizationMembershipRepository,
+  targetProfileRepository,
 };
 
 const dependencies = {
   organizationApi,
   organizationFeatureAPI,
+  targetProfileApi,
 };
 
 const repositories = injectDependencies(repositoriesWithoutInjectedDependencies, dependencies);

api/src/prescription/campaign/infrastructure/repositories/target-profile-repository.js

@@ -2,10 +2,11 @@ import { knex } from '../../../../../db/knex-database-connection.js';
 import { Badge } from '../../../../evaluation/domain/models/Badge.js';
 import { TargetProfile } from '../../../../shared/domain/models/index.js';
 
-const getByCampaignId = async function (campaignId) {
+const getByCampaignId = async function ({ campaignId, targetProfileApi }) {
   const { targetProfileId } = await knex('campaigns').select('targetProfileId').where({ id: campaignId }).first();
 
-  const targetProfile = await knex('target-profiles').where({ id: targetProfileId }).first();
+  const targetProfile = await targetProfileApi.getById(targetProfileId);
+
   const badges = await knex('badges').where('targetProfileId', targetProfileId);
 
   return new TargetProfile({ ...targetProfile, badges: badges.map((badge) => new Badge(badge)) });

api/src/prescription/target-profile/application/api/target-profile-api.js

@@ -32,6 +32,19 @@ export const getByIdForAdmin = async (id) => {
   return new TargetProfile(targetProfileForAdmin);
 };
 
+/**
+ * @function
+ * @name getById
+ *
+ * @param {number} id
+ * @returns {Promise<TargetProfile>}
+ */
+export const getById = async (id) => {
+  const targetProfile = await usecases.getTargetProfile({ targetProfileId: id });
+
+  return new TargetProfile(targetProfile);
+};
+
 /**
  * @function
  * @name findSkillByTargetProfileIds

api/src/prescription/target-profile/domain/usecases/get-target-profile.js

@@ -0,0 +1,5 @@
+const getTargetProfile = async function ({ targetProfileId, targetProfileRepository }) {
+  return targetProfileRepository.get(targetProfileId);
+};
+
+export { getTargetProfile };

api/tests/prescription/campaign/integration/infrastructure/repositories/target-profile-repository_test.js

@@ -1,4 +1,4 @@
-import * as targetProfileRepository from '../../../../../../src/prescription/campaign/infrastructure/repositories/target-profile-repository.js';
+import { repositories } from '../../../../../../src/prescription/campaign/infrastructure/repositories/index.js';
 import { databaseBuilder, expect } from '../../../../../test-helper.js';
 
 describe('Integration | Repository | Target-profile', function () {
@@ -18,7 +18,7 @@ describe('Integration | Repository | Target-profile', function () {
 
     it('should return the target profile matching the campaign id', async function () {
       // when
-      const targetProfile = await targetProfileRepository.getByCampaignId(campaignId);
+      const targetProfile = await repositories.targetProfileRepository.getByCampaignId({ campaignId });
 
       // then
       expect(targetProfile.id).to.equal(targetProfileId);

api/tests/prescription/campaign/unit/domain/usecases/get-target-profile_test.js

@@ -9,7 +9,7 @@ describe('Unit | UseCase | get-target-profile', function () {
     };
     const campaignId = 123;
     const targetProfile = Symbol('targetProfile');
-    targetProfileRepository.getByCampaignId.withArgs(campaignId).resolves(targetProfile);
+    targetProfileRepository.getByCampaignId.withArgs({ campaignId }).resolves(targetProfile);
 
     // when
     const result = await getTargetProfile({