feat(api): add v3 attestation generation for session

Jeyffrey · Jeyffrey · commit 967801cbe6c6 · 2025-03-21T14:42:19.000+01:00
diff --git a/api/src/certification/results/application/certification-attestation-controller.js b/api/src/certification/results/application/certification-attestation-controller.js
@@ -52,19 +52,32 @@ const getPDFAttestation = async function (
 const getCertificationPDFAttestationsForSession = async function (
   request,
   h,
-  dependencies = { certificationAttestationPdf },
+  dependencies = { certificationAttestationPdf, v3CertificationAttestationPdf },
 ) {
+  const { i18n } = request;
+
   const sessionId = request.params.sessionId;
   const isFrenchDomainExtension = request.query.isFrenchDomainExtension;
   const attestations = await usecases.getCertificationAttestationsForSession({
     sessionId,
   });
 
   if (attestations.every((attestation) => attestation instanceof V3CertificationAttestation)) {
-    return h.response().code(200);
-  }
+    const translatedFileName = i18n.__('certification-confirmation.file-name', {
+      deliveredAt: dayjs(attestations[0].deliveredAt).format('YYYYMMDD'),
+    });
 
-  const i18n = request.i18n;
+    return h
+      .response(
+        dependencies.v3CertificationAttestationPdf.generate({
+          certificates: attestations,
+          i18n,
+        }),
+      )
+      .code(200)
+      .header('Content-Disposition', `attachment; filename=session-${sessionId}-${translatedFileName}`)
+      .header('Content-Type', 'application/pdf');
+  }
 
   const { buffer } = await dependencies.certificationAttestationPdf.getCertificationAttestationsPdfBuffer({
     certificates: attestations,
diff --git a/api/tests/certification/evaluation/acceptance/application/certification-attestation-route_test.js b/api/tests/certification/evaluation/acceptance/application/certification-attestation-route_test.js
@@ -1,6 +1,8 @@
 import { readFile } from 'node:fs/promises';
 import * as url from 'node:url';
 
+import dayjs from 'dayjs';
+
 import { generateCertificateVerificationCode } from '../../../../../src/certification/evaluation/domain/services/verify-certificate-code-service.js';
 import { SESSIONS_VERSIONS } from '../../../../../src/certification/shared/domain/models/SessionVersion.js';
 import { Assessment } from '../../../../../src/shared/domain/models/index.js';
@@ -224,14 +226,16 @@ describe('Certification | Results | Acceptance | Application | Routes | certific
     });
 
     describe('when the session version is V3', function () {
-      it('should return 200 HTTP status code', async function () {
+      it('should return 200 HTTP status code and the certification', async function () {
         // given
         await featureToggles.set('isV3CertificationAttestationEnabled', true);
         const superAdmin = await insertUserWithRoleSuperAdmin();
 
-        await _buildDatabaseCertification({
+        const sessionId = 4567;
+
+        const { session } = await _buildDatabaseCertification({
           userId: superAdmin.id,
-          sessionId: 4567,
+          sessionId,
           sessionVersion: SESSIONS_VERSIONS.V3,
         });
         await databaseBuilder.commit();
@@ -247,6 +251,11 @@ describe('Certification | Results | Acceptance | Application | Routes | certific
 
         // then
         expect(response.statusCode).to.equal(200);
+        expect(response.headers['content-type']).to.equal('application/pdf');
+        expect(response.headers['content-disposition']).to.equal(
+          `attachment; filename=session-${sessionId}-attestation-pix-${dayjs(session.publishedAt).format('YYYYMMDD')}.pdf`,
+        );
+        expect(response.file).not.to.be.null;
       });
     });
   });
diff --git a/api/tests/certification/results/unit/application/certification-attestation-controller_test.js b/api/tests/certification/results/unit/application/certification-attestation-controller_test.js
@@ -10,7 +10,7 @@ const { FRENCH } = LANGUAGES_CODE;
 
 describe('Certification | Results | Unit | Application | Controller | certification-attestation-controller', function () {
   describe('#getPDFAttestation', function () {
-    describe('when the certification is new v3', function () {
+    describe('when the attestation is for v3', function () {
       it('should return attestation in PDF binary format', async function () {
         // given
         const v3CertificationAttestation = domainBuilder.certification.results.buildV3CertificationAttestation();
@@ -54,7 +54,7 @@ describe('Certification | Results | Unit | Application | Controller | certificat
       });
     });
 
-    describe('when the certification is v2 or previous v3', function () {
+    describe('when the attestation is for v2', function () {
       it('should return attestation in PDF binary format', async function () {
         // given
         const certificationAttestation = domainBuilder.buildCertificationAttestation();
@@ -99,73 +99,124 @@ describe('Certification | Results | Unit | Application | Controller | certificat
   });
 
   describe('#getCertificationPDFAttestationsForSession', function () {
-    it('should return an attestation in PDF binary format', async function () {
-      // given
-      const certificationAttestationPdf = {
-        getCertificationAttestationsPdfBuffer: sinon.stub(),
-      };
-      const session = domainBuilder.certification.sessionManagement.buildSession.finalized({ id: 12 });
-      domainBuilder.buildCertificationCourse({
-        id: 1,
-        sessionId: 12,
-        userId: 1,
-        completedAt: '2020-01-01',
-      });
-      domainBuilder.buildCertificationCourse({
-        id: 2,
-        sessionId: 12,
-        userId: 2,
-        completedAt: '2020-01-01',
-      });
-      domainBuilder.buildCertificationCourse({
-        id: 3,
-        sessionId: 12,
-        userId: 3,
-        completedAt: '2020-01-01',
-      });
-      const certification1 = domainBuilder.buildPrivateCertificateWithCompetenceTree({ id: 1 });
-      const certification2 = domainBuilder.buildPrivateCertificateWithCompetenceTree({ id: 2 });
-      const certification3 = domainBuilder.buildPrivateCertificateWithCompetenceTree({ id: 3 });
-      const attestationPDF = 'binary string';
-      const userId = 1;
-      const i18n = getI18n();
+    describe('when attestations are for a v3 session', function () {
+      it('should return attestation in PDF binary format', async function () {
+        // given
+        const userId = 1;
+        const i18n = getI18n();
 
-      const request = {
-        auth: { credentials: { userId } },
-        params: { sessionId: session.id },
-        query: { isFrenchDomainExtension: true },
-        i18n,
-      };
+        const v3CertificationAttestation = domainBuilder.certification.results.buildV3CertificationAttestation();
+        const session = domainBuilder.certification.sessionManagement.buildSession.finalized({ id: 12 });
+        const generatedPdf = Symbol('Stream');
 
-      sinon
-        .stub(usecases, 'getCertificationAttestationsForSession')
-        .withArgs({
-          sessionId: session.id,
-        })
-        .resolves([certification1, certification2, certification3]);
+        const request = {
+          i18n,
+          auth: { credentials: { userId } },
+          params: { sessionId: session.id },
+          query: { isFrenchDomainExtension: true },
+        };
 
-      certificationAttestationPdf.getCertificationAttestationsPdfBuffer
-        .withArgs({
-          certificates: [certification1, certification2, certification3],
-          isFrenchDomainExtension: true,
+        sinon
+          .stub(usecases, 'getCertificationAttestationsForSession')
+          .withArgs({
+            sessionId: session.id,
+          })
+          .resolves([v3CertificationAttestation, v3CertificationAttestation]);
+
+        const generatePdfStub = {
+          generate: sinon.stub().returns(generatedPdf),
+        };
+
+        // when
+        const response = await certificationAttestationController.getCertificationPDFAttestationsForSession(
+          request,
+          hFake,
+          {
+            v3CertificationAttestationPdf: generatePdfStub,
+          },
+        );
+
+        // then
+        expect(generatePdfStub.generate).calledOnceWithExactly({
+          certificates: [v3CertificationAttestation, v3CertificationAttestation],
           i18n,
-        })
-        .resolves({ buffer: attestationPDF });
+        });
+        expect(response.source).to.deep.equal(generatedPdf);
+        expect(response.headers['Content-Disposition']).to.contains(
+          `attachment; filename=session-${session.id}-attestation-pix-${dayjs(v3CertificationAttestation.deliveredAt).format('YYYYMMDD')}.pdf`,
+        );
+      });
+    });
 
-      // when
-      const response = await certificationAttestationController.getCertificationPDFAttestationsForSession(
-        request,
-        hFake,
-        {
-          certificationAttestationPdf,
-        },
-      );
+    describe('when attestations are for a v2 session', function () {
+      it('should return an attestation in PDF binary format', async function () {
+        // given
+        const certificationAttestationPdf = {
+          getCertificationAttestationsPdfBuffer: sinon.stub(),
+        };
+        const session = domainBuilder.certification.sessionManagement.buildSession.finalized({ id: 12 });
+        domainBuilder.buildCertificationCourse({
+          id: 1,
+          sessionId: 12,
+          userId: 1,
+          completedAt: '2020-01-01',
+        });
+        domainBuilder.buildCertificationCourse({
+          id: 2,
+          sessionId: 12,
+          userId: 2,
+          completedAt: '2020-01-01',
+        });
+        domainBuilder.buildCertificationCourse({
+          id: 3,
+          sessionId: 12,
+          userId: 3,
+          completedAt: '2020-01-01',
+        });
+        const certification1 = domainBuilder.buildPrivateCertificateWithCompetenceTree({ id: 1 });
+        const certification2 = domainBuilder.buildPrivateCertificateWithCompetenceTree({ id: 2 });
+        const certification3 = domainBuilder.buildPrivateCertificateWithCompetenceTree({ id: 3 });
+        const attestationPDF = 'binary string';
+        const userId = 1;
+        const i18n = getI18n();
 
-      // then
-      expect(response.source).to.deep.equal(attestationPDF);
-      expect(response.headers['Content-Disposition']).to.contains(
-        'attachment; filename=attestation-pix-session-12.pdf',
-      );
+        const request = {
+          auth: { credentials: { userId } },
+          params: { sessionId: session.id },
+          query: { isFrenchDomainExtension: true },
+          i18n,
+        };
+
+        sinon
+          .stub(usecases, 'getCertificationAttestationsForSession')
+          .withArgs({
+            sessionId: session.id,
+          })
+          .resolves([certification1, certification2, certification3]);
+
+        certificationAttestationPdf.getCertificationAttestationsPdfBuffer
+          .withArgs({
+            certificates: [certification1, certification2, certification3],
+            isFrenchDomainExtension: true,
+            i18n,
+          })
+          .resolves({ buffer: attestationPDF });
+
+        // when
+        const response = await certificationAttestationController.getCertificationPDFAttestationsForSession(
+          request,
+          hFake,
+          {
+            certificationAttestationPdf,
+          },
+        );
+
+        // then
+        expect(response.source).to.deep.equal(attestationPDF);
+        expect(response.headers['Content-Disposition']).to.contains(
+          'attachment; filename=attestation-pix-session-12.pdf',
+        );
+      });
     });
   });
 
