feat(mon-pix): move modal out of if/else condition

in quit-results

Co-authored-by: Yann Bertrand <yann.bertrand@pix.fr>
Co-authored-by: Eric Lim <eric.lim@pix.fr>

Author: 3 people

mon-pix/app/components/campaigns/assessment/results/quit-results.gjs

@@ -25,34 +25,34 @@ export default class QuitResults extends Component {
       <button class="evaluation-results-header__back-link" type="button" {{on "click" this.toggleModal}}>
         {{t "common.actions.quit"}}
       </button>
-      <PixModal
-        @title={{t "pages.evaluation-results.quit-results.modal.title"}}
-        @onCloseButtonClick={{this.toggleModal}}
-        @showModal={{this.showModal}}
-      >
-        <:content>
-          <p class="quit-results__first-paragraph">{{t
-              "pages.evaluation-results.quit-results.modal.content-information"
-            }}</p>
-          <p><strong>{{t "pages.evaluation-results.quit-results.modal.content-instruction"}}</strong></p>
-        </:content>
-
-        <:footer>
-          <div class="quit-results__footer">
-            <PixButton @variant="secondary" @triggerAction={{this.toggleModal}}>
-              {{t "pages.evaluation-results.quit-results.modal.actions.cancel-to-share"}}
-            </PixButton>
-
-            <PixButtonLink @href="authenticated" @variant="primary">
-              {{t "pages.evaluation-results.quit-results.modal.actions.quit-without-sharing"}}
-            </PixButtonLink>
-          </div>
-        </:footer>
-      </PixModal>
     {{else}}
       <LinkTo @route="authenticated" class="evaluation-results-header__back-link">
         {{t "common.actions.quit"}}
       </LinkTo>
     {{/if}}
+    <PixModal
+      @title={{t "pages.evaluation-results.quit-results.modal.title"}}
+      @onCloseButtonClick={{this.toggleModal}}
+      @showModal={{this.showModal}}
+    >
+      <:content>
+        <p class="quit-results__first-paragraph">{{t
+            "pages.evaluation-results.quit-results.modal.content-information"
+          }}</p>
+        <p><strong>{{t "pages.evaluation-results.quit-results.modal.content-instruction"}}</strong></p>
+      </:content>
+
+      <:footer>
+        <div class="quit-results__footer">
+          <PixButton @variant="secondary" @triggerAction={{this.toggleModal}}>
+            {{t "pages.evaluation-results.quit-results.modal.actions.cancel-to-share"}}
+          </PixButton>
+
+          <PixButtonLink @href="authenticated" @variant="primary">
+            {{t "pages.evaluation-results.quit-results.modal.actions.quit-without-sharing"}}
+          </PixButtonLink>
+        </div>
+      </:footer>
+    </PixModal>
   </template>
 }