bugfix(api): wrong repository called (confusion is high)

Author: laura-bergoens

api/src/shared/domain/usecases/get-next-challenge.js

@@ -4,7 +4,7 @@ export async function getNextChallenge({
   locale,
   assessmentRepository,
   evaluationUsecases,
-  certificationVersionRepository,
+  certificationEvaluationRepository,
 }) {
   const assessment = await assessmentRepository.get(assessmentId);
 
@@ -14,7 +14,7 @@ export async function getNextChallenge({
 
   let nextChallenge = null;
   if (assessment.isCertification()) {
-    nextChallenge = await certificationVersionRepository.selectNextCertificationChallenge({
+    nextChallenge = await certificationEvaluationRepository.selectNextCertificationChallenge({
       assessmentId: assessment.id,
       locale,
     });

api/src/shared/domain/usecases/index.js

@@ -2,11 +2,11 @@ import { dirname, join } from 'node:path';
 import { fileURLToPath } from 'node:url';
 
 import * as complementaryCertificationBadgeRepository from '../../../certification/complementary-certification/infrastructure/repositories/complementary-certification-badge-repository.js';
-import * as certificationVersionRepository from '../../../certification/results/infrastructure/repositories/certification-version-repository.js';
 import { evaluationUsecases } from '../../../evaluation/domain/usecases/index.js';
 import * as badgeRepository from '../../../evaluation/infrastructure/repositories/badge-repository.js';
 import * as assessmentRepository from '../../infrastructure/repositories/assessment-repository.js';
 import * as challengeRepository from '../../infrastructure/repositories/challenge-repository.js';
+import { repositories as sharedInjectedRepositories } from '../../infrastructure/repositories/index.js';
 import { injectDependencies } from '../../infrastructure/utils/dependency-injection.js';
 import { importNamedExportsFromDirectory } from '../../infrastructure/utils/import-named-exports-from-directory.js';
 const path = dirname(fileURLToPath(import.meta.url));
@@ -20,8 +20,8 @@ const dependencies = {
   complementaryCertificationBadgeRepository,
   badgeRepository,
   challengeRepository,
-  certificationVersionRepository,
   evaluationUsecases,
+  ...sharedInjectedRepositories,
 };
 
 const sharedUsecases = injectDependencies(usecasesWithoutInjectedDependencies, dependencies);

api/tests/shared/unit/domain/usecases/get-next-challenge_test.js

@@ -12,7 +12,7 @@ describe('Shared | Unit | Domain | Use Cases | get-next-challenge', function ()
     let evaluationUsecases_getNextChallengeForDemoStub;
     let evaluationUsecases_getNextChallengeForCampaignAssessmentStub;
     let evaluationUsecases_getNextChallengeForCompetenceEvaluationStub;
-    let certificationVersionRepository_selectNextCertificationChallengeStub;
+    let certificationEvaluationRepository_selectNextCertificationChallengeStub;
 
     beforeEach(function () {
       userId = 'someUserId';
@@ -29,7 +29,7 @@ describe('Shared | Unit | Domain | Use Cases | get-next-challenge', function ()
       evaluationUsecases_getNextChallengeForCompetenceEvaluationStub = sinon
         .stub()
         .named('getNextChallengeForCompetenceEvaluation');
-      certificationVersionRepository_selectNextCertificationChallengeStub = sinon
+      certificationEvaluationRepository_selectNextCertificationChallengeStub = sinon
         .stub()
         .named('selectNextCertificationChallenge');
       preventStubsToBeCalledUnexpectedly([
@@ -39,7 +39,7 @@ describe('Shared | Unit | Domain | Use Cases | get-next-challenge', function ()
         evaluationUsecases_getNextChallengeForDemoStub,
         evaluationUsecases_getNextChallengeForCampaignAssessmentStub,
         evaluationUsecases_getNextChallengeForCompetenceEvaluationStub,
-        certificationVersionRepository_selectNextCertificationChallengeStub,
+        certificationEvaluationRepository_selectNextCertificationChallengeStub,
       ]);
 
       const assessmentRepository = {
@@ -55,8 +55,8 @@ describe('Shared | Unit | Domain | Use Cases | get-next-challenge', function ()
         getNextChallengeForCompetenceEvaluation: evaluationUsecases_getNextChallengeForCompetenceEvaluationStub,
       };
 
-      const certificationVersionRepository = {
-        selectNextCertificationChallenge: certificationVersionRepository_selectNextCertificationChallengeStub,
+      const certificationEvaluationRepository = {
+        selectNextCertificationChallenge: certificationEvaluationRepository_selectNextCertificationChallengeStub,
       };
 
       dependencies = {
@@ -65,7 +65,7 @@ describe('Shared | Unit | Domain | Use Cases | get-next-challenge', function ()
         locale,
         assessmentRepository,
         evaluationUsecases,
-        certificationVersionRepository,
+        certificationEvaluationRepository,
       };
     });
 
@@ -162,7 +162,7 @@ describe('Shared | Unit | Domain | Use Cases | get-next-challenge', function ()
 
         it('should call usecase and return value from certification usecase', async function () {
           const challenge = domainBuilder.buildChallenge({ id: 'challengeForCertification' });
-          certificationVersionRepository_selectNextCertificationChallengeStub
+          certificationEvaluationRepository_selectNextCertificationChallengeStub
             .withArgs({ assessmentId: assessment.id, locale })
             .resolves(challenge);
           const actualNextChallenge = await getNextChallenge(dependencies);