[BUGFIX] Empêcher la validation d'un live-alert assigné à une épreuve déjà répondue (PIX-16783).

pix-service-auto-merge · web-flow · commit b6f546ee1237 · 2025-03-03T17:52:53.000+01:00
#11542
diff --git a/api/src/certification/evaluation/domain/errors.js b/api/src/certification/evaluation/domain/errors.js
@@ -1,8 +1,8 @@
 import { DomainError } from '../../../shared/domain/errors.js';
 
 class ChallengeAlreadyAnsweredError extends DomainError {
-  constructor(message) {
-    super(message);
+  constructor() {
+    super('La question a déjà été répondue.', 'ALREADY_ANSWERED_ERROR');
   }
 }
 
diff --git a/api/src/certification/session-management/domain/usecases/validate-live-alert.js b/api/src/certification/session-management/domain/usecases/validate-live-alert.js
@@ -7,6 +7,7 @@
 
 import { NotFoundError } from '../../../../shared/domain/errors.js';
 import { CertificationIssueReport, CertificationIssueReportCategory } from '../../../../shared/domain/models/index.js';
+import { ChallengeAlreadyAnsweredError } from '../../../evaluation/domain/errors.js';
 
 /**
  * @param {Object} params
@@ -23,6 +24,7 @@ export const validateLiveAlert = async ({
   assessmentRepository,
   issueReportCategoryRepository,
   certificationIssueReportRepository,
+  answerRepository,
 }) => {
   const certificationChallengeLiveAlert =
     await certificationChallengeLiveAlertRepository.getOngoingBySessionIdAndUserId({
@@ -34,6 +36,12 @@ export const validateLiveAlert = async ({
     throw new NotFoundError('There is no ongoing alert for this user');
   }
 
+  await _dismissLiveAlertForAnsweredChallenge({
+    certificationChallengeLiveAlert,
+    certificationChallengeLiveAlertRepository,
+    answerRepository,
+  });
+
   const assessment = await assessmentRepository.get(certificationChallengeLiveAlert.assessmentId);
 
   const { certificationCourseId } = assessment;
@@ -59,3 +67,25 @@ export const validateLiveAlert = async ({
     certificationChallengeLiveAlert,
   });
 };
+
+async function _dismissLiveAlertForAnsweredChallenge({
+  certificationChallengeLiveAlert,
+  certificationChallengeLiveAlertRepository,
+  answerRepository,
+}) {
+  const candidateAnswers = await answerRepository.findByAssessment(certificationChallengeLiveAlert.assessmentId);
+
+  const answeredAlertedChallenge = candidateAnswers.find(
+    (answer) => answer.challengeId === certificationChallengeLiveAlert.challengeId,
+  );
+
+  if (answeredAlertedChallenge) {
+    certificationChallengeLiveAlert.dismiss();
+
+    await certificationChallengeLiveAlertRepository.save({
+      certificationChallengeLiveAlert,
+    });
+
+    throw new ChallengeAlreadyAnsweredError();
+  }
+}
diff --git a/api/src/shared/application/error-manager.js b/api/src/shared/application/error-manager.js
@@ -3,6 +3,7 @@ import _ from 'lodash';
 
 import * as translations from '../../../translations/index.js';
 import { AdminMemberError } from '../../authorization/domain/errors.js';
+import { ChallengeAlreadyAnsweredError } from '../../certification/evaluation/domain/errors.js';
 import {
   CsvWithNoSessionDataError,
   SendingEmailToRefererError,
@@ -176,6 +177,10 @@ function _mapToHttpError(error) {
     return new HttpErrors.PreconditionFailedError(error.message);
   }
 
+  if (error instanceof ChallengeAlreadyAnsweredError) {
+    return new HttpErrors.UnprocessableEntityError(error.message, error.code);
+  }
+
   if (error instanceof CsvWithNoSessionDataError) {
     return new HttpErrors.UnprocessableEntityError(error.message, error.code);
   }
diff --git a/api/tests/certification/session-management/unit/domain/usecases/validate-live-alert_test.js b/api/tests/certification/session-management/unit/domain/usecases/validate-live-alert_test.js
@@ -1,3 +1,4 @@
+import { ChallengeAlreadyAnsweredError } from '../../../../../../src/certification/evaluation/domain/errors.js';
 import { validateLiveAlert } from '../../../../../../src/certification/session-management/domain/usecases/validate-live-alert.js';
 import { CertificationChallengeLiveAlertStatus } from '../../../../../../src/certification/shared/domain/models/CertificationChallengeLiveAlert.js';
 import {
@@ -12,6 +13,7 @@ describe('Unit | UseCase | validate-live-alert', function () {
   let assessmentRepository;
   let issueReportCategoryRepository;
   let certificationIssueReportRepository;
+  let answerRepository;
 
   beforeEach(function () {
     certificationChallengeLiveAlertRepository = {
@@ -30,6 +32,10 @@ describe('Unit | UseCase | validate-live-alert', function () {
     certificationIssueReportRepository = {
       save: sinon.stub(),
     };
+
+    answerRepository = {
+      findByAssessment: sinon.stub(),
+    };
   });
 
   describe('when the liveAlert does not exist', function () {
@@ -57,6 +63,52 @@ describe('Unit | UseCase | validate-live-alert', function () {
   });
 
   describe('when the liveAlert exists', function () {
+    describe('when an answer for the alerted challenge exists', function () {
+      it('should throw an error', async function () {
+        // given
+        const sessionId = 123;
+        const userId = 456;
+        const assessmentId = 789;
+        const questionNumber = 2;
+        const challengeId = 'rec123';
+
+        const onGoingLiveAlert = domainBuilder.buildCertificationChallengeLiveAlert({
+          questionNumber,
+          challengeId,
+          assessmentId,
+          status: CertificationChallengeLiveAlertStatus.ONGOING,
+        });
+
+        certificationChallengeLiveAlertRepository.getOngoingBySessionIdAndUserId
+          .withArgs({
+            sessionId,
+            userId,
+          })
+          .resolves(onGoingLiveAlert);
+
+        answerRepository.findByAssessment
+          .withArgs(onGoingLiveAlert.assessmentId)
+          .resolves([domainBuilder.buildAnswer({ challengeId })]);
+
+        const error = await catchErr(validateLiveAlert)({
+          certificationChallengeLiveAlertRepository,
+          issueReportCategoryRepository,
+          certificationIssueReportRepository,
+          answerRepository,
+          sessionId,
+          userId,
+        });
+
+        // then
+        expect(onGoingLiveAlert.status).equals(CertificationChallengeLiveAlertStatus.DISMISSED);
+        expect(certificationChallengeLiveAlertRepository.save).to.have.been.calledWith({
+          certificationChallengeLiveAlert: onGoingLiveAlert,
+        });
+
+        expect(error).to.be.instanceOf(ChallengeAlreadyAnsweredError);
+      });
+    });
+
     it('should update the LiveAlert and create a new resolved CertificationIssueReport', async function () {
       // given
       const sessionId = 123;
@@ -97,6 +149,8 @@ describe('Unit | UseCase | validate-live-alert', function () {
         })
         .resolves(issueReportCategory);
 
+      answerRepository.findByAssessment.withArgs(liveAlert.assessmentId).resolves([]);
+
       const validatedLiveAlert = domainBuilder.buildCertificationChallengeLiveAlert({
         assessmentId: liveAlert.assessmentId,
         challengeId: liveAlert.challengeId,
@@ -110,6 +164,7 @@ describe('Unit | UseCase | validate-live-alert', function () {
         issueReportCategoryRepository,
         assessmentRepository,
         certificationIssueReportRepository,
+        answerRepository,
         subcategory,
         sessionId,
         userId,
diff --git a/certif/app/components/session-supervising/candidate-in-list.js b/certif/app/components/session-supervising/candidate-in-list.js
@@ -165,7 +165,7 @@ export default class CandidateInList extends Component {
       this.displayedModal = Modals.HandledLiveAlertSuccess;
     } catch (error) {
       const errorMessage = this.intl.t(
-        'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling-live-alert',
+        'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.miscellaneous',
       );
       this.pixToast.sendErrorNotification({ message: errorMessage });
     }
@@ -183,9 +183,14 @@ export default class CandidateInList extends Component {
       this.isLiveAlertValidated = true;
       this.displayedModal = Modals.HandledLiveAlertSuccess;
     } catch (err) {
-      const errorMessage = this.intl.t(
-        'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling-live-alert',
-      );
+      const errorMessage =
+        err.errors[0].code === 'ALREADY_ANSWERED_ERROR'
+          ? this.intl.t(
+              'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.challenge-already-answered',
+            )
+          : this.intl.t(
+              'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.miscellaneous',
+            );
       this.pixToast.sendErrorNotification({ message: errorMessage });
     }
   }
@@ -207,7 +212,7 @@ export default class CandidateInList extends Component {
     } catch (error) {
       this.pixToast.sendErrorNotification({
         message: this.intl.t(
-          'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling-live-alert',
+          'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.miscellaneous',
         ),
       });
     } finally {
diff --git a/certif/tests/acceptance/session-supervising-test.js b/certif/tests/acceptance/session-supervising-test.js
@@ -435,7 +435,7 @@ module('Acceptance | Session supervising', function (hooks) {
             const candidateId = 12345;
             server.patch(
               `/sessions/${sessionId}/candidates/${candidateId}/validate-live-alert`,
-              () => new Response(400),
+              () => new Response(400, {}, { errors: [{ code: 'SOME_CODE' }] }),
             );
             this.sessionForSupervising = server.create('session-for-supervising', {
               id: sessionId,
diff --git a/certif/tests/unit/components/session-supervising/candidate-in-list-test.js b/certif/tests/unit/components/session-supervising/candidate-in-list-test.js
@@ -1,4 +1,5 @@
 import Service from '@ember/service';
+import { t } from 'ember-intl/test-support';
 import { setupTest } from 'ember-qunit';
 import { module, test } from 'qunit';
 import sinon from 'sinon';
@@ -38,32 +39,59 @@ module('Unit | Component | session-supervising/candidate-in-list', function (hoo
       });
     });
 
-    module('when there is an error', function () {
-      test('it should call the notification service', async function (assert) {
+    module('when there is an error', function (hooks) {
+      let adapter, component;
+
+      hooks.beforeEach(function () {
         // given
-        const subcategory = 'EMBED_NOT_WORKING';
-        const component = createGlimmerComponent('component:session-supervising/candidate-in-list');
+        class IntlStub extends Service {
+          t = sinon.stub();
+        }
+
+        this.owner.register('service:intl', IntlStub);
+
+        component = createGlimmerComponent('component:session-supervising/candidate-in-list');
         component.args.sessionId = 123;
         component.args.candidate = { userId: 456 };
         component.pixToast = { sendErrorNotification: sinon.spy() };
         const store = this.owner.lookup('service:store');
-        const adapter = store.adapterFor('session-management');
+        adapter = store.adapterFor('session-management');
         adapter.validateLiveAlert = sinon.stub();
-        adapter.validateLiveAlert.rejects();
-
-        class IntlStub extends Service {
-          t = sinon.stub();
-        }
+      });
 
-        this.owner.register('service:intl', IntlStub);
+      test('it should call the notification service', async function (assert) {
+        // given
+        adapter.validateLiveAlert.rejects({ errors: [{}] });
 
         // when
-        await component.validateLiveAlert(subcategory);
+        await component.validateLiveAlert('EMBED_NOT_WORKING');
 
         // then
-        sinon.assert.calledOnce(component.pixToast.sendErrorNotification);
+        sinon.assert.calledOnceWithExactly(component.pixToast.sendErrorNotification, {
+          message: t(
+            'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.miscellaneous',
+          ),
+        });
         assert.ok(true);
       });
+
+      module('when there is a ALREADY_ANSWERED_ERROR error', function () {
+        test('it should call the notification service with the request error message', async function (assert) {
+          // given
+          adapter.validateLiveAlert.rejects({ errors: [{ code: 'ALREADY_ANSWERED_ERROR', detail: 'error message' }] });
+
+          // when
+          await component.validateLiveAlert('EMBED_NOT_WORKING');
+
+          // then
+          sinon.assert.calledOnceWithExactly(component.pixToast.sendErrorNotification, {
+            message: t(
+              'pages.session-supervising.candidate-in-list.handle-live-alert-modal.error-handling.challenge-already-answered',
+            ),
+          });
+          assert.ok(true);
+        });
+      });
     });
   });
 
diff --git a/certif/translations/en.json b/certif/translations/en.json
@@ -486,7 +486,10 @@
             "dismiss-alert-button": "Refuser le signalement",
             "validate-alert-button": "Valider le signalement"
           },
-          "error-handling-live-alert": "Une erreur a eu lieu. Merci de réessayer ultérieurement.",
+          "error-handling": {
+            "challenge-already-answered": "The candidate has already answered this question. This alert will therefore be ignored.",
+            "miscellaneous": "An error occured. Please try again later."
+          },
           "handled": {
             "close-button-label": "Fermer la fenêtre de confirmation",
             "close-button-text": "Fermer",
diff --git a/certif/translations/fr.json b/certif/translations/fr.json
@@ -486,7 +486,10 @@
             "dismiss-alert-button": "Refuser le signalement",
             "validate-alert-button": "Valider le signalement"
           },
-          "error-handling-live-alert": "Une erreur a eu lieu. Merci de réessayer ultérieurement.",
+          "error-handling": {
+            "challenge-already-answered": "Le candidat a répondu à cette question. Cette alerte sera ignorée.",
+            "miscellaneous": "Une erreur a eu lieu. Merci de réessayer ultérieurement."
+          },
           "handled": {
             "close-button-label": "Fermer la fenêtre de confirmation",
             "close-button-text": "Fermer",

Original file line number	Diff line number	Diff line change
`@@ -1,8 +1,8 @@`
`1`	`1`	`import { DomainError } from '../../../shared/domain/errors.js';`
`2`	`2`
`3`	`3`	`class ChallengeAlreadyAnsweredError extends DomainError {`
`4`		`- constructor(message) {`
`5`		`- super(message);`
	`4`	`+ constructor() {`
	`5`	`+ super('La question a déjà été répondue.', 'ALREADY_ANSWERED_ERROR');`
`6`	`6`	`}`
`7`	`7`	`}`
`8`	`8`