refactor: deprecate-array-prototype-extensions - findBy()

Author: bpetetot

admin/app/components/organizations/information-section-view.gjs

@@ -43,9 +43,8 @@ export default class OrganizationInformationSection extends Component {
   get identityProviderName() {
     const GARIdentityProvider = { code: 'GAR', organizationName: 'GAR' };
     const allIdentityProviderList = [...this.oidcIdentityProviders.list, GARIdentityProvider];
-    const identityProvider = allIdentityProviderList.findBy(
-      'code',
-      this.args.organization.identityProviderForCampaigns,
+    const identityProvider = allIdentityProviderList.find(
+      (identityProvider) => identityProvider.code === this.args.organization.identityProviderForCampaigns,
     );
     const identityProviderName = identityProvider?.organizationName;
     return identityProviderName ?? 'Aucun';

admin/app/controllers/authenticated/organizations/get/team.js

@@ -45,7 +45,7 @@ export default class GetTeamController extends Controller {
     const emailInLowerCase = email.toLowerCase();
     const matchingUsers = await this.store.query('user', { filter: { email: emailInLowerCase } });
     // GET /users?filter[email] makes an approximative request ("LIKE %email%") and not a strict request
-    return matchingUsers.findBy('email', emailInLowerCase);
+    return matchingUsers.find((user) => user.email === emailInLowerCase);
   }
 
   @action

admin/app/controllers/authenticated/users/get/authentication-methods.js

@@ -25,8 +25,13 @@ export default class UserAuthenticationMethodsController extends Controller {
 
   @action
   async reassignAuthenticationMethod({ targetUserId, identityProvider }) {
-    const authenticationMethod = this.model.authenticationMethods.findBy('identityProvider', identityProvider);
-    const oidcIdentityProvider = this.oidcIdentityProviders.list.findBy('code', identityProvider);
+    const authenticationMethod = this.model.authenticationMethods.find(
+      (authenticationMethod) => authenticationMethod.identityProvider === identityProvider,
+    );
+    const oidcIdentityProvider = this.oidcIdentityProviders.list.find(
+      (oidcIdentityProvider) => oidcIdentityProvider.code === identityProvider,
+    );
+
     const reassignedAuthenticationMethodLabel = oidcIdentityProvider
       ? oidcIdentityProvider.organizationName
       : 'Médiacentre';

admin/app/models/organization.js

@@ -63,7 +63,7 @@ export default class Organization extends Model {
 
   async hasMember(userId) {
     const memberships = await this.organizationMemberships;
-    return !!memberships.findBy('user.id', userId);
+    return memberships.some((membership) => membership.user?.id === userId);
   }
 
   get archivedFormattedDate() {

admin/app/models/training.js

@@ -45,12 +45,12 @@ export default class Training extends Model {
 
   get prerequisiteTrigger() {
     const trainingTriggers = this.hasMany('trainingTriggers').value() || [];
-    return trainingTriggers.findBy('type', 'prerequisite');
+    return trainingTriggers.find((trigger) => trigger.type === 'prerequisite');
   }
 
   get goalTrigger() {
     const trainingTriggers = this.hasMany('trainingTriggers').value() || [];
-    return trainingTriggers.findBy('type', 'goal');
+    return trainingTriggers.find((trigger) => trigger.type === 'goal');
   }
 
   get sortedTargetProfileSummaries() {