fix(maddo): register applications token route in maddo server

Co-authored-by: Ce que tu veux <guillaume.lagorce@pix.fr>
Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>

Author: 3 people

api/server.maddo.js

@@ -4,8 +4,8 @@ import { parse } from 'neoqs';
 
 import { setupErrorHandling } from './config/server-setup-error-handling.js';
 import { knex } from './db/knex-database-connection.js';
-import * as authenticationRoutes from './lib/application/authentication/index.js';
 import { authentication } from './lib/infrastructure/authentication.js';
+import { identityAccessManagementRoutes } from './src/identity-access-management/application/routes.js';
 import * as replicationRoutes from './src/maddo/application/replications-routes.js';
 import { Metrics } from './src/monitoring/infrastructure/metrics.js';
 import * as healthcheckRoutes from './src/shared/application/healthcheck/index.js';
@@ -179,7 +179,13 @@ const setupAuthentication = function (server) {
 };
 
 const setupRoutesAndPlugins = async function (server) {
-  await server.register([...plugins, healthcheckRoutes, authenticationRoutes, replicationRoutes]);
+  const routes = [healthcheckRoutes, ...identityAccessManagementRoutes, replicationRoutes];
+  const routesWithOptions = routes.map((route) => ({
+    plugin: route,
+    options: { tags: ['maddo'] },
+  }));
+
+  await server.register([...plugins, ...routesWithOptions]);
 };
 
 const setupOpenApiSpecification = async function (server) {

api/src/identity-access-management/application/routes.js

@@ -9,20 +9,30 @@ import { tokenRoutes } from './token/token.route.js';
 import { userAdminRoutes } from './user/user.admin.route.js';
 import { userRoutes } from './user/user.route.js';
 
-const register = async function (server) {
-  server.route([
-    ...accountRecoveryRoutes,
-    ...anonymizationAdminRoutes,
-    ...ltiRoutes,
-    ...oidcProviderAdminRoutes,
-    ...oidcProviderRoutes,
-    ...passwordRoutes,
-    ...samlRoutes,
-    ...tokenRoutes,
-    ...userAdminRoutes,
-    ...userRoutes,
-  ]);
-};
+const allRoutes = [
+  ...accountRecoveryRoutes,
+  ...anonymizationAdminRoutes,
+  ...ltiRoutes,
+  ...oidcProviderAdminRoutes,
+  ...oidcProviderRoutes,
+  ...passwordRoutes,
+  ...samlRoutes,
+  ...tokenRoutes,
+  ...userAdminRoutes,
+  ...userRoutes,
+];
+
+function register(server, { routes = allRoutes, tags }) {
+  if (!tags) {
+    server.route(routes);
+    return;
+  }
+
+  const filteredRoutes = routes.filter((route) =>
+    (route.config ?? route.options).tags.some((tag) => tags.includes(tag)),
+  );
+  server.route(filteredRoutes);
+}
 
 const name = 'identity-access-management-api';
 

api/src/identity-access-management/application/token/token.route.js

@@ -46,7 +46,7 @@ export const tokenRoutes = [
         },
       },
       handler: tokenController.authenticateApplication,
-      tags: ['api', 'authorization-server', 'parcoursup'],
+      tags: ['api', 'authorization-server', 'parcoursup', 'maddo'],
     },
   },
   {

api/tests/identity-access-management/unit/application/routes.test.js

@@ -0,0 +1,51 @@
+import { identityAccessManagementRoutes } from '../../../../src/identity-access-management/application/routes.js';
+import { expect, sinon } from '../../../test-helper.js';
+
+describe('Unit | Identity Access Management | Application | Routes', function () {
+  let routes;
+  let server;
+
+  beforeEach(function () {
+    routes = [
+      { config: { tags: ['tag1', 'tag2'] } },
+      { config: { tags: ['tag3'] } },
+      { options: { tags: ['tag3'] } },
+      { options: { tags: ['tag4'] } },
+      { options: { tags: ['tag2', 'tag5'] } },
+    ];
+
+    server = {
+      route: sinon.stub(),
+    };
+  });
+
+  context('when no tags are given', function () {
+    it('registers all routes', function () {
+      // given
+      const options = { routes, tags: undefined };
+
+      // when
+      identityAccessManagementRoutes[0].register(server, options);
+
+      // then
+      expect(server.route).to.have.been.calledOnceWith(routes);
+    });
+  });
+
+  context('when tags are given', function () {
+    it('registers routes having at least one of the tags', function () {
+      // given
+      const options = { routes, tags: ['tag2', 'tag4'] };
+
+      // when
+      identityAccessManagementRoutes[0].register(server, options);
+
+      // then
+      expect(server.route).to.have.been.calledOnceWith([
+        { config: { tags: ['tag1', 'tag2'] } },
+        { options: { tags: ['tag4'] } },
+        { options: { tags: ['tag2', 'tag5'] } },
+      ]);
+    });
+  });
+});