[FEATURE] Interdire les feedbacks globaux dans les QCU (PIX-17119)

 #11769

Author: pix-service-auto-merge

api/src/devcomp/domain/models/element/QCU-for-answer-verification.js

@@ -3,25 +3,20 @@ import Joi from 'joi';
 import { EntityValidationError } from '../../../../shared/domain/errors.js';
 import { assertNotNullOrUndefined } from '../../../../shared/domain/models/asserts.js';
 import { ModuleInstantiationError } from '../../errors.js';
-import { Feedbacks } from '../Feedbacks.js';
 import { QcuCorrectionResponse } from '../QcuCorrectionResponse.js';
 import { ValidatorQCU } from '../validator/ValidatorQCU.js';
 import { QCU } from './QCU.js';
 
 class QCUForAnswerVerification extends QCU {
   userResponse;
-  constructor({ id, instruction, locales, proposals, solution, feedbacks, validator }) {
+  constructor({ id, instruction, locales, proposals, solution, validator }) {
     super({ id, instruction, locales, proposals });
 
     assertNotNullOrUndefined(solution, 'The solution is required for a verification QCU');
     this.#assertSolutionIsAnExistingProposal(solution, proposals);
 
     this.solution = { value: solution };
 
-    if (feedbacks) {
-      this.feedbacks = new Feedbacks(feedbacks);
-    }
-
     if (validator) {
       this.validator = validator;
     } else {
@@ -46,7 +41,7 @@ class QCUForAnswerVerification extends QCU {
 
     return new QcuCorrectionResponse({
       status: validation.result,
-      feedback: this.#getFeedback(validation),
+      feedback: this.#getFeedback(),
       solution: this.solution.value,
     });
   }
@@ -71,13 +66,8 @@ class QCUForAnswerVerification extends QCU {
     }
   }
 
-  #getFeedback(validation) {
-    const specificFeedback = this.#getSpecificFeedbackByProposalId(this.userResponse);
-    if (specificFeedback) {
-      return specificFeedback;
-    }
-
-    return validation.result.isOK() ? this.feedbacks.valid : this.feedbacks.invalid;
+  #getFeedback() {
+    return this.#getSpecificFeedbackByProposalId(this.userResponse);
   }
 }
 

api/src/devcomp/infrastructure/datasources/learning-content/samples/elements/qcu.sample.js

@@ -8,11 +8,8 @@ export function getQcuSample(nbOfProposals = 3) {
     proposals: Array.from(Array(nbOfProposals)).map((_, i) => ({
       id: `${i + 1}`,
       content: `Proposition ${i + 1}`,
+      feedback: `<p>Correct ! ${i + 1}</p>`,
     })),
-    feedbacks: {
-      valid: '<p>Correct !</p>',
-      invalid: '<p>Incorrect !</p>',
-    },
     solution: '1',
   };
 }

api/src/devcomp/infrastructure/factories/element-for-verification-factory.js

@@ -50,7 +50,6 @@ export class ElementForVerificationFactory {
           feedback: proposal.feedback,
         });
       }),
-      feedbacks: element.feedbacks,
       solution: element.solution,
     });
   }