Skip to content

Commit de19255

Browse files
committed
test(api): remove userId/snappedAt from buildSnapshot in test
1 parent 48a0794 commit de19255

File tree

5 files changed

+4
-17
lines changed

5 files changed

+4
-17
lines changed

api/db/database-builder/factory/knowledge-elements-snapshot-factory.js

+1-3
Original file line numberDiff line numberDiff line change
@@ -1,13 +1,11 @@
11
import { databaseBuffer } from '../database-buffer.js';
22
import { buildKnowledgeElement } from './build-knowledge-element.js';
33

4-
function buildSnapshot({ id, userId, snappedAt, knowledgeElementsAttributes, campaignParticipationId }) {
4+
function buildSnapshot({ id, knowledgeElementsAttributes, campaignParticipationId }) {
55
const knowledgeElements = knowledgeElementsAttributes.map((attributes) => buildKnowledgeElement(attributes));
66

77
const values = {
88
id,
9-
userId,
10-
snappedAt,
119
snapshot: JSON.stringify(knowledgeElements),
1210
campaignParticipationId,
1311
};

api/tests/integration/scripts/prod/clean-ke-snapshots_test.js

+3-6
Original file line numberDiff line numberDiff line change
@@ -65,23 +65,20 @@ describe('Script | Prod | Clean knowledge-element-snapshot snapshot (jsonb)', fu
6565

6666
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
6767
id: 1,
68-
userId: user.id,
69-
snappedAt: participation.sharedAt,
7068
knowledgeElementsAttributes: [{ skillId: 'skill_1', status: 'validated', earnedPix: 40, userId: user.id }],
69+
campaignParticipationId: participation.id,
7170
});
7271
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
7372
id: 2,
74-
userId: user.id,
75-
snappedAt: participation2.sharedAt,
7673
knowledgeElementsAttributes: [{ skillId: 'skill_2', status: 'validated', earnedPix: 40, userId: user.id }],
74+
campaignParticipationId: participation2.id,
7775
});
7876
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
7977
id: 3,
80-
userId: user.id,
81-
snappedAt: participation3.sharedAt,
8278
knowledgeElementsAttributes: [
8379
{ skillId: 'skill_2', status: 'validated', earnedPix: 40, userId: null, assessmentId: null, answerId: null },
8480
],
81+
campaignParticipationId: participation3.id,
8582
});
8683

8784
await databaseBuilder.commit();

api/tests/integration/scripts/prod/compute-participation-results_test.js

-2
Original file line numberDiff line numberDiff line change
@@ -250,8 +250,6 @@ function _buildParticipationWithSnapshot(participationAttributes, knowledgeEleme
250250
const participation = databaseBuilder.factory.buildCampaignParticipation(participationAttributes);
251251

252252
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
253-
userId: participation.userId,
254-
snappedAt: participation.sharedAt,
255253
knowledgeElementsAttributes,
256254
campaignParticipationId: participation.id,
257255
});

api/tests/prescription/campaign-participation/integration/infrastructure/repositories/campaign-participation-result-repository_test.js

-4
Original file line numberDiff line numberDiff line change
@@ -131,8 +131,6 @@ describe('Integration | Repository | Campaign Participation Result', function ()
131131
},
132132
];
133133
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
134-
userId,
135-
snappedAt: new Date('2020-01-02'),
136134
knowledgeElementsAttributes,
137135
campaignParticipationId,
138136
});
@@ -193,8 +191,6 @@ describe('Integration | Repository | Campaign Participation Result', function ()
193191
];
194192

195193
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
196-
userId,
197-
snappedAt: new Date('2020-01-02'),
198194
knowledgeElementsAttributes,
199195
campaignParticipationId,
200196
});

api/tests/prescription/campaign-participation/integration/infrastructure/repositories/participant-results-shared-repository_test.js

-2
Original file line numberDiff line numberDiff line change
@@ -362,8 +362,6 @@ function _buildParticipationWithSnapshot(participationAttributes, knowledgeEleme
362362
const participation = databaseBuilder.factory.buildCampaignParticipation(participationAttributes);
363363

364364
databaseBuilder.factory.knowledgeElementSnapshotFactory.buildSnapshot({
365-
userId: participation.userId,
366-
snappedAt: participation.sharedAt,
367365
knowledgeElementsAttributes,
368366
campaignParticipationId: participation.id,
369367
});

0 commit comments

Comments
 (0)