Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Migrer la route de mise à jour Has Seen Assessment Instructions (PIX-14725). #10677

Conversation

Libouk
Copy link
Member

@Libouk Libouk commented Nov 28, 2024

🦄 Problème

Migrer la route d'update de la valeur Has Seen Assessment Instructions.

🤖 Proposition

Migrer la route d'update de la valeur Has Seen Assessment Instructions.

🌈 Remarques

Deuxième PR sur la même branche pour solutionner des problèmes de déploiement.

💯 Pour tester

  • Se rendre sur Pix Orga et créer une campagne avec un centre PRO
  • Créer un compte
  • Accéder à la campagne nouvellement créée
  • Vérifier que le tutoriel s'affiche en début de campagne
  • Cliquer sur le bouton Ignorer, ce qui aura pour effet de basculer la valeur Has Seen Assessment Instructions à true (peut se vérifier dans les données Ember)
  • Quitter et relancer la campagne, le tutoriel ne doit pas s'afficher

@Libouk Libouk added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally team-evaluation PR relatives à l'expérience d'évaluation labels Nov 28, 2024
@Libouk Libouk self-assigned this Nov 28, 2024
@Libouk Libouk requested review from a team as code owners November 28, 2024 15:25
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@Libouk
Copy link
Member Author

Libouk commented Nov 28, 2024

Tester le usecase de l'API interne en intégration

@Libouk
Copy link
Member Author

Libouk commented Nov 28, 2024

Rajouter un test d'acceptance sur la route Edit: Test déjà existant "Acceptance | Controller | users-controller-remember-user-has-seen-assessment-instructions"

@Libouk Libouk force-pushed the pix-14725-move-has-seen-assessment-instructions-route branch 2 times, most recently from 0042747 to 4d68200 Compare December 2, 2024 17:04
Copy link
Contributor

@er-lim er-lim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lu et testé en RA ✅

@Libouk Libouk added Tech Review OK Func Review OK PO validated functionally the PR 🚀 Ready to Merge and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Dec 4, 2024
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-14725-move-has-seen-assessment-instructions-route branch from 4d68200 to be3d8ea Compare December 4, 2024 13:42
@pix-service-auto-merge pix-service-auto-merge merged commit 7a83571 into dev Dec 4, 2024
7 of 9 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-14725-move-has-seen-assessment-instructions-route branch December 4, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-evaluation PR relatives à l'expérience d'évaluation Tech Review OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants