Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] ajoute la méthode findSnapshotByCampaignParticipationId (PIX-16339) #11284

Conversation

lionelB
Copy link
Member

@lionelB lionelB commented Jan 30, 2025

🥞 Problème

Dans le cadre de l'accès au knowledge-element-snapshots avec le campaignId;
on souhaite éviter d'utiliser findSnapshotBuUserId qui mélange récupération des snapshot et des ke ) partir du userId
vu qu'on ne pourra plus récupérer les snapshot qu'avec un campaignParticipationId

🥓 Proposition

On ajoute une méthode pour récupérer les snapshot depuis un campaignParticipationId et on met à jour la où sont récupérer les snapshots pour utiliser un campaignParticiaptionId

Là où on attend que des résultats de knowledgeElements remontent sans qu'ils soient liés à une participation partagée, on va chercher les knowledge elements directement (sans faire un appel préalable aux snapshots, comme on faisait auparavant). Routes concernées :
/api/campaigns/{campaignId}/profiles-collection-participations/{campaignParticipationId}
'/api/campaigns/{campaignId}/assessment-participations/{campaignParticipationId}'
/api/campaigns/{campaignId}/assessment-participations/{campaignParticipationId}/results

🧃 Remarques

C'est essentiellement du refacto, on souhaite modifier à minima les tests (pour rajouter un campaignParticipationId au snapshots)

😋 Pour tester

RAS

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@lionelB lionelB force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch from ad36fc0 to 710280a Compare January 30, 2025 15:38
@alicegoarnisson alicegoarnisson force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch 4 times, most recently from 7d70f28 to 0cb19c2 Compare January 31, 2025 13:40
@La-toile-cosmique La-toile-cosmique force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch from 408df7b to 96b9f0f Compare February 3, 2025 14:50
@alicegoarnisson alicegoarnisson force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch from e0022db to fe6aae2 Compare February 4, 2025 10:02
@La-toile-cosmique La-toile-cosmique force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch 2 times, most recently from 4681ec6 to 8aa0641 Compare February 4, 2025 13:42
@La-toile-cosmique La-toile-cosmique marked this pull request as ready for review February 4, 2025 13:44
@La-toile-cosmique La-toile-cosmique requested a review from a team as a code owner February 4, 2025 13:44
@La-toile-cosmique La-toile-cosmique force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch 4 times, most recently from bfe3898 to 8cb4682 Compare February 4, 2025 14:30
Copy link
Contributor

@La-toile-cosmique La-toile-cosmique left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@machestla machestla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tech review ok ✅

@pix-service-auto-merge pix-service-auto-merge force-pushed the PIX-16339/create-find-snapshot-by-campaign-participation-id branch from fdb12d1 to 4672dd8 Compare February 5, 2025 09:59
@pix-service-auto-merge pix-service-auto-merge merged commit 4822cc2 into dev Feb 5, 2025
8 of 10 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the PIX-16339/create-find-snapshot-by-campaign-participation-id branch February 5, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants