Skip to content

[FEATURE] Affiche tous les badges du PC (Pix-16352) #11417

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Feb 19, 2025

Conversation

lionelB
Copy link
Member

@lionelB lionelB commented Feb 13, 2025

🥞 Problème

On souhaite ajouter un filtre sur les badge non acquis mais ceux-ci ne s'affiche pas.

🥓 Proposition

On affiche les badges non acquis et on les différencie visuellement et avec un contenu texte (tooltip)

🧃 Remarques

On modifie les seed pour avoir plus de badge et que les acquisitions soient corrélées avec les scores

😋 Pour tester

  • Allez sur orga (SCO_SIECLE_MANAGING)
  • afficher les résultats de la campagnes SCOASSIMP
  • voir les badges non acquis (grisé) et vérifier le contenu du tootlip

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@lionelB lionelB force-pushed the pix-16352/display-unacquired-badges branch 2 times, most recently from 634fa06 to 9017b42 Compare February 18, 2025 15:27
@lionelB lionelB added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress labels Feb 18, 2025
@lionelB lionelB force-pushed the pix-16352/display-unacquired-badges branch from 9017b42 to 4a15066 Compare February 18, 2025 15:50
@Alexandre-Monney Alexandre-Monney marked this pull request as ready for review February 19, 2025 09:14
Copy link
Contributor

@Alexandre-Monney Alexandre-Monney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🐈‍⬛

@Alexandre-Monney
Copy link
Contributor

Func ok sur Chrome :
image

@Alexandre-Monney
Copy link
Contributor

Func ok sur Firefox également :
image

@lionelB lionelB force-pushed the pix-16352/display-unacquired-badges branch 5 times, most recently from 9fee6d5 to e4f7f5b Compare February 19, 2025 13:41
@Alexandre-Monney Alexandre-Monney changed the title [FEAT] affiche tout les badges du PC (Pix-16352) [FEATURE] affiche tout les badges du PC (Pix-16352) Feb 19, 2025
@Alexandre-Monney Alexandre-Monney changed the title [FEATURE] affiche tout les badges du PC (Pix-16352) [FEATURE] Affiche tous les badges du PC (Pix-16352) Feb 19, 2025
Copy link
Contributor

@machestla machestla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tech review ok ✅ 🐕

@machestla machestla added Tech Review OK Func Review OK PO validated functionally the PR and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Feb 19, 2025
For no we only take into account masteryRate and not
masteryRate on cappedTube since its a bit more complicated
to address in seeds
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-16352/display-unacquired-badges branch from e4f7f5b to 2b7304b Compare February 19, 2025 16:21
@pix-service-auto-merge pix-service-auto-merge merged commit fda85a8 into dev Feb 19, 2025
8 of 11 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-16352/display-unacquired-badges branch February 19, 2025 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants