[FEATURE] Migrer les applications en BDD (PIX-16590). #11434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VincentHardouin
added
👀 Tech Review Needed
team-acces
team-maddo
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
VincentHardouin
force-pushed
the
pix-16590-migrate-applications-in-database
branch
from
4ae0228 to
3e9648c
Compare
pix-service-auto-merge
force-pushed
the
prepare-maddo-authentication-config
branch
from
61b5d38 to
3c10f7e
Compare
bpetetot
reviewed
Feb 18, 2025
nlepage
force-pushed
the
pix-16590-migrate-applications-in-database
branch
3 times, most recently
from
65bf00d to
508b25c
Compare
nlepage
force-pushed
the
pix-16590-migrate-applications-in-database
branch
from
508b25c to
8233dd9
Compare
nlepage
approved these changes
Feb 18, 2025
HEYGUL
approved these changes
Feb 18, 2025
HEYGUL
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Nicolas Lepage <19571875+nlepage@users.noreply.github.com>
Co-authored-by: Guillaume Lagorce <guillaume.lagorce@pix.fr> Co-authored-by: Nicolas Lepage <19571875+nlepage@users.noreply.github.com>
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr> Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Ce que tu veux <guillaume.lagorce@pix.fr> Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
pix-service-auto-merge
force-pushed
the
pix-16590-migrate-applications-in-database
branch
from
8233dd9 to
8f41d95
Compare
pix-service-auto-merge
deleted the
pix-16590-migrate-applications-in-database
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Actuellement, toutes les applications sont définies directement dans la configuration grâce à des variables d'environnement. C'est par conséquent chronophage d'ajouter de nouveau client et ce n'est pas très scalable.
🥓 Proposition
Stocker les applications en BDD.
🧃 Remarques
AUTH_SECRETpour signer les jwt des clients au lieu d'avoir un SECRET par client.😋 Pour tester