[TECH] Déplacer le domaine parcoursup dans certification/results (PIX-16604). #11442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
Jeyffrey
force-pushed
the
pix-16604-migrate-parcoursup-domain-to-certification-results-sub-domain
branch
2 times, most recently
from
998d1f0 to
b8f8f88
Compare
Steph0
force-pushed
the
pix-16604-migrate-parcoursup-domain-to-certification-results-sub-domain
branch
from
b8f8f88 to
16e417d
Compare
Steph0
approved these changes
Feb 18, 2025
| @@ -1,9 +1,9 @@ | |||
| import { usecases } from '../domain/usecases/index.js'; | |||
|
|
|||
| const getCertificationResult = async function (request) { | |||
| const getCertificationResultForParcoursup = async function (request) { | |||
There was a problem hiding this comment.
Suggested change
| const getCertificationResultForParcoursup = async function (request) { | |
| const getParcoursupResult = async function (request) { |
| * | ||
| * @returns {CertificationResult} matching candidate certification result | ||
| * @throws {MoreThanOneMatchingCertificationError} in some cases (INE for example) there might be duplicates | ||
| * @throws {NotFoundError} if no certification exists for this candidate | ||
| **/ | ||
| export const getCertificationResult = async ({ | ||
| export const getCertificationResultForParcoursup = async ({ |
There was a problem hiding this comment.
On sait deja que on est dans des resultats de certif
Suggested change
| export const getCertificationResultForParcoursup = async ({ | |
| export const getResultForParcoursup = async ({ |
Steph0
added
Func Review OK
|
Allez on est 3 a etre OK |
pix-service-auto-merge
deleted the
pix-16604-migrate-parcoursup-domain-to-certification-results-sub-domain
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
Il n'y a pas d'intérêt à avoir un domaine métier particulier pour
parcoursup.Parcoursup est un format de resultat, et nous avons deja tout un contexte dedie au partage de resultats de certification.
🥓 Proposition
Déplacer ce domaine dans le sous-domaine
certification/results.😋 Pour tester