[TECH] Suppression du token d’accès aux résultats de campagne (PIX-16610) #11443
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nlepage
added
👀 Tech Review Needed
👀 Func Review Needed
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
bpetetot
approved these changes
Feb 18, 2025
HEYGUL
approved these changes
Feb 18, 2025
VincentHardouin
approved these changes
Feb 18, 2025
lego-technix
approved these changes
Feb 18, 2025
machestla
approved these changes
Feb 18, 2025
|
Func & Tech review ok ✅ |
nlepage
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-16610-remove-campaign-results-token
branch
from
3a55ad7 to
9aed4ff
Compare
pix-service-auto-merge
deleted the
pix-16610-remove-campaign-results-token
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🥞 Problème
À chaque fois qu’une campagne est récupérée dans PixOrga, un token d’accès aux résultats de campagne est généré, mais ce token n’est plus utilisé par PixOrga.
🥓 Proposition
Supprimer le token.
🧃 Remarques
La route de récupération des résultats de campagne est
GET /api/campaigns/{campaignId}/csv-assessment-results.La variable d’environnement
CAMPAIGN_RESULT_ACCESS_TOKEN_LIFESPANpourra être supprimée sur les différents environnements.😋 Pour tester
Vérifier qu’on peut toujours télécharger les résultats CSV d’une campagne depuis PixOrga.