Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Améliorer le style de la page de détail de compétence (PIX-16882). #11600

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions mon-pix/app/components/circle-chart.hbs
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
<div class="circle-chart" ...attributes>
<svg viewBox="1.2 1.2 33.6 33.6" class={{concat "circle-chart__content " @chartClass}} aria-hidden="true">
<div class={{concat "circle-chart " @chartClass}} ...attributes>
<svg class="cicle-chart__circle" viewBox="1.2 1.2 33.6 33.6" aria-hidden="true">
<path class={{concat "circle " @thicknessClass}} d="M18 2 a 16 16 0 0 1 0 32 a 16 16 0 0 1 0 -32">
</path>

Expand Down
2 changes: 1 addition & 1 deletion mon-pix/app/components/competence-card-default.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@
<CircleChart
@value={{@scorecard.capedPercentageAheadOfNextLevel}}
@sliceColor={{@scorecard.area.color}}
@chartClass="circle-chart__content--big"
@chartClass="circle-chart--big"
@thicknessClass="circle--thick"
role="presentation"
>
Expand Down
2 changes: 1 addition & 1 deletion mon-pix/app/components/competence-card-mobile.hbs
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
<CircleChart
@value={{@scorecard.capedPercentageAheadOfNextLevel}}
@sliceColor={{@scorecard.area.color}}
@chartClass="circle-chart__content--small"
@chartClass="circle-chart--small"
@thicknessClass="circle--thick"
role="presentation"
>
Expand Down
115 changes: 61 additions & 54 deletions mon-pix/app/components/scorecard-details.hbs
Original file line number Diff line number Diff line change
@@ -1,27 +1,28 @@
<div>
<div class="scorecard-details__header">
<PixButtonLink @route="authenticated.profile" @variant="tertiary" @iconBefore="arrowLeft">
<section class="scorecard-details__header">
<PixButtonLink
@route="authenticated.profile"
@variant="tertiary"
@iconBefore="arrowLeft"
class="scorecard-details-header__back-button"
>
{{t "navigation.back-to-profile"}}
</PixButtonLink>
</div>
</section>

<div class="scorecard-details__content">
<div class="scorecard-details-content__left">
<div class="scorecard-details-content-left__area scorecard-details-content-left__area--{{@scorecard.area.color}}">
{{@scorecard.area.title}}
</div>
<h1 class="scorecard-details-content-left__name">
<section class="scorecard-details__competence">
<div class="scorecard-details-competence__details">
<h1 class="scorecard-details-competence-details__name">
{{@scorecard.name}}
</h1>
<div class="scorecard-details-content-left__description">
<div class="scorecard-details-competence-details__description">
{{@scorecard.description}}
</div>
</div>

<div class="scorecard-details-content__right">

<div class="scorecard-details-content__score">
{{#if @scorecard.isFinished}}
<div class="scorecard-details-content-right__score-container">
<div class="scorecard-details-content-score__score-container">
{{#if this.displayCongrats}}
<div class="competence-card__congrats">
<div class="competence-card__level competence-card__level--congrats">
Expand All @@ -35,7 +36,7 @@
<CircleChart
@value={{@scorecard.capedPercentageAheadOfNextLevel}}
@sliceColor={{@scorecard.area.color}}
@chartClass="circle-chart__content--big"
@chartClass="circle-chart--big"
@thicknessClass="circle--thick"
role="img"
aria-label="{{scorecard-aria-label @scorecard}}"
Expand All @@ -47,36 +48,37 @@
</CircleChart>
{{/if}}

<div class="scorecard-details-content-right-score-container__pix-earned">
<div class="pix-earned">
<div class="score-label">{{t "common.pix"}}</div>
<div class="score-value">{{replace-zero-by-dash @scorecard.earnedPix}}</div>
</div>
</div>

{{#if this.displayImprovingWaitSentence}}
<div class="scorecard-details__improvement-countdown">
<span class="scorecard-details-improvement-countdown__label">{{t
<div class="scorecard-details-improvement-countdown__label">{{t
"pages.competence-details.actions.improve.description.waiting-text"
}}</span>
<span class="scorecard-details-improvement-countdown__count">{{t
}}</div>
<strong class="scorecard-details-improvement-countdown__count">{{t
"pages.competence-details.actions.improve.description.countdown"
daysBeforeImproving=@scorecard.remainingDaysBeforeImproving
}}</span>
}}</strong>
</div>
{{/if}}

{{#if this.displayImprovingButton}}
<PixButton
class="scorecard-details__improve-button button--big"
class="scorecard-details__improve-button"
@variant="success"
@size="large"
@triggerAction={{this.improveCompetenceEvaluation}}
>
{{t "pages.competence-details.actions.improve.label"}}
<span class="sr-only">{{t "pages.competence-details.for-competence" competence=@scorecard.name}}</span>
</PixButton>
<span class="scorecard-details__improving-text">{{t
<div class="scorecard-details__improving-text">{{t
"pages.competence-details.actions.improve.improvingText"
}}</span>
}}</div>
{{/if}}

{{#if this.displayResetButton}}
Expand All @@ -92,19 +94,19 @@
{{/if}}

{{#if this.displayResetWaitSentence}}
<p class="scorecard-details-content-right__reset-message">{{t
<p class="scorecard-details-content-score__reset-message">{{t
"pages.competence-details.actions.reset.description"
daysBeforeReset=@scorecard.remainingDaysBeforeReset
}}</p>
{{/if}}
{{/if}}

{{#if @scorecard.isStarted}}
<div class="scorecard-details-content-right__score-container">
<div class="scorecard-details-content-score__score-container">
<CircleChart
@value={{@scorecard.capedPercentageAheadOfNextLevel}}
@sliceColor={{@scorecard.area.color}}
@chartClass="circle-chart__content--big"
@chartClass="circle-chart--big"
@thicknessClass="circle--thick"
role="img"
aria-label="{{scorecard-aria-label @scorecard}}"
Expand All @@ -115,14 +117,14 @@
</div>
</CircleChart>

<div class="scorecard-details-content-right-score-container__pix-earned">
<div class="pix-earned">
<div class="score-label">{{t "common.pix"}}</div>
<div class="score-value">{{replace-zero-by-dash @scorecard.earnedPix}}</div>
</div>
</div>

{{#if this.displayRemainingPixToNextLevel}}
<div class="scorecard-details-content-right__level-info">
<div class="scorecard-details-content-score__level-info">
{{t
"pages.competence-details.next-level-info"
remainingPixToNextLevel=@scorecard.remainingPixToNextLevel
Expand All @@ -131,14 +133,15 @@
</div>
{{/if}}

<LinkTo
<PixButtonLink
class="scorecard-details__resume-button"
@route="authenticated.competences.resume"
@model={{@scorecard.competenceId}}
class="button button--big button--thin button--round button--link button--green scorecard-details__resume-or-start-button"
@size="large"
>
{{t "pages.competence-details.actions.continue.label"}}
<span class="sr-only">{{t "pages.competence-details.for-competence" competence=@scorecard.name}}</span>
</LinkTo>
</PixButtonLink>

{{#if this.displayResetButton}}
<PixButton
Expand All @@ -153,47 +156,51 @@
{{/if}}

{{#if this.displayResetWaitSentence}}
<p class="scorecard-details-content-right__reset-message">{{t
<p class="scorecard-details-content-score__reset-message">{{t
"pages.competence-details.actions.reset.description"
daysBeforeReset=@scorecard.remainingDaysBeforeReset
}}</p>
{{/if}}
{{/if}}

{{#if @scorecard.isNotStarted}}
<LinkTo
<PixButtonLink
class="scorecard-details__start-button"
@route="authenticated.competences.resume"
@model={{@scorecard.competenceId}}
class="button button--big button--thin button--round button--link button--green scorecard-details__resume-or-start-button"
@size="large"
@variant="success"
>
{{t "pages.competence-details.actions.start.label"}}
<span class="sr-only">{{t "pages.competence-details.for-competence" competence=@scorecard.name}}</span>
</LinkTo>
</PixButtonLink>
{{/if}}
</div>
</div>
</section>

{{#if this.tutorialsGroupedByTubeName}}
<div class="scorecard-details__content">
<div class="tutorials">
<div class="tutorials__header">
<h2 class="tutorials-header__title">{{t "pages.competence-details.tutorials.title"}}</h2>
<p class="tutorials-header__description">{{t "pages.competence-details.tutorials.description"}}</p>
</div>
<div>
{{#each this.tutorialsGroupedByTubeName as |tube|}}
<div class="tube">
<h3 class="tube__title">{{tube.practicalTitle}}</h3>
<ul class="tube__content">
{{#each tube.tutorials as |tutorial|}}
<Tutorials::Card @tutorial={{tutorial}} />
{{/each}}
</ul>
</div>
{{/each}}
</div>
<section class="scorecard-details__tutorials">
<div class="scorecard-details-tutorials__header">
<h2 class="scorecard-details-tutorials-header__title">{{t "pages.competence-details.tutorials.title"}}</h2>
<p class="scorecard-details-tutorials-header__description">{{t
"pages.competence-details.tutorials.description"
}}</p>
</div>
</div>
<ul class="scorecard-details-tutorials__list">
{{#each this.tutorialsGroupedByTubeName as |tube|}}
<li class="tube">
<h3 class="tube__title">{{tube.practicalTitle}}</h3>
<ul class="tube__content">
{{#each tube.tutorials as |tutorial|}}
<Tutorials::Card @tutorial={{tutorial}} />
{{/each}}
</ul>
</li>
{{/each}}
</ul>
</section>
{{/if}}

</div>
<PixModal
@title={{t "pages.competence-details.actions.reset.modal.title" scoreCardName=@scorecard.name}}
Expand Down
20 changes: 8 additions & 12 deletions mon-pix/app/styles/components/_circle-chart.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,13 +7,8 @@

.circle-chart {
position: relative;
display: flex;
}

.circle-chart__content {
width: 100px;
height: 100px;
max-height: 128px;

&--small {
width: 70px;
Expand All @@ -26,6 +21,11 @@
}
}

.circle-chart__circle {
width: 100%;
height: 100%;
}

.circle {
fill: none;
stroke-width: 1.1;
Expand Down Expand Up @@ -64,11 +64,7 @@

.circle-chart__text {
position: absolute;
top: 0;
left: 0;
display: flex;
flex-direction: column;
justify-content: center;
width: 100%;
height: 100%;
top: 50%;
left: 50%;
transform: translate(-50%, -50%);
}
Loading
Loading