Skip to content

[BUGFIX] Mettre à jour et rajouter les attributs nécessaire sur la navbar de Pix app (PIX-16773) #11630

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 4, 2025
Merged

[BUGFIX] Mettre à jour et rajouter les attributs nécessaire sur la navbar de Pix app (PIX-16773) #11630

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b3207f1
chore(mon-pix): Update pix-ui
theotime2005 Apr 4, 2025
b6a945e
feat(mon-pix): update and fix navbar for pix app
theotime2005 Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion mon-pix/app/components/global/app-navigation.gjs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,12 @@ export default class AppNavigation extends Component {
}

<template>
<PixNavigation class="app-navigation" @navigationAriaLabel="navigation principale">
<PixNavigation
class="app-navigation"
@navigationAriaLabel="{{t 'navigation.nav-bar.aria-label'}}"
@openLabel="{{t 'navigation.nav-bar.open'}}"
@closeLabel="{{t 'navigation.nav-bar.close'}}"
>
<:brand>
{{#if this.isFrenchLocale}}
<img
Expand Down
8 changes: 4 additions & 4 deletions mon-pix/package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion mon-pix/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
"@1024pix/ember-testing-library": "^3.0.6",
"@1024pix/epreuves-components": "^0.1.0",
"@1024pix/eslint-plugin": "^2.1.1",
"@1024pix/pix-ui": "^55.11.0",
"@1024pix/pix-ui": "^55.11.1",
"@1024pix/stylelint-config": "^5.1.28",
"@babel/eslint-parser": "^7.25.1",
"@babel/plugin-proposal-decorators": "^7.24.7",
Expand Down
5 changes: 5 additions & 0 deletions mon-pix/translations/en.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,11 @@
"tutorials": "My tutorials"
},
"mobile-button-title": "Open menu",
"nav-bar": {
"aria-label": "main navigation",
"close": "Close navigation",
"open": "Open navigation"
},
"not-logged": {
"sign-in": "Log in",
"sign-up": "Sign up"
Expand Down
5 changes: 5 additions & 0 deletions mon-pix/translations/es.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,11 @@
"tutorials": "Mis tutoriales"
},
"mobile-button-title": "Abrir el menú",
"nav-bar": {
"aria-label": "navegación principal",
"close": "Cerrar la navegación",
"open": "Abrir la navegación"
},
"not-logged": {
"sign-in": "Conectarse",
"sign-up": "Inscribirse"
Expand Down
5 changes: 5 additions & 0 deletions mon-pix/translations/fr.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,11 @@
"tutorials": "Mes tutos"
},
"mobile-button-title": "Ouvrir le menu",
"nav-bar": {
"aria-label": "navigation principale",
"close": "Fermer la navigation",
"open": "Ouvrir la navigation"
},
"not-logged": {
"sign-in": "Se connecter",
"sign-up": "S'inscrire"
Expand Down
5 changes: 5 additions & 0 deletions mon-pix/translations/nl.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,6 +342,11 @@
"tutorials": "Mijn tutorials"
},
"mobile-button-title": "Open het menu",
"nav-bar": {
"aria-label": "hoofdnavigatie",
"close": "Sluit de navigatie",
"open": "Open navigatie"
},
"not-logged": {
"sign-in": "Inloggen",
"sign-up": "Meld je nu aan"
Expand Down