Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TECH] inclus les banner dans le layout de AppLayout #11692

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from
Open

[TECH] inclus les banner dans le layout de AppLayout #11692

wants to merge 1 commit into from

Conversation

xav-car
Copy link
Contributor

@xav-car xav-car commented Mar 14, 2025 •
edited by lionelB
Loading

🥞 Problème

Les bannière sur nos environnement de dev (et lorsqu'il y a des annonces) decale le layout de l'application vers le bas ajoutant un scroll non souhaité. cela peut cacher des boutons aux utilisateurs

🥓 Proposition

Intégrer les bannières dans le composant AppLayout

🧃 Remarques

nope nope nope

😋 Pour tester

  • aller sur orga
  • se connecter
  • voir la bannière et le menu non tronqué

@xav-car xav-car self-assigned this Mar 14, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@xav-car xav-car force-pushed the test-implem-new-layout branch 6 times, most recently from acd7a1a to 661c181 Compare March 17, 2025 17:07
@xav-car xav-car closed this Mar 17, 2025
@xav-car xav-car reopened this Mar 17, 2025
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@xav-car xav-car force-pushed the test-implem-new-layout branch from 661c181 to b6a8e0a Compare March 18, 2025 08:27
@xav-car xav-car force-pushed the test-implem-new-layout branch 6 times, most recently from fac6ba1 to 580e1c6 Compare March 20, 2025 08:18
@xav-car xav-car force-pushed the test-implem-new-layout branch 8 times, most recently from 4ef521f to 1d70013 Compare April 2, 2025 08:29
@xav-car xav-car force-pushed the test-implem-new-layout branch 2 times, most recently from 58f627a to fada8ab Compare April 2, 2025 14:14
@xav-car xav-car added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress POC Pour les PoC labels Apr 2, 2025
@xav-car xav-car force-pushed the test-implem-new-layout branch from fada8ab to 6798abb Compare April 2, 2025 14:43
@xav-car xav-car mentioned this pull request Apr 3, 2025
Merged
@xav-car xav-car force-pushed the test-implem-new-layout branch 2 times, most recently from a0a6448 to 9bf4096 Compare April 3, 2025 07:19
xav-car
xav-car commented Apr 3, 2025
View reviewed changes
orga/app/styles/pages/authenticated.scss
Comment on lines +1 to 9
.unauthenticated-page {
& > .pix-app-layout__main, .pix-app-layout__footer, .pix-app-layout__navigation {
padding: 0;
}

& > .pix-app-layout__main {
max-width: 100%;
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

permet de gérer l'affichage des page sans navigation

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Peut être que sur PixUI, il y aura des cas à gérer . affichage ou non de la nav bar ( je pense a PixApp sur la saisie de code. la nav bar apparaît pour se logger.

Ce sont des cas que nous n'avons pas sur PixOrga du coup ce fix fonctionne. Sur PixAppLayout, il faudra peut être faire différement.

@xav-car xav-car force-pushed the test-implem-new-layout branch 5 times, most recently from 70e2e31 to be1665f Compare April 4, 2025 12:14
@lionelB
Copy link
Member

lionelB commented Apr 7, 2025 •
edited
Loading

edit : c'est pas lié à la PR, on peut merger !
attention, on a un petit soucis sur le positionnement du footer image

@lionelB lionelB changed the title [POC] Test Implem Layout [TECH] inclus les banner dans le layout de AppLayout Apr 8, 2025
@alicegoarnisson alicegoarnisson added Func Review OK PO validated functionally the PR Tech Review OK and removed 👀 Func Review Needed Need PO validation for this functionally 👀 Tech Review Needed labels Apr 8, 2025
alicegoarnisson
alicegoarnisson approved these changes Apr 8, 2025
View reviewed changes
Copy link
Contributor

@alicegoarnisson alicegoarnisson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

tech ok, func ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lionelB lionelB lionelB approved these changes

@alicegoarnisson alicegoarnisson alicegoarnisson approved these changes

Assignees

@xav-car xav-car

Labels
Func Review OK PO validated functionally the PR team-prescription Tech Review OK
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@xav-car @pix-bot-github @lionelB @alicegoarnisson