-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FEATURE] Permettre de placer des custom elements dans les contenus Modulix (PIX-17186) #11700
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
dbae027
to
9c5996c
Compare
4d7995c
to
5192fd4
Compare
270fdc2
to
de4466e
Compare
dfc9d45
to
eb5961a
Compare
a5a0366
to
55d5995
Compare
nlepage
approved these changes
Mar 26, 2025
c5fc2e2
to
9d1afd1
Compare
dianeCdrPix
approved these changes
Mar 26, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Relu et testé, c'est clair :)
er-lim
reviewed
Mar 26, 2025
er-lim
approved these changes
Mar 26, 2025
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
8c4c7d2
to
ac8ea08
Compare
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
ac8ea08
to
275955b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌳 Proposition
Dans les modules on souhaite intégrer des composants personnalisés pour apporter plus de dynamisme aux modules sans être obligé d'utiliser des "embeds". Ces composants sont créés dans la librairie npm
@1024pix/epreuves-components
et consommés par Pix App.Par curiosité j'ai fait un avant/après du build généré avec ember-cli-bundle-analyzer, on observe une augmentation de ~72 KB.
Avant
Build de 2,99 MB

Après
Build de 3,06 MB.

Le surcoût principal semble directement lié à
_plugin-vue_export-helper
qui pèse ~67 KB. C'est davantage que ce qui est annoncé dans la doc de Vue (16 kb). À voir à quel point c'est fiable 🤔🐝 Remarques
Voir aussi https://github.com/1024pix/pix-epreuves/pull/2279
Mise en place inspiré de #10858 et #10866.
🤧 Pour tester
https://app-pr11700.review.pix.fr/modules/bac-a-sable