Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Permettre de placer des custom elements dans les contenus Modulix (PIX-17186) #11700

Merged
merged 2 commits into from
Mar 26, 2025

Conversation

yannbertrand
Copy link
Member

@yannbertrand yannbertrand commented Mar 14, 2025

🌳 Proposition

Dans les modules on souhaite intégrer des composants personnalisés pour apporter plus de dynamisme aux modules sans être obligé d'utiliser des "embeds". Ces composants sont créés dans la librairie npm @1024pix/epreuves-components et consommés par Pix App.

Par curiosité j'ai fait un avant/après du build généré avec ember-cli-bundle-analyzer, on observe une augmentation de ~72 KB.

Avant

Build de 2,99 MB
image

Après

Build de 3,06 MB.
image

Le surcoût principal semble directement lié à _plugin-vue_export-helper qui pèse ~67 KB. C'est davantage que ce qui est annoncé dans la doc de Vue (16 kb). À voir à quel point c'est fiable 🤔

🐝 Remarques

Voir aussi https://github.com/1024pix/pix-epreuves/pull/2279

Mise en place inspiré de #10858 et #10866.

🤧 Pour tester

https://app-pr11700.review.pix.fr/modules/bac-a-sable

@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@yannbertrand yannbertrand force-pushed the feat-allow-web-components branch from dbae027 to 9c5996c Compare March 17, 2025 14:05
@nlepage nlepage force-pushed the feat-allow-web-components branch from 4d7995c to 5192fd4 Compare March 19, 2025 15:00
@nlepage nlepage force-pushed the feat-allow-web-components branch 2 times, most recently from 270fdc2 to de4466e Compare March 24, 2025 12:50
@yannbertrand yannbertrand force-pushed the feat-allow-web-components branch 6 times, most recently from dfc9d45 to eb5961a Compare March 24, 2025 22:14
@yannbertrand yannbertrand changed the title [YOLO] Permettre de placer des web-components dans les contenus Modulix [YOLO] Permettre de placer des custom elements dans les contenus Modulix (PIX-17186) Mar 24, 2025
@yannbertrand yannbertrand changed the title [YOLO] Permettre de placer des custom elements dans les contenus Modulix (PIX-17186) [FEATURE] Permettre de placer des custom elements dans les contenus Modulix (PIX-17186) Mar 24, 2025
@yannbertrand yannbertrand force-pushed the feat-allow-web-components branch 4 times, most recently from a5a0366 to 55d5995 Compare March 26, 2025 09:07
@yannbertrand yannbertrand force-pushed the feat-allow-web-components branch 2 times, most recently from c5fc2e2 to 9d1afd1 Compare March 26, 2025 12:39
Copy link
Contributor

@dianeCdrPix dianeCdrPix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Relu et testé, c'est clair :)

Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
@yannbertrand yannbertrand force-pushed the feat-allow-web-components branch 2 times, most recently from 8c4c7d2 to ac8ea08 Compare March 26, 2025 14:54
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
@yannbertrand yannbertrand force-pushed the feat-allow-web-components branch from ac8ea08 to 275955b Compare March 26, 2025 15:10
@pix-service-auto-merge pix-service-auto-merge merged commit cb28d5f into dev Mar 26, 2025
7 of 11 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the feat-allow-web-components branch March 26, 2025 15:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants