[TECH] Pix 17139/refactor application transaction #11776
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lionelB
added
👀 Tech Review Needed
👀 Func Review Needed
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
xav-car
reviewed
Mar 20, 2025
...rner-management/infrastructure/repositories/organization-learner-import-format-repository.js
Show resolved
Hide resolved
lionelB
force-pushed
the
pix-17139/refactor-application-transaction
branch
from
4686fe4 to
8a22b78
Compare
xav-car
approved these changes
Mar 21, 2025
La-toile-cosmique
approved these changes
Mar 24, 2025
api/src/prescription/campaign-participation/application/learner-participation-controller.js
Show resolved
Hide resolved
lionelB
added
Tech Review OK
🚀 Ready to Merge
Func Review OK
…in deleteCampaigns
pix-service-auto-merge
force-pushed
the
pix-17139/refactor-application-transaction
branch
from
8a22b78 to
16b97be
Compare
pix-service-auto-merge
deleted the
pix-17139/refactor-application-transaction
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
On utilise encore ApplicationTransaction alors que cela a été déprécié en faveur de DomainTransaction
🌳 Proposition
on remplace les usages d'ApplicationTransaction par DomainTransaction
on supprime aussi la classe
🐝 Remarques
Il est apparu une methode de repo qui utilisait ApplicationTransaction sans que les usecase / controller parent ne soit transactionnel, on a donc supprimer l'usage de transaction
Idem dans un test où on stubbait ApplicationTransaction sans l'utiliser, on a supprimer le code
🤧 Pour tester
Tester la non régression de