Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Pix 17139/refactor application transaction #11776

Merged
Merged
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
refactor(api): replace ApplicationTransaction with DomainTransaction
  • Loading branch information
lionelB authored Mar 24, 2025
commit bcca85f3a09370f7f3eab7cb559885d5bd33681a
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import { DomainTransaction } from '../../../shared/domain/DomainTransaction.js';
import { monitoringTools } from '../../../shared/infrastructure/monitoring-tools.js';
import * as requestResponseUtils from '../../../shared/infrastructure/utils/request-response-utils.js';
import { ApplicationTransaction } from '../../shared/infrastructure/ApplicationTransaction.js';
import { usecases } from '../domain/usecases/index.js';
import * as campaignParticipationSerializer from '../infrastructure/serializers/jsonapi/campaign-participation-serializer.js';
import * as sharedProfileForCampaignSerializer from '../infrastructure/serializers/jsonapi/shared-profile-for-campaign-serializer.js';
@@ -21,14 +20,13 @@ const shareCampaignResult = async function (request, _) {
const userId = request.auth.credentials.userId;
const campaignParticipationId = request.params.campaignParticipationId;

await ApplicationTransaction.execute(async () => {
return DomainTransaction.execute(async () => {
await usecases.shareCampaignResult({
userId,
campaignParticipationId,
});
return null;
});

return null;
};

const beginImprovement = async function (request) {
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
import { learnerParticipationController } from '../../../../../src/prescription/campaign-participation/application/learner-participation-controller.js';
import { usecases } from '../../../../../src/prescription/campaign-participation/domain/usecases/index.js';
import { ApplicationTransaction } from '../../../../../src/prescription/shared/infrastructure/ApplicationTransaction.js';
import { DomainTransaction } from '../../../../../src/shared/domain/DomainTransaction.js';
import { domainBuilder, expect, hFake, sinon } from '../../../../test-helper.js';

@@ -25,10 +24,10 @@ describe('Unit | Application | Controller | Learner-Participation', function ()
},
};
sinon.stub(usecases, 'shareCampaignResult');
sinon.stub(ApplicationTransaction, 'execute').callsFake((callback) => {
sinon.stub(DomainTransaction, 'execute').callsFake((callback) => {
return callback();
});
sinon.stub(ApplicationTransaction, 'getTransactionAsDomainTransaction');
sinon.stub(DomainTransaction, 'getConnection');
});

it('should call the usecase to share campaign result', async function () {