-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TECH] Créer un script pour importer la date de dernière connexion (lastLoggedAt) (PIX-10728) #11814
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
pix-10728-import-user-last-logged-at
Mar 28, 2025
Merged
[TECH] Créer un script pour importer la date de dernière connexion (lastLoggedAt) (PIX-10728) #11814
pix-service-auto-merge
merged 3 commits into
dev
from
pix-10728-import-user-last-logged-at
Mar 28, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
908e788
to
1774a1e
Compare
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/scripts/import-user-last-logged-at.script.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/scripts/import-user-last-logged-at.script.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/domain/usecases/import-user-last-logged-at.usecase.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/scripts/import-user-last-logged-at.script.js
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/domain/usecases/import-user-last-logged-at.usecase.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/domain/usecases/import-user-last-logged-at.usecase.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/scripts/import-user-last-logged-at.script.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
api/src/identity-access-management/scripts/import-user-last-logged-at.script.js
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
...ity-access-management/integration/domain/usecases/import-user-last-logged-at.usecase.test.js
Outdated
Show resolved
Hide resolved
bpetetot
reviewed
Mar 25, 2025
...ity-access-management/integration/domain/usecases/import-user-last-logged-at.usecase.test.js
Outdated
Show resolved
Hide resolved
4cd6c0d
to
0cfdc1a
Compare
api/src/identity-access-management/domain/usecases/import-user-last-logged-at.usecase.js
Outdated
Show resolved
Hide resolved
0cfdc1a
to
c1bac95
Compare
...ity-access-management/integration/domain/usecases/import-user-last-logged-at.usecase.test.js
Outdated
Show resolved
Hide resolved
...ity-access-management/integration/domain/usecases/import-user-last-logged-at.usecase.test.js
Show resolved
Hide resolved
api/src/identity-access-management/domain/usecases/import-user-last-logged-at.usecase.js
Outdated
Show resolved
Hide resolved
c1bac95
to
f70785e
Compare
d022111
to
1e1cf84
Compare
lego-technix
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Lu et testé fonctionnellement avec succès avec Firefox 🦊
bpetetot
reviewed
Mar 26, 2025
api/src/identity-access-management/infrastructure/repositories/user.repository.js
Show resolved
Hide resolved
bpetetot
reviewed
Mar 26, 2025
api/src/identity-access-management/scripts/import-user-last-logged-at.script.js
Show resolved
Hide resolved
652321d
to
7b29878
Compare
bpetetot
approved these changes
Mar 27, 2025
7b29878
to
5c7fdba
Compare
59ec5a6
to
3a6fc0b
Compare
3a6fc0b
to
6dc7ae4
Compare
6dc7ae4
to
cea4b19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Environ 2 millions d’utilisateurs n’ont pas de valeur renseignée sur le champ “user-logins.lastLoggedAt”. Or depuis l’extraction de la donnée en décembre 2023, il est possible que des utilisateurs identifiés se soient reconnectés.
🌳 Proposition
Créer un script pour ajouter l’information en BD dans la colonne lastLoggedAt de la table user-logins
🐝 Remarques
Critères de création du script
Est-ce que le user existe en base ?
Non alors on passe au suivant
Oui alors on continue
Est-ce que le user est anonymisé ?
Non alors on continue
Oui alors on passe au suivant
Vérification sur le champ “users-logins.lastLoggedAt” dans users logins
Si champ “last logged at” est renseigné alors on passe au suivant
Si champ “last logged at” n'est pas renseigné alors passer à l’étape suivante
Si l’utilisateur n’a aucune valeur renseignée dans la colonne “user-logins.lastLoggedAt” alors
🤧 Pour tester
scalingo -a pix-api-review-pr11814 run --file CHEMIN_DU_CSV_LOCAL > node src/identity-access-management/scripts/import-user-last-logged-at.script.js --file /tmp/uploads/NOM_DU_CSV.csv
avec ce csv (utilisateurs en RA n'ayant pas de lastLoggedAt):
Verifier que le script s'execute correctement et que les 3 utilisateur ont désormais un lastLoggedAt
Lancer la commande suivant pour les copains qui veulent tester de leur côté 🫶🏻