Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TECH] Créer un script pour importer la date de dernière connexion (lastLoggedAt) (PIX-10728) #11814

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

P-Jeremy
Copy link
Contributor

@P-Jeremy P-Jeremy commented Mar 24, 2025

🌸 Problème

Environ 2 millions d’utilisateurs n’ont pas de valeur renseignée sur le champ “user-logins.lastLoggedAt”. Or depuis l’extraction de la donnée en décembre 2023, il est possible que des utilisateurs identifiés se soient reconnectés.

🌳 Proposition

Créer un script pour ajouter l’information en BD dans la colonne lastLoggedAt de la table user-logins

🐝 Remarques

Critères de création du script

  • Est-ce que le user existe en base ?

    • Non alors on passe au suivant

    • Oui alors on continue

  • Est-ce que le user est anonymisé ?

    • Non alors on continue

    • Oui alors on passe au suivant

  • Vérification sur le champ “users-logins.lastLoggedAt” dans users logins

    • Si champ “last logged at” est renseigné alors on passe au suivant

    • Si champ “last logged at” n'est pas renseigné alors passer à l’étape suivante

  • Si l’utilisateur n’a aucune valeur renseignée dans la colonne “user-logins.lastLoggedAt” alors

    • Ajouter la valeur renseigné dans “last_activity” dans le champ “users-logins.lastLoggedAt”

🤧 Pour tester

  • Executer le script suivant scalingo -a pix-api-review-pr11814 run --file CHEMIN_DU_CSV_LOCAL > node src/identity-access-management/scripts/import-user-last-logged-at.script.js --file /tmp/uploads/NOM_DU_CSV.csv

avec ce csv (utilisateurs en RA n'ayant pas de lastLoggedAt):

userId,last_activity
107613,2017-09-05 14:00:08+0000
107616,2018-03-02 15:26:16+0000
107621,2018-03-02 15:26:16+0000
  • Verifier que le script s'execute correctement et que les 3 utilisateur ont désormais un lastLoggedAt

  • Lancer la commande suivant pour les copains qui veulent tester de leur côté 🫶🏻

UPDATE "user-logins"
SET "lastLoggedAt = null
WHERE "userId" IN (107621, 107616, 107613);

@P-Jeremy P-Jeremy self-assigned this Mar 24, 2025
@P-Jeremy P-Jeremy requested a review from a team as a code owner March 24, 2025 14:52
@P-Jeremy P-Jeremy removed the request for review from a team March 24, 2025 14:52
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@P-Jeremy P-Jeremy force-pushed the pix-10728-import-user-last-logged-at branch 2 times, most recently from 908e788 to 1774a1e Compare March 24, 2025 15:34
@P-Jeremy P-Jeremy force-pushed the pix-10728-import-user-last-logged-at branch 2 times, most recently from 4cd6c0d to 0cfdc1a Compare March 25, 2025 10:12
@P-Jeremy P-Jeremy added 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally and removed Development in progress labels Mar 25, 2025
@lego-technix lego-technix self-requested a review March 25, 2025 10:36
@P-Jeremy P-Jeremy force-pushed the pix-10728-import-user-last-logged-at branch from 0cfdc1a to c1bac95 Compare March 25, 2025 10:46
@P-Jeremy P-Jeremy force-pushed the pix-10728-import-user-last-logged-at branch from c1bac95 to f70785e Compare March 25, 2025 13:09
@P-Jeremy P-Jeremy force-pushed the pix-10728-import-user-last-logged-at branch 2 times, most recently from d022111 to 1e1cf84 Compare March 25, 2025 13:21
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et testé fonctionnellement avec succès avec Firefox 🦊

@P-Jeremy P-Jeremy force-pushed the pix-10728-import-user-last-logged-at branch 2 times, most recently from 652321d to 7b29878 Compare March 27, 2025 11:29
@P-Jeremy P-Jeremy requested a review from bpetetot March 27, 2025 13:03
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-10728-import-user-last-logged-at branch from 7b29878 to 5c7fdba Compare March 27, 2025 13:25
@P-Jeremy P-Jeremy added Tech Review OK Func Review OK PO validated functionally the PR and removed 👀 Tech Review Needed 👀 Func Review Needed Need PO validation for this functionally labels Mar 27, 2025
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-10728-import-user-last-logged-at branch 3 times, most recently from 59ec5a6 to 3a6fc0b Compare March 27, 2025 14:18
@yaf yaf force-pushed the pix-10728-import-user-last-logged-at branch from 3a6fc0b to 6dc7ae4 Compare March 28, 2025 07:18
@pix-service-auto-merge pix-service-auto-merge force-pushed the pix-10728-import-user-last-logged-at branch from 6dc7ae4 to cea4b19 Compare March 28, 2025 07:56
@pix-service-auto-merge pix-service-auto-merge merged commit 2fa2d3f into dev Mar 28, 2025
9 of 11 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the pix-10728-import-user-last-logged-at branch March 28, 2025 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants