-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUGFIX] Enregistrer la route /api/application/token
sur MaDDo
#11816
Merged
pix-service-auto-merge
merged 3 commits into
dev
from
fix-missing-route-application-token
Mar 25, 2025
Merged
[BUGFIX] Enregistrer la route /api/application/token
sur MaDDo
#11816
pix-service-auto-merge
merged 3 commits into
dev
from
fix-missing-route-application-token
Mar 25, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
aurelie-crouillebois
approved these changes
Mar 24, 2025
7b80b88
to
c3558a0
Compare
...ess-management/integration/infrastructure/repositories/client-application.repository.test.js
Show resolved
Hide resolved
lego-technix
approved these changes
Mar 25, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Lu et validé avec succès pour l'équipe Accès
VincentHardouin
approved these changes
Mar 25, 2025
Co-authored-by: Ce que tu veux <guillaume.lagorce@pix.fr> Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr> Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Aurélie Crouillebois <aurelie.crouillebois@pix.fr>
c3558a0
to
bc752f6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Func Review OK
PO validated functionally the PR
🚀 Ready to Merge
team-maddo
Mise à Dispo de Données
Tech Review OK
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Suite au déplacement de la route
/api/application/token
dans src, celle-ci n’est plus enregistrée sur l’API MaDDo.🌳 Proposition
Enregistrer la route
/api/application/token
sur l’API MaDDo.🐝 Remarques
On utilise les tags pour filtrer les routes enregistrées par la fonction
register
des routes IAM.D'après l'API de Hapi les tags sont disponibles dans
route.config
ouroute.option
et il faut donc pouvoir gérer ces 2 cas.🤧 Pour tester
Vérifier que la méthode POST
/api/application/token
répond autre chose que 404 sur l’API MaDDo.Vérifier que toutes les routes IAM sont présentes sur l’API Pix.