Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUGFIX] Enregistrer la route /api/application/token sur MaDDo #11816

Merged
merged 3 commits into from
Mar 25, 2025

Conversation

nlepage
Copy link
Member

@nlepage nlepage commented Mar 24, 2025

🌸 Problème

Suite au déplacement de la route /api/application/token dans src, celle-ci n’est plus enregistrée sur l’API MaDDo.

🌳 Proposition

Enregistrer la route /api/application/token sur l’API MaDDo.

🐝 Remarques

On utilise les tags pour filtrer les routes enregistrées par la fonction register des routes IAM.

D'après l'API de Hapi les tags sont disponibles dans route.config ou route.option et il faut donc pouvoir gérer ces 2 cas.

🤧 Pour tester

Vérifier que la méthode POST /api/application/token répond autre chose que 404 sur l’API MaDDo.

Vérifier que toutes les routes IAM sont présentes sur l’API Pix.

@nlepage nlepage added 👀 Tech Review Needed team-maddo Mise à Dispo de Données labels Mar 24, 2025
@nlepage nlepage self-assigned this Mar 24, 2025
@nlepage nlepage requested a review from a team as a code owner March 24, 2025 15:44
@pix-bot-github
Copy link

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

@HEYGUL HEYGUL force-pushed the fix-missing-route-application-token branch from 7b80b88 to c3558a0 Compare March 25, 2025 07:35
Copy link
Contributor

@lego-technix lego-technix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Lu et validé avec succès pour l'équipe Accès

nlepage and others added 3 commits March 25, 2025 10:56
Co-authored-by: Ce que tu veux <guillaume.lagorce@pix.fr>
Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Nicolas Lepage <nicolas.lepage@pix.fr>
Co-authored-by: Vincent Hardouin <vincent.hardouin@pix.fr>
Co-authored-by: Aurélie Crouillebois <aurelie.crouillebois@pix.fr>
@pix-service-auto-merge pix-service-auto-merge force-pushed the fix-missing-route-application-token branch from c3558a0 to bc752f6 Compare March 25, 2025 10:56
@pix-service-auto-merge pix-service-auto-merge merged commit f97d55d into dev Mar 25, 2025
7 of 11 checks passed
@pix-service-auto-merge pix-service-auto-merge deleted the fix-missing-route-application-token branch March 25, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Func Review OK PO validated functionally the PR 🚀 Ready to Merge team-maddo Mise à Dispo de Données Tech Review OK
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants