[FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech (PIX-17215) #11842

yannbertrand · 2025-03-25T15:20:57Z

🌸 Problème

Dans les modules il est possible d'utiliser des images temporaires hébergées un peu n'importe où pour garder en flexibilité lors de la conception des contenus de modules. Une fois le module validé on souhaite contrôler où sont hébergées nos images.

🌳 Proposition

Ajouter une couche de validation automatisée sur les modules prêts à la production (isBeta === false), pour le moment pour s'assurer que les images respectent nos critères d'hébergement.

En terme de contenu, les 8 modules "en prod" sont concernés par cette erreur. On propose :

déplacer les assets du module jeu-video-enfant depuis images.pix.fr vers assets.pix.org.
repasser les 7 autres modules en béta le temps de migrer.

Aussi, ajout d'un check que l'URL est valide (même si déjà fait côté schéma Joi) pour s'éviter d'autres erreurs techniques...

🐝 Remarques

C'est un POC d'aprem tech.

🤧 Pour tester

Voir que la CI en l'état jette des erreurs pour toute image non hébergée sur assets.pix.org.

github-actions · 2025-03-25T15:21:54Z

Les tests Modulix ont échoué. Voici les détails :


> pix-api@5.71.0 modulix:test
> npm run test:api:path -- 'tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js' 'tests/devcomp/acceptance/module-instantiation_test.js' 'tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js' 'tests/devcomp/integration/repositories/module-repository_test.js'


> pix-api@5.71.0 test:api:path
> NODE_ENV=test mocha --exit --recursive --reporter=${MOCHA_REPORTER:-dot} tests/devcomp/unit/infrastructure/datasources/learning-content/module-datasource_test.js tests/devcomp/acceptance/module-instantiation_test.js tests/devcomp/unit/infrastructure/datasources/learning-content/validation/module-validation_test.js tests/devcomp/integration/repositories/module-repository_test.js



  .......................!!........!..!!!!................
  .....

  54 passing (11s)
  7 failing

  1) Acceptance | Modules
       Verify modules
         module bases-clavier-1 should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

  2) Acceptance | Modules
       Verify modules
         module bases-clavier-2 should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

  3) Acceptance | Modules
       Verify modules
         module ports-connexions-essentiels should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

  4) Acceptance | Modules
       Verify modules
         module tmp08ef should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

  5) Acceptance | Modules
       Verify modules
         module tri-multicritere-tableau should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

  6) Acceptance | Modules
       Verify modules
         module utiliser-souris-ordinateur-1 should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

  7) Acceptance | Modules
       Verify modules
         module utiliser-souris-ordinateur-2 should respect the domain:
     AssertionError: The image URL must be from "assets.pix.org" when module is production ready
      at Context.<anonymous> (file:///home/runner/work/pix/pix/api/tests/devcomp/acceptance/module-instantiation_test.js:22:18)
      at Runnable.run (file:///home/runner/work/pix/pix/api/tests/tooling/mocha-tools.js:8:29)
      at process.processImmediate (node:internal/timers:491:21)

pix-bot-github · 2025-03-25T15:22:46Z

Une fois les applications déployées, elles seront accessibles via les liens suivants :

Les variables d'environnement seront accessibles via les liens suivants :

dianeCdrPix · 2025-03-26T14:27:29Z

api/src/devcomp/domain/models/element/Image.js

 import { assertNotNullOrUndefined } from '../../../../shared/domain/models/asserts.js';
 import { Element } from './Element.js';

 class Image extends Element {
+  static #VALID_PRODUCTION_HOSTNAME = 'assets.pix.org';


Suggestion : variabiliser le hostname pour éviter que ce soit trop en clair dans le repo ?

Discuté ensemble, ça reste hautement expérimental et temporaire, on ne s'embête pas à le variabiliser pour le moment

dianeCdrPix · 2025-03-26T14:29:38Z

api/tests/devcomp/unit/domain/models/element/Image_test.js

@@ -62,11 +74,35 @@ describe('Unit | Devcomp | Domain | Models | Element | Image', function () {
  describe('An image without an alternative text', function () {
    it('should throw an error', function () {
      // when
-      const error = catchErrSync(() => new Image({ id: 'id', url: 'url', alt: 'alt' }))();
+      const error = catchErrSync(() => new Image({ id: 'id', url: 'https://images.pix.fr/coolcat.jpg', alt: 'alt' }))();


Coolman qui choisit l'image Coolcat .. La Brigade du cool a encore frappé

api/tests/devcomp/unit/infrastructure/factories/module-factory_test.js

yannbertrand added team-devcomp contribution-modulix labels Mar 25, 2025

yannbertrand assigned yannbertrand, Eithliu and alicepeltier Mar 25, 2025

yannbertrand requested a review from a team as a code owner March 25, 2025 15:20

yannbertrand force-pushed the tech-test-image-production-readiness branch 2 times, most recently from db7c65b to 19b55fe Compare March 25, 2025 16:58

yannbertrand changed the title ~~[FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech~~ [FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech (PIX-17215) Mar 26, 2025

dianeCdrPix reviewed Mar 26, 2025

View reviewed changes

api/tests/devcomp/unit/infrastructure/factories/module-factory_test.js Outdated Show resolved Hide resolved

dianeCdrPix approved these changes Mar 26, 2025

View reviewed changes

api/tests/devcomp/unit/infrastructure/factories/module-factory_test.js Outdated Show resolved Hide resolved

yannbertrand force-pushed the tech-test-image-production-readiness branch 2 times, most recently from cdf2940 to 5b816f1 Compare March 26, 2025 15:00

yannbertrand added 4 commits March 26, 2025 16:21

fix(api): jsdoc

8baf27d

feat(api): check image production readiness

d5af493

feat(api): add check on production ready images

26e105f

fix(api): set isBeta true on modules failing validation

a706046

yannbertrand force-pushed the tech-test-image-production-readiness branch from 5b816f1 to a706046 Compare March 26, 2025 15:21

yannbertrand added the 🚀 Ready to Merge label Mar 26, 2025

pix-service-auto-merge merged commit eea0294 into dev Mar 26, 2025
7 of 11 checks passed

pix-service-auto-merge deleted the tech-test-image-production-readiness branch March 26, 2025 15:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech (PIX-17215) #11842

[FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech (PIX-17215) #11842

yannbertrand commented Mar 25, 2025 •

edited

Loading

github-actions bot commented Mar 25, 2025

pix-bot-github commented Mar 25, 2025

dianeCdrPix Mar 26, 2025

yannbertrand Mar 26, 2025

dianeCdrPix Mar 26, 2025

[FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech (PIX-17215) #11842

[FEATURE] S'assurer que les images de Modules de prod respectent les contraintes tech (PIX-17215) #11842

Conversation

yannbertrand commented Mar 25, 2025 • edited Loading

🌸 Problème

🌳 Proposition

🐝 Remarques

🤧 Pour tester

github-actions bot commented Mar 25, 2025

pix-bot-github commented Mar 25, 2025

dianeCdrPix Mar 26, 2025

Choose a reason for hiding this comment

yannbertrand Mar 26, 2025

Choose a reason for hiding this comment

dianeCdrPix Mar 26, 2025

Choose a reason for hiding this comment

yannbertrand commented Mar 25, 2025 •

edited

Loading