[FEATURE] Autoriser un participant avec une participation précédente supprimée à re-participer (PIX-15809) #11934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
machestla
added
👀 Tech Review Needed
👀 Func Review Needed
|
Une fois les applications déployées, elles seront accessibles via les liens suivants :
Les variables d'environnement seront accessibles via les liens suivants : |
lionelB
reviewed
Apr 2, 2025
|
|
||
| expect(error).to.be.an.instanceof(ForbiddenAccess); | ||
| expect(error.message).to.equal('Vous ne pouvez pas repasser la campagne'); | ||
| expect(() => campaignParticipant.start({ participantExternalId: null })).to.not.throw(); |
There was a problem hiding this comment.
proposition: on pourrait supprimer le test complétement car la propriété previousCampaignParticipationForUser sera vide en cas de participation anonymisée.
lionelB
approved these changes
Apr 2, 2025
machestla
force-pushed
the
pix-15809-re-participate-to-campaign-after-participation-deleted
branch
from
95dd7a3 to
0c6fb13
Compare
alicegoarnisson
added
Func Review OK
pix-service-auto-merge
force-pushed
the
pix-15809-re-participate-to-campaign-after-participation-deleted
branch
from
0c6fb13 to
6704db5
Compare
yaf
force-pushed
the
pix-15809-re-participate-to-campaign-after-participation-deleted
branch
from
6704db5 to
eabe6bb
Compare
pix-service-auto-merge
deleted the
pix-15809-re-participate-to-campaign-after-participation-deleted
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🌸 Problème
Ce bout de code ne sera plus fonctionnel car la suppression d'une participation anonymisera cette dernière. Nous ne pourrons donc plus vérifier ce cas.
🌳 Proposition
Supprimer cette condition
🐝 Remarques
J'ai laissé le test car j'ai testé que ça ne throw pas.
🤧 Pour tester